[0/5] Add USB Support on Qualcomm's SDX75 Platform

Message

Rohit Agarwal Sept. 5, 2023, 4:43 a.m. UTC

Hi,

This series adds support of USB3 PHY support for Qualcomm's SDX75 Platform.

Thanks,
Rohit.

Rohit Agarwal (5):
  dt-bindings: phy: qcom,snps-eusb2-phy: Add compatible for SDX75
  dt-bindings: phy: Add qcom,sdx75-qmp-usb3-uni schema file
  dt-bindings: usb: dwc3: Add missing SDX65 compatible
  dt-bindings: usb: dwc3: Add SDX75 compatible
  phy: qcom-qmp-usb: Add Qualcomm SDX75 USB3 PHY support

 .../bindings/phy/qcom,sdx75-qmp-usb3-uni-phy.yaml  | 106 ++++++++++++++
 .../bindings/phy/qcom,snps-eusb2-phy.yaml          |   7 +-
 .../devicetree/bindings/usb/qcom,dwc3.yaml         |   4 +
 drivers/phy/qualcomm/phy-qcom-qmp-usb.c            | 160 +++++++++++++++++++++
 4 files changed, 276 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/phy/qcom,sdx75-qmp-usb3-uni-phy.yaml

Comments

Krzysztof Kozlowski Sept. 5, 2023, 6:49 a.m. UTC | #1

On 05/09/2023 06:43, Rohit Agarwal wrote:
> Add a dt-binding schema for SDX75 SoC.
> 

It's the same as qcom,ipq9574-qmp-usb3-phy.

Best regards,
Krzysztof

Rohit Agarwal Sept. 5, 2023, 7:08 a.m. UTC | #2

On 9/5/2023 12:19 PM, Krzysztof Kozlowski wrote:
> On 05/09/2023 06:43, Rohit Agarwal wrote:
>> Add a dt-binding schema for SDX75 SoC.
>>
> It's the same as qcom,ipq9574-qmp-usb3-phy.
Seems like this change is not in the tree. Will rebase my change on top 
of it and mention the dependency.

Thanks,
Rohit.
>
> Best regards,
> Krzysztof
>

Rohit Agarwal Sept. 5, 2023, 7:12 a.m. UTC | #3

On 9/5/2023 12:23 PM, Krzysztof Kozlowski wrote:
> On 05/09/2023 06:43, Rohit Agarwal wrote:
>> Add support for USB3 QMP PHY found in SDX75 platform.
>>
>> Signed-off-by: Rohit Agarwal <[e-mail]>
>> ---
>
>
>>   
>> +static const struct qmp_phy_cfg sdx75_usb3_uniphy_cfg = {
>> +	.lanes			= 1,
>> +	.offsets		= &qmp_usb_offsets_v5,
>> +
>> +	.serdes_tbl		= sdx75_usb3_uniphy_serdes_tbl,
>> +	.serdes_tbl_num		= ARRAY_SIZE(sdx75_usb3_uniphy_serdes_tbl),
>> +	.tx_tbl			= sdx75_usb3_uniphy_tx_tbl,
>> +	.tx_tbl_num		= ARRAY_SIZE(sdx75_usb3_uniphy_tx_tbl),
>> +	.rx_tbl			= sdx75_usb3_uniphy_rx_tbl,
>> +	.rx_tbl_num		= ARRAY_SIZE(sdx75_usb3_uniphy_rx_tbl),
>> +	.pcs_tbl		= sdx75_usb3_uniphy_pcs_tbl,
>> +	.pcs_tbl_num		= ARRAY_SIZE(sdx75_usb3_uniphy_pcs_tbl),
>> +	.pcs_usb_tbl		= sdx75_usb3_uniphy_pcs_usb_tbl,
>> +	.pcs_usb_tbl_num	= ARRAY_SIZE(sdx75_usb3_uniphy_pcs_usb_tbl),
>> +	.clk_list		= qmp_v4_sdx55_usbphy_clk_l,
>> +	.num_clks		= ARRAY_SIZE(qmp_v4_sdx55_usbphy_clk_l),
>> +	.reset_list		= msm8996_usb3phy_reset_l,
>> +	.num_resets		= ARRAY_SIZE(msm8996_usb3phy_reset_l),
>> +	.vreg_list		= qmp_phy_vreg_l,
>> +	.num_vregs		= ARRAY_SIZE(qmp_phy_vreg_l),
>> +	.regs			= qmp_v5_usb3phy_regs_layout,
>> +	.pcs_usb_offset		= 0x1000,
>> +
>> +	.has_pwrdn_delay	= true,
>> +
> Stray blank line
>
>> +};
>> +
>>   static const struct qmp_phy_cfg sm8350_usb3phy_cfg = {
>>   	.lanes			= 2,
>>   
>> @@ -1985,6 +2141,7 @@ static int qmp_usb_init(struct phy *phy)
>>   	void __iomem *dp_com = qmp->dp_com;
>>   	int ret;
>>   
>> +
> No need for this.
This got added because I was trying to debug earlier. Sorry for this.
But this should get caught by checkpatch, shouldnt it? I did run 
checkpatch script.

Thanks,
Rohit.
>
> Best regards,
> Krzysztof
>

Rohit Agarwal Sept. 5, 2023, 7:27 a.m. UTC | #4

On 9/5/2023 12:50 PM, Krzysztof Kozlowski wrote:
> On 05/09/2023 09:08, Rohit Agarwal wrote:
>> On 9/5/2023 12:19 PM, Krzysztof Kozlowski wrote:
>>> On 05/09/2023 06:43, Rohit Agarwal wrote:
>>>> Add a dt-binding schema for SDX75 SoC.
>>>>
>>> It's the same as qcom,ipq9574-qmp-usb3-phy.
>> Seems like this change is not in the tree. Will rebase my change on top
>> of it and mention the dependency.
> ??? We do not talk about maintainer tree nor next. This was merged in
> mainline. You work on some old tree.
>
> Sorry, rebase and recheck all your patches on latest next. This includes
> running smatch, sparse and coccinelle. Do not develop on anything older
> than maintainer tree or next.
Oh, Not Sure which file I was looking into. Now got it. This change is 
present in qcom,sc8280xp-qmp-usb3-uni-phy.yaml.
Will update this to reuse the same bindings file and add the compatible 
string here.

Thanks,
Rohit.
>
> Best regards,
> Krzysztof
>