| Message ID | 20230905133243.31550-1-davthompson@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [v1] mlxbf-bootctl: add NET dependency into Kconfig | expand |
Hi, On 9/5/23 06:32, David Thompson wrote: > The latest version of the mlxbf_bootctl driver utilizes > "sysfs_format_mac", and this API is only available if > NET is defined in the kernel configuration. This patch > changes the mlxbf_bootctl Kconfig to depend on NET. > > Reported-by: kernel test robot <lkp@intel.com> Also Reported-by: Randy Dunlap <rdunlap@infradead.org> > Closes: https://lore.kernel.org/oe-kbuild-all/202309031058.JvwNDBKt-lkp@intel.com/ > Signed-off-by: David Thompson <davthompson@nvidia.com> > --- > drivers/platform/mellanox/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/mellanox/Kconfig b/drivers/platform/mellanox/Kconfig > index 382793e73a60..e52aea996ca5 100644 > --- a/drivers/platform/mellanox/Kconfig > +++ b/drivers/platform/mellanox/Kconfig > @@ -60,6 +60,7 @@ config MLXBF_BOOTCTL > tristate "Mellanox BlueField Firmware Boot Control driver" > depends on ARM64 > depends on ACPI > + depends on NET > help > The Mellanox BlueField firmware implements functionality to > request swapping the primary and alternate eMMC boot partition, I'm sure that this will fix the build problem, but I don't see this being a network driver. To me it looks like some management s/w that can run independently of networking software. It just wants to show/store a MAC address -- no networking. FWIW.
Hi, On 9/5/23 15:32, David Thompson wrote: > The latest version of the mlxbf_bootctl driver utilizes > "sysfs_format_mac", and this API is only available if > NET is defined in the kernel configuration. This patch > changes the mlxbf_bootctl Kconfig to depend on NET. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202309031058.JvwNDBKt-lkp@intel.com/ > Signed-off-by: David Thompson <davthompson@nvidia.com> Thank you for your patch, I've applied this patch to my fixes branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes Note it will show up in my fixes branch once I've pushed my local branch there, which might take a while. I will include this patch in my next fixes pull-req to Linus for the current kernel development cycle. Regards, Hans > --- > drivers/platform/mellanox/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/mellanox/Kconfig b/drivers/platform/mellanox/Kconfig > index 382793e73a60..e52aea996ca5 100644 > --- a/drivers/platform/mellanox/Kconfig > +++ b/drivers/platform/mellanox/Kconfig > @@ -60,6 +60,7 @@ config MLXBF_BOOTCTL > tristate "Mellanox BlueField Firmware Boot Control driver" > depends on ARM64 > depends on ACPI > + depends on NET > help > The Mellanox BlueField firmware implements functionality to > request swapping the primary and alternate eMMC boot partition,
diff --git a/drivers/platform/mellanox/Kconfig b/drivers/platform/mellanox/Kconfig index 382793e73a60..e52aea996ca5 100644 --- a/drivers/platform/mellanox/Kconfig +++ b/drivers/platform/mellanox/Kconfig @@ -60,6 +60,7 @@ config MLXBF_BOOTCTL tristate "Mellanox BlueField Firmware Boot Control driver" depends on ARM64 depends on ACPI + depends on NET help The Mellanox BlueField firmware implements functionality to request swapping the primary and alternate eMMC boot partition,
The latest version of the mlxbf_bootctl driver utilizes "sysfs_format_mac", and this API is only available if NET is defined in the kernel configuration. This patch changes the mlxbf_bootctl Kconfig to depend on NET. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202309031058.JvwNDBKt-lkp@intel.com/ Signed-off-by: David Thompson <davthompson@nvidia.com> --- drivers/platform/mellanox/Kconfig | 1 + 1 file changed, 1 insertion(+)