diff mbox series

[iproute2] iplink_bridge: fix incorrect root id dump

Message ID 20230901080226.424931-1-liuhangbin@gmail.com (mailing list archive)
State Accepted
Commit 3181d4e14964d7845ca9730ec6b4d7b72f3712c5
Delegated to: Stephen Hemminger
Headers show
Series [iproute2] iplink_bridge: fix incorrect root id dump | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

Hangbin Liu Sept. 1, 2023, 8:02 a.m. UTC
Fix the typo when dump root_id.

Fixes: 70dfb0b8836d ("iplink: bridge: export bridge_id and designated_root")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
 ip/iplink_bridge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Nikolay Aleksandrov Sept. 3, 2023, 8:38 a.m. UTC | #1
On 9/1/23 11:02, Hangbin Liu wrote:
> Fix the typo when dump root_id.
> 
> Fixes: 70dfb0b8836d ("iplink: bridge: export bridge_id and designated_root")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
>   ip/iplink_bridge.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ip/iplink_bridge.c b/ip/iplink_bridge.c
> index 7e4e62c81c0c..462075295308 100644
> --- a/ip/iplink_bridge.c
> +++ b/ip/iplink_bridge.c
> @@ -499,7 +499,7 @@ static void bridge_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
>   	if (tb[IFLA_BR_ROOT_ID]) {
>   		char root_id[32];
>   
> -		br_dump_bridge_id(RTA_DATA(tb[IFLA_BR_BRIDGE_ID]), root_id,
> +		br_dump_bridge_id(RTA_DATA(tb[IFLA_BR_ROOT_ID]), root_id,
>   				  sizeof(root_id));
>   		print_string(PRINT_ANY,
>   			     "root_id",

Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
patchwork-bot+netdevbpf@kernel.org Sept. 6, 2023, 2:50 p.m. UTC | #2
Hello:

This patch was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@networkplumber.org>:

On Fri,  1 Sep 2023 16:02:26 +0800 you wrote:
> Fix the typo when dump root_id.
> 
> Fixes: 70dfb0b8836d ("iplink: bridge: export bridge_id and designated_root")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
>  ip/iplink_bridge.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [iproute2] iplink_bridge: fix incorrect root id dump
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=3181d4e14964

You are awesome, thank you!
diff mbox series

Patch

diff --git a/ip/iplink_bridge.c b/ip/iplink_bridge.c
index 7e4e62c81c0c..462075295308 100644
--- a/ip/iplink_bridge.c
+++ b/ip/iplink_bridge.c
@@ -499,7 +499,7 @@  static void bridge_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
 	if (tb[IFLA_BR_ROOT_ID]) {
 		char root_id[32];
 
-		br_dump_bridge_id(RTA_DATA(tb[IFLA_BR_BRIDGE_ID]), root_id,
+		br_dump_bridge_id(RTA_DATA(tb[IFLA_BR_ROOT_ID]), root_id,
 				  sizeof(root_id));
 		print_string(PRINT_ANY,
 			     "root_id",