| Message ID | ec5a4071691ab08d58771b7732a9988e89779268.1693828363.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | Restrict Mellanox platform and i2c dependencies | expand |
> -----Original Message----- > From: Geert Uytterhoeven <geert+renesas@glider.be> > Sent: Monday, 4 September 2023 15:01 > To: Andi Shyti <andi.shyti@kernel.org>; Hans de Goede <hdegoede@redhat.com>; > Mark Gross <markgross@kernel.org>; Vadim Pasternak <vadimp@nvidia.com>; > Michael Shych <michaelsh@nvidia.com>; Wolfram Sang <wsa@kernel.org> > Cc: linux-i2c@vger.kernel.org; platform-driver-x86@vger.kernel.org; linux- > kernel@vger.kernel.org; Geert Uytterhoeven <geert+renesas@glider.be> > Subject: [PATCH 1/2] platform/mellanox: NVSW_SN2201 should depend on ACPI > > The only probing method supported by the Nvidia SN2201 platform driver is > probing through an ACPI match table. Hence add a dependency on ACPI, to > prevent asking the user about this driver when configuring a kernel without ACPI > support. > > Fixes: 662f24826f954d49 ("platform/mellanox: Add support for new SN2201 > system") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Vadim Pasternak <vadimp@nvidia.com> > --- > drivers/platform/mellanox/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/mellanox/Kconfig b/drivers/platform/mellanox/Kconfig > index 382793e73a60a8b3..30b50920b278c94b 100644 > --- a/drivers/platform/mellanox/Kconfig > +++ b/drivers/platform/mellanox/Kconfig > @@ -80,8 +80,8 @@ config MLXBF_PMC > > config NVSW_SN2201 > tristate "Nvidia SN2201 platform driver support" > - depends on HWMON > - depends on I2C > + depends on HWMON && I2C > + depends on ACPI || COMPILE_TEST > select REGMAP_I2C > help > This driver provides support for the Nvidia SN2201 platform. > -- > 2.34.1
Hi Geert, On Mon, Sep 04, 2023 at 02:00:35PM +0200, Geert Uytterhoeven wrote: > The only probing method supported by the Nvidia SN2201 platform driver > is probing through an ACPI match table. Hence add a dependency on > ACPI, to prevent asking the user about this driver when configuring a > kernel without ACPI support. > > Fixes: 662f24826f954d49 ("platform/mellanox: Add support for new SN2201 system") I don't think the Fixes tag is needed here... > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/platform/mellanox/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/mellanox/Kconfig b/drivers/platform/mellanox/Kconfig > index 382793e73a60a8b3..30b50920b278c94b 100644 > --- a/drivers/platform/mellanox/Kconfig > +++ b/drivers/platform/mellanox/Kconfig > @@ -80,8 +80,8 @@ config MLXBF_PMC > > config NVSW_SN2201 > tristate "Nvidia SN2201 platform driver support" > - depends on HWMON > - depends on I2C > + depends on HWMON && I2C > + depends on ACPI || COMPILE_TEST Acked-by: Andi Shyti <andi.shyti@kernel.org> Andi > select REGMAP_I2C > help > This driver provides support for the Nvidia SN2201 platform. > -- > 2.34.1 >
Hi, On 9/4/23 14:00, Geert Uytterhoeven wrote: > The only probing method supported by the Nvidia SN2201 platform driver > is probing through an ACPI match table. Hence add a dependency on > ACPI, to prevent asking the user about this driver when configuring a > kernel without ACPI support. > > Fixes: 662f24826f954d49 ("platform/mellanox: Add support for new SN2201 system") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Thank you for your patch, I've applied this patch to my fixes branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes Note it will show up in my fixes branch once I've pushed my local branch there, which might take a while. I will include this patch in my next fixes pull-req to Linus for the current kernel development cycle. Note I'm only picking up PATCH 1/2. I expect 2/2 to be merged through the i2c tree. Regards, Hans > --- > drivers/platform/mellanox/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/mellanox/Kconfig b/drivers/platform/mellanox/Kconfig > index 382793e73a60a8b3..30b50920b278c94b 100644 > --- a/drivers/platform/mellanox/Kconfig > +++ b/drivers/platform/mellanox/Kconfig > @@ -80,8 +80,8 @@ config MLXBF_PMC > > config NVSW_SN2201 > tristate "Nvidia SN2201 platform driver support" > - depends on HWMON > - depends on I2C > + depends on HWMON && I2C > + depends on ACPI || COMPILE_TEST > select REGMAP_I2C > help > This driver provides support for the Nvidia SN2201 platform.
diff --git a/drivers/platform/mellanox/Kconfig b/drivers/platform/mellanox/Kconfig index 382793e73a60a8b3..30b50920b278c94b 100644 --- a/drivers/platform/mellanox/Kconfig +++ b/drivers/platform/mellanox/Kconfig @@ -80,8 +80,8 @@ config MLXBF_PMC config NVSW_SN2201 tristate "Nvidia SN2201 platform driver support" - depends on HWMON - depends on I2C + depends on HWMON && I2C + depends on ACPI || COMPILE_TEST select REGMAP_I2C help This driver provides support for the Nvidia SN2201 platform.
The only probing method supported by the Nvidia SN2201 platform driver is probing through an ACPI match table. Hence add a dependency on ACPI, to prevent asking the user about this driver when configuring a kernel without ACPI support. Fixes: 662f24826f954d49 ("platform/mellanox: Add support for new SN2201 system") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/platform/mellanox/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)