| Message ID | 20230816110906.144540-2-ana-maria.cusco@analog.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] iio: amplifiers: hmc425a: Add Support HMC540S 4-bit Attenuator | expand |
On Wed, Aug 16, 2023 at 02:09:06PM +0300, Ana-Maria Cusco wrote: > Added support for HMC540SLP3E broadband 4-bit Silicon IC digital > attenuator with a 15 dB control range and wide frequency coverage > (0.1 to 8 GHz). > > Signed-off-by: Ana-Maria Cusco <ana-maria.cusco@analog.com> Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > --- > .../bindings/iio/amplifiers/adi,hmc425a.yaml | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml b/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml > index 9fda56fa49c3..2ee6080deac7 100644 > --- a/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml > +++ b/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml > @@ -4,20 +4,26 @@ > $id: http://devicetree.org/schemas/iio/amplifiers/adi,hmc425a.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: HMC425A 6-bit Digital Step Attenuator > +title: Analog Devices HMC425A and similar Digital Step Attenuators > > maintainers: > - Michael Hennerich <michael.hennerich@analog.com> > > description: | > - Digital Step Attenuator IIO device with gpio interface. > + Digital Step Attenuator IIO devices with gpio interface. > + Offer various frequency and attenuation ranges. > HMC425A 0.5 dB LSB GaAs MMIC 6-BIT DIGITAL POSITIVE CONTROL ATTENUATOR, 2.2 - 8.0 GHz > - https://www.analog.com/media/en/technical-documentation/data-sheets/hmc425A.pdf > + https://www.analog.com/media/en/technical-documentation/data-sheets/hmc425A.pdf > + > + HMC540S 1 dB LSB Silicon MMIC 4-Bit Digital Positive Control Attenuator, 0.1 - 8 GHz > + https://www.analog.com/media/en/technical-documentation/data-sheets/hmc540s.pdf > + > > properties: > compatible: > enum: > - adi,hmc425a > + - adi,hmc540s > > vcc-supply: true > > -- > 2.34.1 >
> -----Original Message----- > From: Conor Dooley <conor@kernel.org> > Sent: Mittwoch, 16. August 2023 16:37 > To: Cusco, Ana-Maria <Ana-Maria.Cusco@analog.com> > Cc: Lars-Peter Clausen <lars@metafoo.de>; Hennerich, Michael > <Michael.Hennerich@analog.com>; Jonathan Cameron <jic23@kernel.org>; > Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley > <conor+dt@kernel.org>; linux-iio@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 2/2] dt-bindings: iio: hmc425a: add entry for HMC540S > > [External] > > On Wed, Aug 16, 2023 at 02:09:06PM +0300, Ana-Maria Cusco wrote: > > Added support for HMC540SLP3E broadband 4-bit Silicon IC digital > > attenuator with a 15 dB control range and wide frequency coverage > > (0.1 to 8 GHz). > > > > Signed-off-by: Ana-Maria Cusco <ana-maria.cusco@analog.com> > > Acked-by: Conor Dooley <conor.dooley@microchip.com> Adding missing Signed-off-by tag Signed-off-by: Michael Hennerich <michael.hennerich@analog.com> > > Thanks, > Conor. > > > --- > > .../bindings/iio/amplifiers/adi,hmc425a.yaml | 12 +++++++++--- > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > > diff --git > > a/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml > > b/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml > > index 9fda56fa49c3..2ee6080deac7 100644 > > --- > > a/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml > > +++ > b/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yam > > +++ l > > @@ -4,20 +4,26 @@ > > $id: http://devicetree.org/schemas/iio/amplifiers/adi,hmc425a.yaml# > > $schema: http://devicetree.org/meta-schemas/core.yaml# > > > > -title: HMC425A 6-bit Digital Step Attenuator > > +title: Analog Devices HMC425A and similar Digital Step Attenuators > > > > maintainers: > > - Michael Hennerich <michael.hennerich@analog.com> > > > > description: | > > - Digital Step Attenuator IIO device with gpio interface. > > + Digital Step Attenuator IIO devices with gpio interface. > > + Offer various frequency and attenuation ranges. > > HMC425A 0.5 dB LSB GaAs MMIC 6-BIT DIGITAL POSITIVE CONTROL > > ATTENUATOR, 2.2 - 8.0 GHz > > - > > https://www.analog.com/media/en/technical-documentation/data- > sheets/hm > > c425A.pdf > > + > > + https://www.analog.com/media/en/technical-documentation/data- > sheets/ > > + hmc425A.pdf > > + > > + HMC540S 1 dB LSB Silicon MMIC 4-Bit Digital Positive Control > Attenuator, 0.1 - 8 GHz > > + > > + https://www.analog.com/media/en/technical-documentation/data- > sheets/ > > + hmc540s.pdf > > + > > > > properties: > > compatible: > > enum: > > - adi,hmc425a > > + - adi,hmc540s > > > > vcc-supply: true > > > > -- > > 2.34.1 > >
On 12/09/2023 08:36, Hennerich, Michael wrote: > > >> -----Original Message----- >> From: Conor Dooley <conor@kernel.org> >> Sent: Mittwoch, 16. August 2023 16:37 >> To: Cusco, Ana-Maria <Ana-Maria.Cusco@analog.com> >> Cc: Lars-Peter Clausen <lars@metafoo.de>; Hennerich, Michael >> <Michael.Hennerich@analog.com>; Jonathan Cameron <jic23@kernel.org>; >> Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski >> <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley >> <conor+dt@kernel.org>; linux-iio@vger.kernel.org; >> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH 2/2] dt-bindings: iio: hmc425a: add entry for HMC540S >> >> [External] >> >> On Wed, Aug 16, 2023 at 02:09:06PM +0300, Ana-Maria Cusco wrote: >>> Added support for HMC540SLP3E broadband 4-bit Silicon IC digital >>> attenuator with a 15 dB control range and wide frequency coverage >>> (0.1 to 8 GHz). >>> >>> Signed-off-by: Ana-Maria Cusco <ana-maria.cusco@analog.com> >> >> Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Adding missing Signed-off-by tag > > Signed-off-by: Michael Hennerich <michael.hennerich@analog.com> Why it is missing? What is the purpose of this adding? Best regards, Krzysztof
On Tue, 12 Sep 2023 08:56:56 +0200 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 12/09/2023 08:36, Hennerich, Michael wrote: > > > > > >> -----Original Message----- > >> From: Conor Dooley <conor@kernel.org> > >> Sent: Mittwoch, 16. August 2023 16:37 > >> To: Cusco, Ana-Maria <Ana-Maria.Cusco@analog.com> > >> Cc: Lars-Peter Clausen <lars@metafoo.de>; Hennerich, Michael > >> <Michael.Hennerich@analog.com>; Jonathan Cameron <jic23@kernel.org>; > >> Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski > >> <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley > >> <conor+dt@kernel.org>; linux-iio@vger.kernel.org; > >> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org > >> Subject: Re: [PATCH 2/2] dt-bindings: iio: hmc425a: add entry for HMC540S > >> > >> [External] > >> > >> On Wed, Aug 16, 2023 at 02:09:06PM +0300, Ana-Maria Cusco wrote: > >>> Added support for HMC540SLP3E broadband 4-bit Silicon IC digital > >>> attenuator with a 15 dB control range and wide frequency coverage > >>> (0.1 to 8 GHz). > >>> > >>> Signed-off-by: Ana-Maria Cusco <ana-maria.cusco@analog.com> > >> > >> Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > > Adding missing Signed-off-by tag > > > > Signed-off-by: Michael Hennerich <michael.hennerich@analog.com> > > Why it is missing? What is the purpose of this adding? > > Best regards, > Krzysztof > > Wrong patch. This is supposed to be on patch 1 where Michael was the author (he confirmed intent in response to a linux-next missing sign-off mail). I've added it there, but if you can reply to that email Michael, it will make things nice and clear. Jonathan
> -----Original Message----- > From: Jonathan Cameron <Jonathan.Cameron@Huawei.com> > Sent: Dienstag, 12. September 2023 11:17 > To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Cc: Hennerich, Michael <Michael.Hennerich@analog.com>; Conor Dooley > <conor@kernel.org>; Cusco, Ana-Maria <Ana-Maria.Cusco@analog.com>; > Lars-Peter Clausen <lars@metafoo.de>; Jonathan Cameron > <jic23@kernel.org>; Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley > <conor+dt@kernel.org>; linux-iio@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 2/2] dt-bindings: iio: hmc425a: add entry for HMC540S > > [External] > > On Tue, 12 Sep 2023 08:56:56 +0200 > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > > On 12/09/2023 08:36, Hennerich, Michael wrote: > > > > > > > > >> -----Original Message----- > > >> From: Conor Dooley <conor@kernel.org> > > >> Sent: Mittwoch, 16. August 2023 16:37 > > >> To: Cusco, Ana-Maria <Ana-Maria.Cusco@analog.com> > > >> Cc: Lars-Peter Clausen <lars@metafoo.de>; Hennerich, Michael > > >> <Michael.Hennerich@analog.com>; Jonathan Cameron > > >> <jic23@kernel.org>; Rob Herring <robh+dt@kernel.org>; Krzysztof > > >> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley > > >> <conor+dt@kernel.org>; linux-iio@vger.kernel.org; > > >> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org > > >> Subject: Re: [PATCH 2/2] dt-bindings: iio: hmc425a: add entry for > > >> HMC540S > > >> > > >> [External] > > >> > > >> On Wed, Aug 16, 2023 at 02:09:06PM +0300, Ana-Maria Cusco wrote: > > >>> Added support for HMC540SLP3E broadband 4-bit Silicon IC digital > > >>> attenuator with a 15 dB control range and wide frequency coverage > > >>> (0.1 to 8 GHz). > > >>> > > >>> Signed-off-by: Ana-Maria Cusco <ana-maria.cusco@analog.com> > > >> > > >> Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > > > > Adding missing Signed-off-by tag > > > > > > Signed-off-by: Michael Hennerich <michael.hennerich@analog.com> > > > > Why it is missing? What is the purpose of this adding? > > > > Best regards, > > Krzysztof > > > > > > Wrong patch. This is supposed to be on patch 1 where Michael was the > author (he confirmed intent in response to a linux-next missing sign-off mail). > I've added it there, but if you can reply to that email Michael, it will make > things nice and clear. > > Jonathan Sorry - my fault. The Signed-off-by tag should have been for patch "iio: amplifiers: hmc425a: Add Support HMC540S 4-bit Attenuator" Regards, Michael
diff --git a/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml b/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml index 9fda56fa49c3..2ee6080deac7 100644 --- a/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml +++ b/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml @@ -4,20 +4,26 @@ $id: http://devicetree.org/schemas/iio/amplifiers/adi,hmc425a.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: HMC425A 6-bit Digital Step Attenuator +title: Analog Devices HMC425A and similar Digital Step Attenuators maintainers: - Michael Hennerich <michael.hennerich@analog.com> description: | - Digital Step Attenuator IIO device with gpio interface. + Digital Step Attenuator IIO devices with gpio interface. + Offer various frequency and attenuation ranges. HMC425A 0.5 dB LSB GaAs MMIC 6-BIT DIGITAL POSITIVE CONTROL ATTENUATOR, 2.2 - 8.0 GHz - https://www.analog.com/media/en/technical-documentation/data-sheets/hmc425A.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/hmc425A.pdf + + HMC540S 1 dB LSB Silicon MMIC 4-Bit Digital Positive Control Attenuator, 0.1 - 8 GHz + https://www.analog.com/media/en/technical-documentation/data-sheets/hmc540s.pdf + properties: compatible: enum: - adi,hmc425a + - adi,hmc540s vcc-supply: true
Added support for HMC540SLP3E broadband 4-bit Silicon IC digital attenuator with a 15 dB control range and wide frequency coverage (0.1 to 8 GHz). Signed-off-by: Ana-Maria Cusco <ana-maria.cusco@analog.com> --- .../bindings/iio/amplifiers/adi,hmc425a.yaml | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)