| Message ID | 20230912084039.1501984-1-Ilia.Gavrilov@infotecs.ru (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a613ed1afd9696ab6d235c0dab5f557863b94bc8 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] ipv4: igmp: Remove redundant comparison in igmp_mcf_get_next() | expand |
On 9/12/23 2:42 AM, Gavrilov Ilia wrote: > The 'state->im' value will always be non-zero after > the 'while' statement, so the check can be removed. > > Found by InfoTeCS on behalf of Linux Verification Center > (linuxtesting.org) with SVACE. > > Signed-off-by: Gavrilov Ilia <Ilia.Gavrilov@infotecs.ru> > --- > Repost according to https://lore.kernel.org/all/fea6db56-3a01-b7c8-b800-a6c885e99feb@kernel.org/ > net/ipv4/igmp.c | 2 -- > 1 file changed, 2 deletions(-) > Reviewed-by: David Ahern <dsahern@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by Paolo Abeni <pabeni@redhat.com>: On Tue, 12 Sep 2023 08:42:34 +0000 you wrote: > The 'state->im' value will always be non-zero after > the 'while' statement, so the check can be removed. > > Found by InfoTeCS on behalf of Linux Verification Center > (linuxtesting.org) with SVACE. > > Signed-off-by: Gavrilov Ilia <Ilia.Gavrilov@infotecs.ru> > > [...] Here is the summary with links: - [net-next] ipv4: igmp: Remove redundant comparison in igmp_mcf_get_next() https://git.kernel.org/netdev/net-next/c/a613ed1afd96 You are awesome, thank you!
diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c index 418e5fb58fd3..76c3ea75b8dd 100644 --- a/net/ipv4/igmp.c +++ b/net/ipv4/igmp.c @@ -2944,8 +2944,6 @@ static struct ip_sf_list *igmp_mcf_get_next(struct seq_file *seq, struct ip_sf_l continue; state->im = rcu_dereference(state->idev->mc_list); } - if (!state->im) - break; spin_lock_bh(&state->im->lock); psf = state->im->sources; }
The 'state->im' value will always be non-zero after the 'while' statement, so the check can be removed. Found by InfoTeCS on behalf of Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Gavrilov Ilia <Ilia.Gavrilov@infotecs.ru> --- Repost according to https://lore.kernel.org/all/fea6db56-3a01-b7c8-b800-a6c885e99feb@kernel.org/ net/ipv4/igmp.c | 2 -- 1 file changed, 2 deletions(-)