Message ID | 20230912185509.2430563-1-arnd@kernel.org (mailing list archive) |
---|---|
State | Accepted |
Commit | a8f367f7e131e76713b2949b168ac97f671fce7a |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | net: ti: icssg-prueth: add PTP dependency | expand |
On 13/09/23 00:24, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The driver can now use PTP if enabled but fails to link built-in > if PTP is a loadable module: > > aarch64-linux-ld: drivers/net/ethernet/ti/icssg/icss_iep.o: in function `icss_iep_get_ptp_clock_idx': > icss_iep.c:(.text+0x200): undefined reference to `ptp_clock_index' > > Add the usual dependency to avoid this. > > Fixes: 186734c158865 ("net: ti: icssg-prueth: add packet timestamping and ptp support") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: MD Danish Anwar <danishanwar@ti.com> > --- > drivers/net/ethernet/ti/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig > index 7f3e2e96c6e20..26ddc26fc7b8d 100644 > --- a/drivers/net/ethernet/ti/Kconfig > +++ b/drivers/net/ethernet/ti/Kconfig > @@ -201,6 +201,7 @@ config TI_ICSSG_PRUETH > > config TI_ICSS_IEP > tristate "TI PRU ICSS IEP driver" > + depends on PTP_1588_CLOCK_OPTIONAL > depends on TI_PRUSS > default TI_PRUSS > help
Tue, Sep 12, 2023 at 08:54:51PM CEST, arnd@kernel.org wrote: >From: Arnd Bergmann <arnd@arndb.de> > >The driver can now use PTP if enabled but fails to link built-in >if PTP is a loadable module: > >aarch64-linux-ld: drivers/net/ethernet/ti/icssg/icss_iep.o: in function `icss_iep_get_ptp_clock_idx': >icss_iep.c:(.text+0x200): undefined reference to `ptp_clock_index' > >Add the usual dependency to avoid this. > >Fixes: 186734c158865 ("net: ti: icssg-prueth: add packet timestamping and ptp support") >Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Tue, 12 Sep 2023 20:54:51 +0200 you wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The driver can now use PTP if enabled but fails to link built-in > if PTP is a loadable module: > > aarch64-linux-ld: drivers/net/ethernet/ti/icssg/icss_iep.o: in function `icss_iep_get_ptp_clock_idx': > icss_iep.c:(.text+0x200): undefined reference to `ptp_clock_index' > > [...] Here is the summary with links: - net: ti: icssg-prueth: add PTP dependency https://git.kernel.org/netdev/net/c/a8f367f7e131 You are awesome, thank you!
diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig index 7f3e2e96c6e20..26ddc26fc7b8d 100644 --- a/drivers/net/ethernet/ti/Kconfig +++ b/drivers/net/ethernet/ti/Kconfig @@ -201,6 +201,7 @@ config TI_ICSSG_PRUETH config TI_ICSS_IEP tristate "TI PRU ICSS IEP driver" + depends on PTP_1588_CLOCK_OPTIONAL depends on TI_PRUSS default TI_PRUSS help