| Message ID | 20230913111644.29889-2-hnagalla@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | TI K3 M4F support on AM64x and AM62x SoCs | expand |
On 13/09/2023 13:16, Hari Nagalla wrote: > K3 AM64x SoC has a Cortex M4F subsystem in the MCU voltage domain. > The remote processor's life cycle management and IPC mechanisms are > similar across the R5F and M4F cores from remote processor driver > point of view. However, there are subtle differences in image loading > and starting the M4F subsystems. > > The YAML binding document provides the various node properties to be > configured by the consumers of the M4F subsystem. > > Signed-off-by: Martyn Welch <martyn.welch@collabora.com> > Signed-off-by: Hari Nagalla <hnagalla@ti.com> > --- > Changes since v1: > - Spelling corrections > - Corrected to pass DT checks > > Changes since v2: > - Missed spelling correction to commit message > > Changes since v3: > - Removed unnecessary descriptions and used generic memory region names > - Made mboxes and memory-region optional > - Removed unrelated items from examples > > Changes since v4: > - Rebased to the latest kernel-next tree > - Added optional sram memory region for m4f device node > > Changes since v5: > - None Hm, why none? There were errors in the binding to which you did not respond. Did you just ignore them? > > .../bindings/remoteproc/ti,k3-m4f-rproc.yaml | 136 ++++++++++++++++++ > 1 file changed, 136 insertions(+) > create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml > > diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml > new file mode 100644 > index 000000000000..21b7f14d9dc4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml > @@ -0,0 +1,136 @@ > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/remoteproc/ti,k3-m4f-rproc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: TI K3 M4F processor subsystems > + > +maintainers: > + - Hari Nagalla <hnagalla@ti.com> > + - Mathieu Poirier <mathieu.poirier@linaro.org> Are you sure Mathieu has this device and is a maintainer of this device? > + > +description: | > + Some K3 family SoCs have Arm Cortex M4F cores. AM64x is a SoC in K3 > + family with a M4F core. Typically safety oriented applications may use > + the M4F core in isolation without an IPC. Where as some industrial and > + home automation applications, may use the M4F core as a remote processor > + with IPC communications. > + > +$ref: /schemas/arm/keystone/ti,k3-sci-common.yaml# > + > +properties: > + Drop blank line. > + compatible: > + enum: > + - ti,am64-m4fss > + > + power-domains: > + maxItems: 1 > + > + "#address-cells": > + const: 2 > + > + "#size-cells": > + const: 2 > + > + reg: > + items: > + - description: IRAM internal memory region > + - description: DRAM internal memory region > + > + reg-names: > + items: > + - const: iram > + - const: dram > + > + resets: > + maxItems: 1 > + > + firmware-name: > + $ref: /schemas/types.yaml#/definitions/string Wrong type. This is an array. You need maxItems instead. > + description: Name of firmware to load for the M4F core > + > + mboxes: > + description: | > + Mailbox specifier denoting the sub-mailbox, to be used for communication > + with the remote processor. This property should match with the > + sub-mailbox node used in the firmware image. > + maxItems: 2 You need to describe the items instead. > + > + memory-region: > + description: | > + phandle to the reserved memory nodes to be associated with the > + remoteproc device. The reserved memory nodes should be carveout nodes, > + and should be defined with a "no-map" property as per the bindings in > + Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml > + Optional memory regions available for firmware specific purposes. > + maxItems: 8 > + items: > + - description: regions used for DMA allocations like vrings, vring buffers > + and memory dedicated to firmware's specific purposes. > + additionalItems: true Best regards, Krzysztof
On Wed, 13 Sep 2023 06:16:41 -0500, Hari Nagalla wrote: > K3 AM64x SoC has a Cortex M4F subsystem in the MCU voltage domain. > The remote processor's life cycle management and IPC mechanisms are > similar across the R5F and M4F cores from remote processor driver > point of view. However, there are subtle differences in image loading > and starting the M4F subsystems. > > The YAML binding document provides the various node properties to be > configured by the consumers of the M4F subsystem. > > Signed-off-by: Martyn Welch <martyn.welch@collabora.com> > Signed-off-by: Hari Nagalla <hnagalla@ti.com> > --- > Changes since v1: > - Spelling corrections > - Corrected to pass DT checks > > Changes since v2: > - Missed spelling correction to commit message > > Changes since v3: > - Removed unnecessary descriptions and used generic memory region names > - Made mboxes and memory-region optional > - Removed unrelated items from examples > > Changes since v4: > - Rebased to the latest kernel-next tree > - Added optional sram memory region for m4f device node > > Changes since v5: > - None > > .../bindings/remoteproc/ti,k3-m4f-rproc.yaml | 136 ++++++++++++++++++ > 1 file changed, 136 insertions(+) > create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/stericsson,dma40.example.dtb: dma-controller@801c0000: sram:0: [4294967295, 4294967295] is too long from schema $id: http://devicetree.org/schemas/dma/stericsson,dma40.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230913111644.29889-2-hnagalla@ti.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 9/13/23 06:32, Krzysztof Kozlowski wrote: >> - Removed unrelated items from examples >> >> Changes since v4: >> - Rebased to the latest kernel-next tree >> - Added optional sram memory region for m4f device node >> >> Changes since v5: >> - None > Hm, why none? There were errors in the binding to which you did not > respond. Did you just ignore them? > I do not see any errors in my builds. Am i missing something? Please excuse my lack of knowledge here. Thought the bot errors were outside of the patch submitted (Documentation/devicetree/bindings/dma/stericsson,dma40.yaml). Appreciate your kind inputs.. $ make -j`nproc` ARCH=arm64 V=1 CROSS_COMPILE=aarch64-none-linux-gnu- DT_CHEKCER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml make --no-print-directory -C /home/a0868345/temp/linux-next \ -f /home/a0868345/temp/linux-next/Makefile dt_binding_check make -f ./scripts/Makefile.build obj=scripts/basic make -f ./scripts/Makefile.build obj=scripts/dtc make -f ./scripts/Makefile.build obj=Documentation/devicetree/bindings # LINT Documentation/devicetree/bindings (find ./Documentation/devicetree/bindings \( -name '*.yaml' ! -name 'processed-schema*' \) | grep -F -e "Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml" | xargs -n200 -P$(nproc) /home/a0868345/.local/bin/yamllint -f parsable -c ./Documentation/devicetree/bindings/.yamllint >&2) || true # DTEX Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.example.dts dt-extract-example Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml > Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.example.dts # CHKDT Documentation/devicetree/bindings/processed-schema.json (find ./Documentation/devicetree/bindings \( -name '*.yaml' ! -name 'processed-schema*' \) | grep -F -e "Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml" | xargs -n200 -P$(nproc) dt-doc-validate -u ./Documentation/devicetree/bindings) || true # SCHEMA Documentation/devicetree/bindings/processed-schema.json f=$(mktemp) ; find ./Documentation/devicetree/bindings \( -name '*.yaml' ! -name 'processed-schema*' \) > $f ; dt-mk-schema -j @$f > Documentation/devicetree/bindings/processed-schema.json ; rm -f $f # DTC_CHK Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.example.dtb gcc -E -Wp,-MMD,Documentation/devicetree/bindings/remoteproc/.ti_k3-m4f-rproc.example.dtb.d.pre.tmp -nostdinc -I./scripts/dtc/include-prefixes -undef -D__DTS__ -x assembler-with-cpp -o Documentation/devicetree/bindings/remoteproc/.ti_k3-m4f-rproc.example.dtb.dts.tmp Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.example.dts ; ./scripts/dtc/dtc -o Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.example.dtb -b 0 -iDocumentation/devicetree/bindings/remoteproc/ -i./scripts/dtc/include-prefixes -Wno-avoid_unnecessary_addr_size -Wno-graph_child_address -Wno-interrupt_provider -Wno-unique_unit_address -Wunique_unit_address_if_enabled -d Documentation/devicetree/bindings/remoteproc/.ti_k3-m4f-rproc.example.dtb.d.dtc.tmp Documentation/devicetree/bindings/remoteproc/.ti_k3-m4f-rproc.example.dtb.dts.tmp ; cat Documentation/devicetree/bindings/remoteproc/.ti_k3-m4f-rproc.example.dtb.d.pre.tmp Documentation/devicetree/bindings/remoteproc/.ti_k3-m4f-rproc.example.dtb.d.dtc.tmp > Documentation/devicetree/bindings/remoteproc/.ti_k3-m4f-rproc.example.dtb.d ; dt-validate -u ./Documentation/devicetree/bindings -p ./Documentation/devicetree/bindings/processed-schema.json Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.example.dtb || true >> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id:http://devicetree.org/schemas/remoteproc/ti,k3-m4f-rproc.yaml# >> +$schema:http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: TI K3 M4F processor subsystems >> + >> +maintainers: >> + - Hari Nagalla<hnagalla@ti.com> >> + - Mathieu Poirier<mathieu.poirier@linaro.org> > Are you sure Mathieu has this device and is a maintainer of this device? > Earlier, Mathieu suggested he can be the maintainer. Beagle play is based on AM625 device. I will look into the other comments for the 'ti,k3-m4f-rproc.yaml' binding doc. Thanks
On 13/09/2023 15:59, Hari Nagalla wrote: > On 9/13/23 06:32, Krzysztof Kozlowski wrote: >>> - Removed unrelated items from examples >>> >>> Changes since v4: >>> - Rebased to the latest kernel-next tree >>> - Added optional sram memory region for m4f device node >>> >>> Changes since v5: >>> - None >> Hm, why none? There were errors in the binding to which you did not >> respond. Did you just ignore them? >> > I do not see any errors in my builds. Am i missing something? Please > excuse my lack of knowledge here. Thought the bot errors were outside of > the patch submitted > (Documentation/devicetree/bindings/dma/stericsson,dma40.yaml). > Appreciate your kind inputs.. I would expect then some confirmation that errors can be ignored. Instead report was left just unanswered. > > $ make -j`nproc` ARCH=arm64 V=1 CROSS_COMPILE=aarch64-none-linux-gnu- > DT_CHEKCER_FLAGS=-m dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml > make --no-print-directory -C /home/a0868345/temp/linux-next \ > -f /home/a0868345/temp/linux-next/Makefile dt_binding_check > make -f ./scripts/Makefile.build obj=scripts/basic > make -f ./scripts/Makefile.build obj=scripts/dtc > make -f ./scripts/Makefile.build obj=Documentation/devicetree/bindings > # LINT Documentation/devicetree/bindings > (find ./Documentation/devicetree/bindings \( -name '*.yaml' ! -name > 'processed-schema*' \) | grep -F -e > "Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml" | > xargs -n200 -P$(nproc) /home/a0868345/.local/bin/yamllint -f parsable -c > ./Documentation/devicetree/bindings/.yamllint >&2) || true > # DTEX > Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.example.dts > dt-extract-example > Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml > > Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.example.dts > # CHKDT Documentation/devicetree/bindings/processed-schema.json > (find ./Documentation/devicetree/bindings \( -name '*.yaml' ! -name > 'processed-schema*' \) | grep -F -e > "Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml" | > xargs -n200 -P$(nproc) dt-doc-validate -u > ./Documentation/devicetree/bindings) || true > # SCHEMA Documentation/devicetree/bindings/processed-schema.json > f=$(mktemp) ; find ./Documentation/devicetree/bindings \( -name > '*.yaml' ! -name 'processed-schema*' \) > $f ; dt-mk-schema -j @$f > > Documentation/devicetree/bindings/processed-schema.json ; rm -f $f > # DTC_CHK > Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.example.dtb > gcc -E > -Wp,-MMD,Documentation/devicetree/bindings/remoteproc/.ti_k3-m4f-rproc.example.dtb.d.pre.tmp > -nostdinc -I./scripts/dtc/include-prefixes -undef -D__DTS__ -x > assembler-with-cpp -o > Documentation/devicetree/bindings/remoteproc/.ti_k3-m4f-rproc.example.dtb.dts.tmp > Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.example.dts > ; ./scripts/dtc/dtc -o > Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.example.dtb > -b 0 -iDocumentation/devicetree/bindings/remoteproc/ > -i./scripts/dtc/include-prefixes -Wno-avoid_unnecessary_addr_size > -Wno-graph_child_address -Wno-interrupt_provider > -Wno-unique_unit_address -Wunique_unit_address_if_enabled -d > Documentation/devicetree/bindings/remoteproc/.ti_k3-m4f-rproc.example.dtb.d.dtc.tmp > Documentation/devicetree/bindings/remoteproc/.ti_k3-m4f-rproc.example.dtb.dts.tmp > ; cat > Documentation/devicetree/bindings/remoteproc/.ti_k3-m4f-rproc.example.dtb.d.pre.tmp > Documentation/devicetree/bindings/remoteproc/.ti_k3-m4f-rproc.example.dtb.d.dtc.tmp > > > Documentation/devicetree/bindings/remoteproc/.ti_k3-m4f-rproc.example.dtb.d > ; dt-validate -u ./Documentation/devicetree/bindings -p > ./Documentation/devicetree/bindings/processed-schema.json > Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.example.dtb > || true > > > >> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > >> +%YAML 1.2 > >> +--- > >> +$id:http://devicetree.org/schemas/remoteproc/ti,k3-m4f-rproc.yaml# > >> +$schema:http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: TI K3 M4F processor subsystems > >> + > >> +maintainers: > >> + - Hari Nagalla<hnagalla@ti.com> > >> + - Mathieu Poirier<mathieu.poirier@linaro.org> > > Are you sure Mathieu has this device and is a maintainer of this device? > > > Earlier, Mathieu suggested he can be the maintainer. Beagle play is > based on AM625 device. > Sure, no problem, good for me. Best regards, Krzysztof
On 13/09/2023 14:36, Rob Herring wrote: > > On Wed, 13 Sep 2023 06:16:41 -0500, Hari Nagalla wrote: >> K3 AM64x SoC has a Cortex M4F subsystem in the MCU voltage domain. >> The remote processor's life cycle management and IPC mechanisms are >> similar across the R5F and M4F cores from remote processor driver >> point of view. However, there are subtle differences in image loading >> and starting the M4F subsystems. >> >> The YAML binding document provides the various node properties to be >> configured by the consumers of the M4F subsystem. >> >> Signed-off-by: Martyn Welch <martyn.welch@collabora.com> >> Signed-off-by: Hari Nagalla <hnagalla@ti.com> >> --- >> Changes since v1: >> - Spelling corrections >> - Corrected to pass DT checks >> >> Changes since v2: >> - Missed spelling correction to commit message >> >> Changes since v3: >> - Removed unnecessary descriptions and used generic memory region names >> - Made mboxes and memory-region optional >> - Removed unrelated items from examples >> >> Changes since v4: >> - Rebased to the latest kernel-next tree >> - Added optional sram memory region for m4f device node >> >> Changes since v5: >> - None >> >> .../bindings/remoteproc/ti,k3-m4f-rproc.yaml | 136 ++++++++++++++++++ >> 1 file changed, 136 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/stericsson,dma40.example.dtb: dma-controller@801c0000: sram:0: [4294967295, 4294967295] is too long > from schema $id: http://devicetree.org/schemas/dma/stericsson,dma40.yaml# This looks unrelated but it is caused by this patch. Probably by conflicting type for 'sram'. It seems we need to make exception for 'sram' in dtschema. Best regards, Krzysztof
On Wed, Sep 13, 2023 at 6:17 AM Hari Nagalla <hnagalla@ti.com> wrote: > > K3 AM64x SoC has a Cortex M4F subsystem in the MCU voltage domain. > The remote processor's life cycle management and IPC mechanisms are > similar across the R5F and M4F cores from remote processor driver > point of view. However, there are subtle differences in image loading > and starting the M4F subsystems. > > The YAML binding document provides the various node properties to be > configured by the consumers of the M4F subsystem. > > Signed-off-by: Martyn Welch <martyn.welch@collabora.com> > Signed-off-by: Hari Nagalla <hnagalla@ti.com> > --- > Changes since v1: > - Spelling corrections > - Corrected to pass DT checks > > Changes since v2: > - Missed spelling correction to commit message > > Changes since v3: > - Removed unnecessary descriptions and used generic memory region names > - Made mboxes and memory-region optional > - Removed unrelated items from examples > > Changes since v4: > - Rebased to the latest kernel-next tree > - Added optional sram memory region for m4f device node > > Changes since v5: > - None > > .../bindings/remoteproc/ti,k3-m4f-rproc.yaml | 136 ++++++++++++++++++ > 1 file changed, 136 insertions(+) > create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml > > diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml > new file mode 100644 > index 000000000000..21b7f14d9dc4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml > @@ -0,0 +1,136 @@ > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/remoteproc/ti,k3-m4f-rproc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: TI K3 M4F processor subsystems > + > +maintainers: > + - Hari Nagalla <hnagalla@ti.com> > + - Mathieu Poirier <mathieu.poirier@linaro.org> > + > +description: | > + Some K3 family SoCs have Arm Cortex M4F cores. AM64x is a SoC in K3 > + family with a M4F core. Typically safety oriented applications may use > + the M4F core in isolation without an IPC. Where as some industrial and > + home automation applications, may use the M4F core as a remote processor > + with IPC communications. > + > +$ref: /schemas/arm/keystone/ti,k3-sci-common.yaml# > + > +properties: > + > + compatible: > + enum: > + - ti,am64-m4fss > + > + power-domains: > + maxItems: 1 > + > + "#address-cells": > + const: 2 > + > + "#size-cells": > + const: 2 > + > + reg: > + items: > + - description: IRAM internal memory region > + - description: DRAM internal memory region > + > + reg-names: > + items: > + - const: iram > + - const: dram > + > + resets: > + maxItems: 1 > + > + firmware-name: > + $ref: /schemas/types.yaml#/definitions/string > + description: Name of firmware to load for the M4F core > + > + mboxes: > + description: | > + Mailbox specifier denoting the sub-mailbox, to be used for communication > + with the remote processor. This property should match with the > + sub-mailbox node used in the firmware image. > + maxItems: 2 > + > + memory-region: > + description: | > + phandle to the reserved memory nodes to be associated with the > + remoteproc device. The reserved memory nodes should be carveout nodes, > + and should be defined with a "no-map" property as per the bindings in > + Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml > + Optional memory regions available for firmware specific purposes. > + maxItems: 8 > + items: > + - description: regions used for DMA allocations like vrings, vring buffers > + and memory dedicated to firmware's specific purposes. > + additionalItems: true > + > + sram: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + minItems: 1 > + maxItems: 4 > + items: > + maxItems: 4 You are saying there are 1-4 entries and each entry is 4 cells. What's in the 4 cells? From the description and example, looks like you only have 1 cell (a phandle) so maxItems should be 1. Your example should fail, but I'm not sure why it doesn't. Rob
diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml new file mode 100644 index 000000000000..21b7f14d9dc4 --- /dev/null +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml @@ -0,0 +1,136 @@ +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/remoteproc/ti,k3-m4f-rproc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TI K3 M4F processor subsystems + +maintainers: + - Hari Nagalla <hnagalla@ti.com> + - Mathieu Poirier <mathieu.poirier@linaro.org> + +description: | + Some K3 family SoCs have Arm Cortex M4F cores. AM64x is a SoC in K3 + family with a M4F core. Typically safety oriented applications may use + the M4F core in isolation without an IPC. Where as some industrial and + home automation applications, may use the M4F core as a remote processor + with IPC communications. + +$ref: /schemas/arm/keystone/ti,k3-sci-common.yaml# + +properties: + + compatible: + enum: + - ti,am64-m4fss + + power-domains: + maxItems: 1 + + "#address-cells": + const: 2 + + "#size-cells": + const: 2 + + reg: + items: + - description: IRAM internal memory region + - description: DRAM internal memory region + + reg-names: + items: + - const: iram + - const: dram + + resets: + maxItems: 1 + + firmware-name: + $ref: /schemas/types.yaml#/definitions/string + description: Name of firmware to load for the M4F core + + mboxes: + description: | + Mailbox specifier denoting the sub-mailbox, to be used for communication + with the remote processor. This property should match with the + sub-mailbox node used in the firmware image. + maxItems: 2 + + memory-region: + description: | + phandle to the reserved memory nodes to be associated with the + remoteproc device. The reserved memory nodes should be carveout nodes, + and should be defined with a "no-map" property as per the bindings in + Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml + Optional memory regions available for firmware specific purposes. + maxItems: 8 + items: + - description: regions used for DMA allocations like vrings, vring buffers + and memory dedicated to firmware's specific purposes. + additionalItems: true + + sram: + $ref: /schemas/types.yaml#/definitions/phandle-array + minItems: 1 + maxItems: 4 + items: + maxItems: 4 + description: | + phandles to one or more reserved on-chip SRAM regions. The regions + should be defined as child nodes of the respective SRAM node, and + should be defined as per the generic bindings in, + Documentation/devicetree/bindings/sram/sram.yaml + +required: + - compatible + - reg + - reg-names + - ti,sci + - ti,sci-dev-id + - ti,sci-proc-ids + - resets + - firmware-name + +unevaluatedProperties: false + +examples: + - | + reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + + mcu_m4fss_dma_memory_region: m4f-dma-memory@9cb00000 { + compatible = "shared-dma-pool"; + reg = <0x00 0x9cb00000 0x00 0x100000>; + no-map; + }; + + mcu_m4fss_memory_region: m4f-memory@9cc00000 { + compatible = "shared-dma-pool"; + reg = <0x00 0x9cc00000 0x00 0xe00000>; + no-map; + }; + }; + + soc { + #address-cells = <2>; + #size-cells = <2>; + + remoteproc@5000000 { + compatible = "ti,am64-m4fss"; + reg = <0x00 0x5000000 0x00 0x30000>, + <0x00 0x5040000 0x00 0x10000>; + reg-names = "iram", "dram"; + ti,sci = <&dmsc>; + ti,sci-dev-id = <9>; + ti,sci-proc-ids = <0x18 0xff>; + resets = <&k3_reset 9 1>; + firmware-name = "am62-mcu-m4f0_0-fw"; + mboxes = <&mailbox0_cluster0>, <&mbox_m4_0>; + memory-region = <&mcu_m4fss_dma_memory_region>, + <&mcu_m4fss_memory_region>; + sram = <&oc_sram>; + }; + };