| Message ID | 20230721110345.3925719-1-m.felsch@pengutronix.de (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,v4,1/3] dt-bindings: net: snps,dwmac: add phy-supply support | expand |
| Context | Check | Description |
|---|---|---|
| netdev/series_format | warning | Series does not have a cover letter |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 9 this patch: 9 |
| netdev/cc_maintainers | success | CCed 12 of 12 maintainers |
| netdev/build_clang | success | Errors and warnings before: 9 this patch: 9 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/deprecated_api | success | None detected |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 9 this patch: 9 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 9 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On Fri, Jul 21, 2023 at 01:03:43PM +0200, Marco Felsch wrote: > Document the common phy-supply property to be able to specify a phy > regulator. What common property? I don't see any such property in ethernet-controller.yaml. > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Changelog: > v4: > - no changes > v3: > - no changes > v2 > - add ack-by > > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index ddf9522a5dc23..847ecb82b37ee 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -160,6 +160,9 @@ properties: > can be passive (no SW requirement), and requires that the MAC operate > in a different mode than the PHY in order to function. > > + phy-supply: > + description: PHY regulator Is this for an serdes, sgmii, etc. type phy or ethernet phy? Either way, this property belongs in the PHY's node because it is the PHY that has supply connection. I'm guessing you put this here for the latter case because ethernet PHYs on MDIO are "discoverable" except for the small problem that powering them on is not discoverable. Rob
Hi Rob, On 23-07-21, Rob Herring wrote: > On Fri, Jul 21, 2023 at 01:03:43PM +0200, Marco Felsch wrote: > > Document the common phy-supply property to be able to specify a phy > > regulator. > > What common property? I don't see any such property in > ethernet-controller.yaml. Not in ethernet-controller.yaml but there are at least a few user of this binding: - allwinner,sun4i-a10-mdio.yaml - allwinner,sun7i-a20-gmac.yaml - allwinner,sun8i-a83t-emac.yaml - fsl,fec.yaml - rockchip-dwmac.yaml - rockchip,emac.yaml Also there is no <vendor>,phy-supply nor <ip-vendor>,phy-supply, therefore I thought this is common. > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Changelog: > > v4: > > - no changes > > v3: > > - no changes > > v2 > > - add ack-by > > > > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > index ddf9522a5dc23..847ecb82b37ee 100644 > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > @@ -160,6 +160,9 @@ properties: > > can be passive (no SW requirement), and requires that the MAC operate > > in a different mode than the PHY in order to function. > > > > + phy-supply: > > + description: PHY regulator > > Is this for an serdes, sgmii, etc. type phy or ethernet phy? Either way, > this property belongs in the PHY's node because it is the PHY that has > supply connection. I'm guessing you put this here for the latter case > because ethernet PHYs on MDIO are "discoverable" except for the small > problem that powering them on is not discoverable. All kind of ethernet phys connected to you etherent MAC which need to be power controlled by software. You're right this sould belong to the PHY node (as Krzysztof already mentioned) but this isn't the case yet. As you can see there are at least 6 user of the exact same binding. Regards, Marco
Hi Rob, On 23-07-24, Marco Felsch wrote: > Hi Rob, > > On 23-07-21, Rob Herring wrote: > > On Fri, Jul 21, 2023 at 01:03:43PM +0200, Marco Felsch wrote: > > > Document the common phy-supply property to be able to specify a phy > > > regulator. > > > > What common property? I don't see any such property in > > ethernet-controller.yaml. > > Not in ethernet-controller.yaml but there are at least a few user of > this binding: > - allwinner,sun4i-a10-mdio.yaml > - allwinner,sun7i-a20-gmac.yaml > - allwinner,sun8i-a83t-emac.yaml > - fsl,fec.yaml > - rockchip-dwmac.yaml > - rockchip,emac.yaml > > Also there is no <vendor>,phy-supply nor <ip-vendor>,phy-supply, > therefore I thought this is common. any further comments else I would like to gentle ping this series. Regards, Marco > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > --- > > > Changelog: > > > v4: > > > - no changes > > > v3: > > > - no changes > > > v2 > > > - add ack-by > > > > > > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > index ddf9522a5dc23..847ecb82b37ee 100644 > > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > @@ -160,6 +160,9 @@ properties: > > > can be passive (no SW requirement), and requires that the MAC operate > > > in a different mode than the PHY in order to function. > > > > > > + phy-supply: > > > + description: PHY regulator > > > > Is this for an serdes, sgmii, etc. type phy or ethernet phy? Either way, > > this property belongs in the PHY's node because it is the PHY that has > > supply connection. I'm guessing you put this here for the latter case > > because ethernet PHYs on MDIO are "discoverable" except for the small > > problem that powering them on is not discoverable. > > All kind of ethernet phys connected to you etherent MAC which need to be > power controlled by software. You're right this sould belong to the PHY > node (as Krzysztof already mentioned) but this isn't the case yet. As > you can see there are at least 6 user of the exact same binding. > > Regards, > Marco > >
Hi, gentle ping on this series. On 23-07-21, Marco Felsch wrote: > Document the common phy-supply property to be able to specify a phy > regulator. > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Changelog: > v4: > - no changes > v3: > - no changes > v2 > - add ack-by > > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index ddf9522a5dc23..847ecb82b37ee 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -160,6 +160,9 @@ properties: > can be passive (no SW requirement), and requires that the MAC operate > in a different mode than the PHY in order to function. > > + phy-supply: > + description: PHY regulator > + > snps,axi-config: > $ref: /schemas/types.yaml#/definitions/phandle > description: > -- > 2.39.2 > > >
Hi, On 23-08-29, Marco Felsch wrote: > > Hi, > > gentle ping on this series. ping++ > On 23-07-21, Marco Felsch wrote: > > Document the common phy-supply property to be able to specify a phy > > regulator. > > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Changelog: > > v4: > > - no changes > > v3: > > - no changes > > v2 > > - add ack-by > > > > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > index ddf9522a5dc23..847ecb82b37ee 100644 > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > @@ -160,6 +160,9 @@ properties: > > can be passive (no SW requirement), and requires that the MAC operate > > in a different mode than the PHY in order to function. > > > > + phy-supply: > > + description: PHY regulator > > + > > snps,axi-config: > > $ref: /schemas/types.yaml#/definitions/phandle > > description: > > -- > > 2.39.2 > > > > > > > >
Hi Rob, On Fri, Jul 21, 2023 at 08:24:33AM -0600, Rob Herring wrote: > On Fri, Jul 21, 2023 at 01:03:43PM +0200, Marco Felsch wrote: > > Document the common phy-supply property to be able to specify a phy > > regulator. > > What common property? I don't see any such property in > ethernet-controller.yaml. > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Changelog: > > v4: > > - no changes > > v3: > > - no changes > > v2 > > - add ack-by > > > > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > index ddf9522a5dc23..847ecb82b37ee 100644 > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > @@ -160,6 +160,9 @@ properties: > > can be passive (no SW requirement), and requires that the MAC operate > > in a different mode than the PHY in order to function. > > > > + phy-supply: > > + description: PHY regulator > > Is this for an serdes, sgmii, etc. type phy or ethernet phy? Either way, > this property belongs in the PHY's node because it is the PHY that has > supply connection. I'm guessing you put this here for the latter case > because ethernet PHYs on MDIO are "discoverable" except for the small > problem that powering them on is not discoverable. Any idea on how to solve that problem generically ?
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index ddf9522a5dc23..847ecb82b37ee 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -160,6 +160,9 @@ properties: can be passive (no SW requirement), and requires that the MAC operate in a different mode than the PHY in order to function. + phy-supply: + description: PHY regulator + snps,axi-config: $ref: /schemas/types.yaml#/definitions/phandle description: