[bpf-next,v2,0/3] Fixes for Exceptions

Message

Kumar Kartikeya Dwivedi Sept. 18, 2023, 3:52 p.m. UTC

Set of fixes for bugs reported for the exceptions series.

Changelog:
----------
v1 -> v2
v1: https://lore.kernel.org/bpf/[e-mail]

 * Resend with trimmed Cc due to patchwork problem (Alexei)

Kumar Kartikeya Dwivedi (3):
  selftests/bpf: Print log buffer for exceptions test only on failure
  bpf: Fix bpf_throw warning on 32-bit arch
  bpf: Disable exceptions when CONFIG_UNWINDER_FRAME_POINTER=y

 arch/x86/net/bpf_jit_comp.c                         | 9 ++++-----
 kernel/bpf/helpers.c                                | 2 +-
 tools/testing/selftests/bpf/prog_tests/exceptions.c | 5 +++--
 3 files changed, 8 insertions(+), 8 deletions(-)


base-commit: ec6f1b4db95b7eedb3fe85f4f14e08fa0e9281c3

Comments

Eric Dumazet Sept. 18, 2023, 4 p.m. UTC | #1

On Mon, Sep 18, 2023 at 5:52 PM Kumar Kartikeya Dwivedi
<[e-mail]> wrote:
>
> The build with CONFIG_UNWINDER_FRAME_POINTER=y is broken for
> current exceptions feature as it assumes ORC unwinder specific fields in
> the unwind_state. Disable exceptions when frame_pointer unwinder is
> enabled for now.
>
> Fixes: fd5d27b70188 ("arch/x86: Implement arch_bpf_stack_walk")
> Reported-by: Eric Dumazet <[e-mail]>
> Signed-off-by: Kumar Kartikeya Dwivedi <[e-mail]>
> ---

SGTM, feel free adding

Reviewed-by: Eric Dumazet <[e-mail]>

[e-mail] Sept. 18, 2023, 8:50 p.m. UTC | #2

Hello:

This series was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <[e-mail]>:

On Mon, 18 Sep 2023 17:52:30 +0200 you wrote:
> Set of fixes for bugs reported for the exceptions series.
> 
> Changelog:
> ----------
> v1 -> v2
> v1: https://lore.kernel.org/bpf/[e-mail]
> 
> [...]

Here is the summary with links:
  - [bpf-next,v2,1/3] selftests/bpf: Print log buffer for exceptions test only on failure
    https://git.kernel.org/bpf/bpf-next/c/c425a3501f24
  - [bpf-next,v2,2/3] bpf: Fix bpf_throw warning on 32-bit arch
    https://git.kernel.org/bpf/bpf-next/c/00b7e8f4c02d
  - [bpf-next,v2,3/3] bpf: Disable exceptions when CONFIG_UNWINDER_FRAME_POINTER=y
    https://git.kernel.org/bpf/bpf-next/c/43c6e890472e

You are awesome, thank you!