diff mbox series

[v2,2/3] hw/mem/cxl_type3: Add missing copyright and license notice

Message ID 20230919101927.1470-3-Jonathan.Cameron@huawei.com (mailing list archive)
State New, archived
Headers show
Series hw/cxl: Misc small fixes | expand

Commit Message

Jonathan Cameron Sept. 19, 2023, 10:19 a.m. UTC
This has been missing from the start. Assume it should match
with cxl/cxl-component-utils.c as both were part of early
postings from Ben.

Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Acked-by: Dave Jiang <dave.jiang@intel.com>
Acked-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Fan Ni <fan.ni@samsung.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

---
v2:
- Add similar to cxl_type3_stubs.c
- Add SPDX tags whilst here.
- Gathered tags.
---
 hw/mem/cxl_type3.c       | 11 +++++++++++
 hw/mem/cxl_type3_stubs.c | 10 ++++++++++
 2 files changed, 21 insertions(+)

Comments

Philippe Mathieu-Daudé Sept. 20, 2023, 2:11 p.m. UTC | #1
Hi Jonathan,

On 19/9/23 12:19, Jonathan Cameron wrote:
> This has been missing from the start. Assume it should match
> with cxl/cxl-component-utils.c as both were part of early
> postings from Ben.
> 
> Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>

I haven't suggested this license, I only reported these
files are missing one (so eventually, Reported-by).

> Acked-by: Dave Jiang <dave.jiang@intel.com>
> Acked-by: Ira Weiny <ira.weiny@intel.com>
> Reviewed-by: Fan Ni <fan.ni@samsung.com>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> ---
> v2:
> - Add similar to cxl_type3_stubs.c
> - Add SPDX tags whilst here.
> - Gathered tags.
> ---
>   hw/mem/cxl_type3.c       | 11 +++++++++++
>   hw/mem/cxl_type3_stubs.c | 10 ++++++++++
>   2 files changed, 21 insertions(+)
> 
> diff --git a/hw/mem/cxl_type3.c b/hw/mem/cxl_type3.c
> index c5855d4e7d..8eb009c628 100644
> --- a/hw/mem/cxl_type3.c
> +++ b/hw/mem/cxl_type3.c
> @@ -1,3 +1,14 @@
> +/*
> + * CXL Type 3 (memory expander) device
> + *
> + * Copyright(C) 2020 Intel Corporation.
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2. See the
> + * COPYING file in the top-level directory.
> + *
> + * SPDX-License-Identifier: GPL-v2-only

Too bad this isn't GPL-v2-or-later.
Michael Tokarev Sept. 20, 2023, 2:25 p.m. UTC | #2
20.09.2023 17:11, Philippe Mathieu-Daudé:
> Hi Jonathan,
> 
> On 19/9/23 12:19, Jonathan Cameron wrote:
>> This has been missing from the start. Assume it should match
>> with cxl/cxl-component-utils.c as both were part of early
>> postings from Ben.
>>
>> Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> 
> I haven't suggested this license, I only reported these
> files are missing one (so eventually, Reported-by).

Fixed that one.

/mjt
diff mbox series

Patch

diff --git a/hw/mem/cxl_type3.c b/hw/mem/cxl_type3.c
index c5855d4e7d..8eb009c628 100644
--- a/hw/mem/cxl_type3.c
+++ b/hw/mem/cxl_type3.c
@@ -1,3 +1,14 @@ 
+/*
+ * CXL Type 3 (memory expander) device
+ *
+ * Copyright(C) 2020 Intel Corporation.
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2. See the
+ * COPYING file in the top-level directory.
+ *
+ * SPDX-License-Identifier: GPL-v2-only
+ */
+
 #include "qemu/osdep.h"
 #include "qemu/units.h"
 #include "qemu/error-report.h"
diff --git a/hw/mem/cxl_type3_stubs.c b/hw/mem/cxl_type3_stubs.c
index 56d60b4fd8..3e1851e32b 100644
--- a/hw/mem/cxl_type3_stubs.c
+++ b/hw/mem/cxl_type3_stubs.c
@@ -1,3 +1,13 @@ 
+/*
+ * CXL Type 3 (memory expander) device QMP stubs
+ *
+ * Copyright(C) 2020 Intel Corporation.
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2. See the
+ * COPYING file in the top-level directory.
+ *
+ * SPDX-License-Identifier: GPL-v2-only
+ */
 
 #include "qemu/osdep.h"
 #include "qapi/error.h"