[ipsec-next,0/2] xfrm: policy: replace session decode with flow dissector

Message

Florian Westphal Sept. 18, 2023, 12:59 p.m. UTC

Remove the ipv4+ipv6 session decode functions and use generic flow
dissector to populate the flowi for the policy lookup.

Changes since RFC:

 - Drop mobility header support.  I don't think that anyone uses
   this.  MOBIKE doesn't appear to need this either.
 - Drop fl6->flowlabel assignment, original code leaves it as 0.

There is no reason for this change other than to remove code.

Florian Westphal (2):
  xfrm: move mark and oif flowi decode into common code
  xfrm: policy: replace session decode with flow dissector

Florian Westphal (2):
  xfrm: move mark and oif flowi decode into common code
  xfrm: policy: replace session decode with flow dissector

 net/xfrm/xfrm_policy.c | 277 ++++++++++++++++-------------------------
 1 file changed, 107 insertions(+), 170 deletions(-)

Comments

Simon Horman Sept. 21, 2023, 12:22 p.m. UTC | #1

On Mon, Sep 18, 2023 at 02:59:07PM +0200, Florian Westphal wrote:
> Remove the ipv4+ipv6 session decode functions and use generic flow
> dissector to populate the flowi for the policy lookup.
> 
> Changes since RFC:
> 
>  - Drop mobility header support.  I don't think that anyone uses
>    this.  MOBIKE doesn't appear to need this either.
>  - Drop fl6->flowlabel assignment, original code leaves it as 0.
> 
> There is no reason for this change other than to remove code.
> 
> Florian Westphal (2):
>   xfrm: move mark and oif flowi decode into common code
>   xfrm: policy: replace session decode with flow dissector
> 
> Florian Westphal (2):
>   xfrm: move mark and oif flowi decode into common code
>   xfrm: policy: replace session decode with flow dissector
> 
>  net/xfrm/xfrm_policy.c | 277 ++++++++++++++++-------------------------
>  1 file changed, 107 insertions(+), 170 deletions(-)

For series,

Reviewed-by: Simon Horman <[e-mail]>