| Message ID | 20230911161518.650726-1-vignesh.raman@collabora.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | bdc4d17e1627e3b44f25b8f87509023dc2b438a2 |
| Headers | show |
| Series | arm64: dts: qcom: apq8016-sbc: Add overlay for usb host mode | expand |
On 11/09/2023 13:15, Vignesh Raman wrote: > Due to the presence of the fastboot micro cable in the CI farm, > it causes the hardware to remain in gadget mode instead of host mode. > So it doesn't find the network, which results in failure to mount root > fs via NFS. Just a context for others, this was part of this patch series https://lore.kernel.org/r/20230908152225.432139-1-vignesh.raman@collabora.com > > Add an overlay dtso file that sets the dr_mode to host, allowing the > USB controllers to work in host mode. With commit 15d16d6dadf6 > ("kbuild: Add generic rule to apply fdtoverlay"), overlay target can > be used to simplify the build of DTB overlays. It uses fdtoverlay to > merge base device tree with the overlay dtso. apq8016-sbc-usb-host.dtb > file can be used by drm-ci, mesa-ci. > > Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Suggested-by: Maxime Ripard <mripard@kernel.org> > Signed-off-by: Helen Koike <helen.koike@collabora.com> > Signed-off-by: David Heidelberg <david.heidelberg@collabora.com> > Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com> Acked-by: Helen Koike <helen.koike@collabora.com> > --- > arch/arm64/boot/dts/qcom/Makefile | 4 ++++ > arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso | 8 ++++++++ > 2 files changed, 12 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 2cca20563a1d..99190a6ba6ff 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -1,5 +1,9 @@ > # SPDX-License-Identifier: GPL-2.0 > dtb-$(CONFIG_ARCH_QCOM) += apq8016-sbc.dtb > + > +apq8016-sbc-usb-host-dtbs := apq8016-sbc.dtb apq8016-sbc-usb-host.dtbo > + > +dtb-$(CONFIG_ARCH_QCOM) += apq8016-sbc-usb-host.dtb > dtb-$(CONFIG_ARCH_QCOM) += apq8016-sbc-d3-camera-mezzanine.dtb > dtb-$(CONFIG_ARCH_QCOM) += apq8039-t2.dtb > dtb-$(CONFIG_ARCH_QCOM) += apq8094-sony-xperia-kitakami-karin_windy.dtb > diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso > new file mode 100644 > index 000000000000..a82c26b7eae8 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso > @@ -0,0 +1,8 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > + > +/dts-v1/; > +/plugin/; > + > +&usb { > + dr_mode = "host"; > +};
Hi maintainers, On 12/09/23 22:39, Helen Koike wrote: > > > On 11/09/2023 13:15, Vignesh Raman wrote: >> Due to the presence of the fastboot micro cable in the CI farm, >> it causes the hardware to remain in gadget mode instead of host mode. >> So it doesn't find the network, which results in failure to mount root >> fs via NFS. > > Just a context for others, this was part of this patch series > https://lore.kernel.org/r/20230908152225.432139-1-vignesh.raman@collabora.com > >> >> Add an overlay dtso file that sets the dr_mode to host, allowing the >> USB controllers to work in host mode. With commit 15d16d6dadf6 >> ("kbuild: Add generic rule to apply fdtoverlay"), overlay target can >> be used to simplify the build of DTB overlays. It uses fdtoverlay to >> merge base device tree with the overlay dtso. apq8016-sbc-usb-host.dtb >> file can be used by drm-ci, mesa-ci. >> >> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> Suggested-by: Maxime Ripard <mripard@kernel.org> >> Signed-off-by: Helen Koike <helen.koike@collabora.com> >> Signed-off-by: David Heidelberg <david.heidelberg@collabora.com> >> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com> > > Acked-by: Helen Koike <helen.koike@collabora.com> > > >> --- >> arch/arm64/boot/dts/qcom/Makefile | 4 ++++ >> arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso | 8 ++++++++ >> 2 files changed, 12 insertions(+) >> create mode 100644 arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso >> >> diff --git a/arch/arm64/boot/dts/qcom/Makefile >> b/arch/arm64/boot/dts/qcom/Makefile >> index 2cca20563a1d..99190a6ba6ff 100644 >> --- a/arch/arm64/boot/dts/qcom/Makefile >> +++ b/arch/arm64/boot/dts/qcom/Makefile >> @@ -1,5 +1,9 @@ >> # SPDX-License-Identifier: GPL-2.0 >> dtb-$(CONFIG_ARCH_QCOM) += apq8016-sbc.dtb >> + >> +apq8016-sbc-usb-host-dtbs := apq8016-sbc.dtb >> apq8016-sbc-usb-host.dtbo >> + >> +dtb-$(CONFIG_ARCH_QCOM) += apq8016-sbc-usb-host.dtb >> dtb-$(CONFIG_ARCH_QCOM) += apq8016-sbc-d3-camera-mezzanine.dtb >> dtb-$(CONFIG_ARCH_QCOM) += apq8039-t2.dtb >> dtb-$(CONFIG_ARCH_QCOM) += >> apq8094-sony-xperia-kitakami-karin_windy.dtb >> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso >> b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso >> new file mode 100644 >> index 000000000000..a82c26b7eae8 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso >> @@ -0,0 +1,8 @@ >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> + >> +/dts-v1/; >> +/plugin/; >> + >> +&usb { >> + dr_mode = "host"; >> +}; Please could you review this patch. Thanks. Regards, Vignesh
On Thu, 21 Sept 2023 at 17:01, Vignesh Raman <vignesh.raman@collabora.com> wrote: > > Hi maintainers, > > On 12/09/23 22:39, Helen Koike wrote: > > > > > > On 11/09/2023 13:15, Vignesh Raman wrote: > >> Due to the presence of the fastboot micro cable in the CI farm, > >> it causes the hardware to remain in gadget mode instead of host mode. > >> So it doesn't find the network, which results in failure to mount root > >> fs via NFS. > > > > Just a context for others, this was part of this patch series > > https://lore.kernel.org/r/20230908152225.432139-1-vignesh.raman@collabora.com > > > >> > >> Add an overlay dtso file that sets the dr_mode to host, allowing the > >> USB controllers to work in host mode. With commit 15d16d6dadf6 > >> ("kbuild: Add generic rule to apply fdtoverlay"), overlay target can > >> be used to simplify the build of DTB overlays. It uses fdtoverlay to > >> merge base device tree with the overlay dtso. apq8016-sbc-usb-host.dtb > >> file can be used by drm-ci, mesa-ci. > >> > >> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > >> Suggested-by: Maxime Ripard <mripard@kernel.org> > >> Signed-off-by: Helen Koike <helen.koike@collabora.com> > >> Signed-off-by: David Heidelberg <david.heidelberg@collabora.com> > >> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com> > > > > Acked-by: Helen Koike <helen.koike@collabora.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > > >> --- > >> arch/arm64/boot/dts/qcom/Makefile | 4 ++++ > >> arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso | 8 ++++++++ > >> 2 files changed, 12 insertions(+) > >> create mode 100644 arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso
On Mon, 11 Sep 2023 21:45:18 +0530, Vignesh Raman wrote: > Due to the presence of the fastboot micro cable in the CI farm, > it causes the hardware to remain in gadget mode instead of host mode. > So it doesn't find the network, which results in failure to mount root > fs via NFS. > > Add an overlay dtso file that sets the dr_mode to host, allowing the > USB controllers to work in host mode. With commit 15d16d6dadf6 > ("kbuild: Add generic rule to apply fdtoverlay"), overlay target can > be used to simplify the build of DTB overlays. It uses fdtoverlay to > merge base device tree with the overlay dtso. apq8016-sbc-usb-host.dtb > file can be used by drm-ci, mesa-ci. > > [...] Applied, thanks! [1/1] arm64: dts: qcom: apq8016-sbc: Add overlay for usb host mode commit: bdc4d17e1627e3b44f25b8f87509023dc2b438a2 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index 2cca20563a1d..99190a6ba6ff 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -1,5 +1,9 @@ # SPDX-License-Identifier: GPL-2.0 dtb-$(CONFIG_ARCH_QCOM) += apq8016-sbc.dtb + +apq8016-sbc-usb-host-dtbs := apq8016-sbc.dtb apq8016-sbc-usb-host.dtbo + +dtb-$(CONFIG_ARCH_QCOM) += apq8016-sbc-usb-host.dtb dtb-$(CONFIG_ARCH_QCOM) += apq8016-sbc-d3-camera-mezzanine.dtb dtb-$(CONFIG_ARCH_QCOM) += apq8039-t2.dtb dtb-$(CONFIG_ARCH_QCOM) += apq8094-sony-xperia-kitakami-karin_windy.dtb diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso new file mode 100644 index 000000000000..a82c26b7eae8 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso @@ -0,0 +1,8 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) + +/dts-v1/; +/plugin/; + +&usb { + dr_mode = "host"; +};
Due to the presence of the fastboot micro cable in the CI farm, it causes the hardware to remain in gadget mode instead of host mode. So it doesn't find the network, which results in failure to mount root fs via NFS. Add an overlay dtso file that sets the dr_mode to host, allowing the USB controllers to work in host mode. With commit 15d16d6dadf6 ("kbuild: Add generic rule to apply fdtoverlay"), overlay target can be used to simplify the build of DTB overlays. It uses fdtoverlay to merge base device tree with the overlay dtso. apq8016-sbc-usb-host.dtb file can be used by drm-ci, mesa-ci. Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Suggested-by: Maxime Ripard <mripard@kernel.org> Signed-off-by: Helen Koike <helen.koike@collabora.com> Signed-off-by: David Heidelberg <david.heidelberg@collabora.com> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com> --- arch/arm64/boot/dts/qcom/Makefile | 4 ++++ arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso | 8 ++++++++ 2 files changed, 12 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso