mbox series

[0/8] btrfs: some cleanups around inode update and helpers

Message ID cover.1695333082.git.fdmanana@suse.com (mailing list archive)
Headers show
Series btrfs: some cleanups around inode update and helpers | expand

Message

Filipe Manana Sept. 22, 2023, 10:37 a.m. UTC
From: Filipe Manana <fdmanana@suse.com>

Some cleanups mostly around btrfs_update_inode(), its helpers and some
callers, mostly to remove the redundant root argument, which can be taken
from the given inode. More details in the changelogs.

Filipe Manana (8):
  btrfs: simplify error check condition at btrfs_dirty_inode()
  btrfs: remove noline from btrfs_update_inode()
  btrfs: remove redundant root argument from btrfs_update_inode_fallback()
  btrfs: remove redundant root argument from btrfs_update_inode()
  btrfs: remove redundant root argument from btrfs_update_inode_item()
  btrfs: remove redundant root argument from btrfs_delayed_update_inode()
  btrfs: remove redundant root argument from maybe_insert_hole()
  btrfs: remove redundant root argument from fixup_inode_link_count()

 fs/btrfs/block-group.c      |  3 +-
 fs/btrfs/btrfs_inode.h      |  4 +--
 fs/btrfs/delayed-inode.c    |  2 +-
 fs/btrfs/delayed-inode.h    |  1 -
 fs/btrfs/file.c             |  8 ++---
 fs/btrfs/free-space-cache.c | 13 ++++----
 fs/btrfs/inode.c            | 66 ++++++++++++++++++-------------------
 fs/btrfs/ioctl.c            |  2 +-
 fs/btrfs/reflink.c          |  3 +-
 fs/btrfs/transaction.c      |  2 +-
 fs/btrfs/tree-log.c         | 32 +++++++++---------
 fs/btrfs/verity.c           |  4 +--
 fs/btrfs/xattr.c            |  4 +--
 13 files changed, 68 insertions(+), 76 deletions(-)

Comments

David Sterba Sept. 22, 2023, 1:48 p.m. UTC | #1
On Fri, Sep 22, 2023 at 11:37:18AM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> Some cleanups mostly around btrfs_update_inode(), its helpers and some
> callers, mostly to remove the redundant root argument, which can be taken
> from the given inode. More details in the changelogs.
> 
> Filipe Manana (8):
>   btrfs: simplify error check condition at btrfs_dirty_inode()
>   btrfs: remove noline from btrfs_update_inode()
>   btrfs: remove redundant root argument from btrfs_update_inode_fallback()
>   btrfs: remove redundant root argument from btrfs_update_inode()
>   btrfs: remove redundant root argument from btrfs_update_inode_item()
>   btrfs: remove redundant root argument from btrfs_delayed_update_inode()
>   btrfs: remove redundant root argument from maybe_insert_hole()
>   btrfs: remove redundant root argument from fixup_inode_link_count()

Added to misc-next, thanks. The effects of removed parameters:

btrfs_finish_one_ordered                      -8 (208 -> 200)
btrfs_update_inode                            -8 (48 -> 40)
clone_finish_inode_update                     -8 (72 -> 64)
btrfs_cont_expand                             -8 (184 -> 176)
btrfs_xattr_handler_set_prop                  -8 (64 -> 56)
btrfs_fallocate_update_isize                  -8 (40 -> 32)
btrfs_add_link                                +8 (120 -> 128)
btrfs_update_inode_fallback                   -8 (32 -> 24)
btrfs_write_out_cache                         -8 (144 -> 136)
btrfs_setxattr_trans                          -8 (72 -> 64)