| Message ID | a6570ecf163983ecc3b057aab71dd3d76d8a5307.1695380646.git.dsterba@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Minor cleanups in relocation.c | expand |
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
On 2023/9/22 20:37, David Sterba wrote: > The btrfs_backref_cache::is_reloc is an indicator variable and should > use a bool type. > > Signed-off-by: David Sterba <dsterba@suse.com> Reviewed-by: Qu Wenruo <wqu@suse.com> Thanks, Qu > --- > fs/btrfs/backref.c | 2 +- > fs/btrfs/backref.h | 4 ++-- > fs/btrfs/relocation.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c > index 0cde873bdee2..0dc91bf654b5 100644 > --- a/fs/btrfs/backref.c > +++ b/fs/btrfs/backref.c > @@ -3001,7 +3001,7 @@ int btrfs_backref_iter_next(struct btrfs_backref_iter *iter) > } > > void btrfs_backref_init_cache(struct btrfs_fs_info *fs_info, > - struct btrfs_backref_cache *cache, int is_reloc) > + struct btrfs_backref_cache *cache, bool is_reloc) > { > int i; > > diff --git a/fs/btrfs/backref.h b/fs/btrfs/backref.h > index 3b077d10bbc0..83a9a34e948e 100644 > --- a/fs/btrfs/backref.h > +++ b/fs/btrfs/backref.h > @@ -440,11 +440,11 @@ struct btrfs_backref_cache { > * Reloction backref cache require more info for reloc root compared > * to generic backref cache. > */ > - unsigned int is_reloc; > + bool is_reloc; > }; > > void btrfs_backref_init_cache(struct btrfs_fs_info *fs_info, > - struct btrfs_backref_cache *cache, int is_reloc); > + struct btrfs_backref_cache *cache, bool is_reloc); > struct btrfs_backref_node *btrfs_backref_alloc_node( > struct btrfs_backref_cache *cache, u64 bytenr, int level); > struct btrfs_backref_edge *btrfs_backref_alloc_edge( > diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c > index 3e662cadecaf..75463377f418 100644 > --- a/fs/btrfs/relocation.c > +++ b/fs/btrfs/relocation.c > @@ -4016,7 +4016,7 @@ static struct reloc_control *alloc_reloc_control(struct btrfs_fs_info *fs_info) > > INIT_LIST_HEAD(&rc->reloc_roots); > INIT_LIST_HEAD(&rc->dirty_subvol_roots); > - btrfs_backref_init_cache(fs_info, &rc->backref_cache, 1); > + btrfs_backref_init_cache(fs_info, &rc->backref_cache, true); > rc->reloc_root_tree.rb_root = RB_ROOT; > spin_lock_init(&rc->reloc_root_tree.lock); > extent_io_tree_init(fs_info, &rc->processed_blocks, IO_TREE_RELOC_BLOCKS);
diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c index 0cde873bdee2..0dc91bf654b5 100644 --- a/fs/btrfs/backref.c +++ b/fs/btrfs/backref.c @@ -3001,7 +3001,7 @@ int btrfs_backref_iter_next(struct btrfs_backref_iter *iter) } void btrfs_backref_init_cache(struct btrfs_fs_info *fs_info, - struct btrfs_backref_cache *cache, int is_reloc) + struct btrfs_backref_cache *cache, bool is_reloc) { int i; diff --git a/fs/btrfs/backref.h b/fs/btrfs/backref.h index 3b077d10bbc0..83a9a34e948e 100644 --- a/fs/btrfs/backref.h +++ b/fs/btrfs/backref.h @@ -440,11 +440,11 @@ struct btrfs_backref_cache { * Reloction backref cache require more info for reloc root compared * to generic backref cache. */ - unsigned int is_reloc; + bool is_reloc; }; void btrfs_backref_init_cache(struct btrfs_fs_info *fs_info, - struct btrfs_backref_cache *cache, int is_reloc); + struct btrfs_backref_cache *cache, bool is_reloc); struct btrfs_backref_node *btrfs_backref_alloc_node( struct btrfs_backref_cache *cache, u64 bytenr, int level); struct btrfs_backref_edge *btrfs_backref_alloc_edge( diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c index 3e662cadecaf..75463377f418 100644 --- a/fs/btrfs/relocation.c +++ b/fs/btrfs/relocation.c @@ -4016,7 +4016,7 @@ static struct reloc_control *alloc_reloc_control(struct btrfs_fs_info *fs_info) INIT_LIST_HEAD(&rc->reloc_roots); INIT_LIST_HEAD(&rc->dirty_subvol_roots); - btrfs_backref_init_cache(fs_info, &rc->backref_cache, 1); + btrfs_backref_init_cache(fs_info, &rc->backref_cache, true); rc->reloc_root_tree.rb_root = RB_ROOT; spin_lock_init(&rc->reloc_root_tree.lock); extent_io_tree_init(fs_info, &rc->processed_blocks, IO_TREE_RELOC_BLOCKS);
The btrfs_backref_cache::is_reloc is an indicator variable and should use a bool type. Signed-off-by: David Sterba <dsterba@suse.com> --- fs/btrfs/backref.c | 2 +- fs/btrfs/backref.h | 4 ++-- fs/btrfs/relocation.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)