mbox series

[v4,0/9] Add R5F and C7x DSP node for K3 J721S2, AM68 and AM69 SoCs

Message ID 20230906112422.2846151-1-a-nandan@ti.com (mailing list archive)
Headers show
Series Add R5F and C7x DSP node for K3 J721S2, AM68 and AM69 SoCs | expand

Message

Apurva Nandan Sept. 6, 2023, 11:24 a.m. UTC
This series adds the R5F processor nodes and C7x DSP nodes for 
J721S2, AM68 and AM69 SoCs to align these nodes with other K3 SOC's node.

The first three patches adds the remote proc nodes to the SoC device
tree, remaining patches reserves the memory for remote proc IPCs
on K3 J721S2 EVM, AM68 SK, AM69 boards.

Note, K3 AM69 SoC derives from K3 J784S4 SoC, but is included in this
series as it was originally missed in the K3 J784S4 EVM rproc series.
(https://lore.kernel.org/all/20230502231527.25879-4-hnagalla@ti.com/).

kpv log: https://gist.githubusercontent.com/apurvanandan1997/57fcf127c118a48bd174ce36d8840329/raw/
Test log: https://gist.githubusercontent.com/apurvanandan1997/556b4148651ae74b50dda993ad07f1e5/raw/

v4: Changelog:
1) Added R5F and C7x nodes for K3 AM68 and AM69 SoCs

Link to v3:
https://lore.kernel.org/linux-arm-kernel/20230811202252.3586926-1-a-nandan@ti.com/

v3: Changelog:
1) Disabled c7x in k3-j721s2-main.dtsi and enabled in k3-j721s2-som-p0.dtsi
   which fixes the following dtbs_check for k3-am69-sk.dts
   - dsp@64800000: 'mboxes' is a required property
   - dsp@64800000: 'memory-region' is a required property
2) Split into separate patches for C7x and R5F

Link to v2:
https://lore.kernel.org/lkml/20230808201842.292911-1-a-nandan@ti.com/

v2:Changelog:
1) Added status = "disabled"; in soc dtsi files, and removed it from som dts
2) Fixed mboxes property in for all cores in som dts

Link to v1:
https://lore.kernel.org/all/20230529220941.10801-1-hnagalla@ti.com/


Apurva Nandan (9):
  arm64: dts: ti: k3-j721s2-mcu: Add MCU R5F cluster nodes
  arm64: dts: ti: k3-j721s2-main: Add MAIN R5F remote processsor nodes
  arm64: dts: ti: k3-j721s2-main: Add C7x remote processsor nodes
  arm64: dts : ti: k3-j721s2-som-p0: Add DDR carveout memory nodes for
    R5F
  arm64: dts : ti: k3-j721s2-som-p0: Add DDR carveout memory nodes for
    C71x DSPs
  arm64: dts : ti: k3-am68-sk-som: Add DDR carveout memory nodes for R5F
  arm64: dts : ti: k3-am68-sk-som: Add DDR carveout memory nodes for
    C71x DSP
  arm64: dts : ti: k3-am69-sk: Add DDR carveout memory nodes for R5F
  arm64: dts : ti: k3-am69-sk: Add DDR carveout memory nodes for C71x
    DSP

 arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi    | 208 ++++++++++++
 arch/arm64/boot/dts/ti/k3-am69-sk.dts         | 304 ++++++++++++++++++
 arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi    | 106 ++++++
 .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi     |  40 +++
 arch/arm64/boot/dts/ti/k3-j721s2-som-p0.dtsi  | 208 ++++++++++++
 5 files changed, 866 insertions(+)

Comments

Kumar, Udit Sept. 27, 2023, 8:54 a.m. UTC | #1
On 9/6/2023 4:54 PM, Apurva Nandan wrote:
> This series adds the R5F processor nodes and C7x DSP nodes for
> J721S2, AM68 and AM69 SoCs to align these nodes with other K3 SOC's node.
>
> The first three patches adds the remote proc nodes to the SoC device
> tree, remaining patches reserves the memory for remote proc IPCs
> on K3 J721S2 EVM, AM68 SK, AM69 boards.
>
> Note, K3 AM69 SoC derives from K3 J784S4 SoC, but is included in this
> series as it was originally missed in the K3 J784S4 EVM rproc series.
> (https://lore.kernel.org/all/20230502231527.25879-4-hnagalla@ti.com/).
>
> kpv log: https://gist.githubusercontent.com/apurvanandan1997/57fcf127c118a48bd174ce36d8840329/raw/
> Test log: https://gist.githubusercontent.com/apurvanandan1997/556b4148651ae74b50dda993ad07f1e5/raw/

You need to rebase the series

For patches 6/9, 7/9, 8/9 and 9/9

Reviewed by: Udit Kumar <u-kumar1@ti.com>

>
> v4: Changelog:
> 1) Added R5F and C7x nodes for K3 AM68 and AM69 SoCs
>
> Link to v3:
> https://lore.kernel.org/linux-arm-kernel/20230811202252.3586926-1-a-nandan@ti.com/
>
> v3: Changelog:
> 1) Disabled c7x in k3-j721s2-main.dtsi and enabled in k3-j721s2-som-p0.dtsi
>     which fixes the following dtbs_check for k3-am69-sk.dts
>     - dsp@64800000: 'mboxes' is a required property
>     - dsp@64800000: 'memory-region' is a required property
> 2) Split into separate patches for C7x and R5F
>
> Link to v2:
> https://lore.kernel.org/lkml/20230808201842.292911-1-a-nandan@ti.com/
>
> v2:Changelog:
> 1) Added status = "disabled"; in soc dtsi files, and removed it from som dts
> 2) Fixed mboxes property in for all cores in som dts
>
> Link to v1:
> https://lore.kernel.org/all/20230529220941.10801-1-hnagalla@ti.com/
>
>
> Apurva Nandan (9):
>    arm64: dts: ti: k3-j721s2-mcu: Add MCU R5F cluster nodes
>    arm64: dts: ti: k3-j721s2-main: Add MAIN R5F remote processsor nodes
>    arm64: dts: ti: k3-j721s2-main: Add C7x remote processsor nodes
>    arm64: dts : ti: k3-j721s2-som-p0: Add DDR carveout memory nodes for
>      R5F
>    arm64: dts : ti: k3-j721s2-som-p0: Add DDR carveout memory nodes for
>      C71x DSPs
>    arm64: dts : ti: k3-am68-sk-som: Add DDR carveout memory nodes for R5F
>    arm64: dts : ti: k3-am68-sk-som: Add DDR carveout memory nodes for
>      C71x DSP
>    arm64: dts : ti: k3-am69-sk: Add DDR carveout memory nodes for R5F
>    arm64: dts : ti: k3-am69-sk: Add DDR carveout memory nodes for C71x
>      DSP
>
>   arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi    | 208 ++++++++++++
>   arch/arm64/boot/dts/ti/k3-am69-sk.dts         | 304 ++++++++++++++++++
>   arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi    | 106 ++++++
>   .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi     |  40 +++
>   arch/arm64/boot/dts/ti/k3-j721s2-som-p0.dtsi  | 208 ++++++++++++
>   5 files changed, 866 insertions(+)
>
Nishanth Menon Sept. 27, 2023, 12:28 p.m. UTC | #2
On 14:24-20230927, Kumar, Udit wrote:
> 
> On 9/6/2023 4:54 PM, Apurva Nandan wrote:
> > This series adds the R5F processor nodes and C7x DSP nodes for
> > J721S2, AM68 and AM69 SoCs to align these nodes with other K3 SOC's node.
> > 
> > The first three patches adds the remote proc nodes to the SoC device
> > tree, remaining patches reserves the memory for remote proc IPCs
> > on K3 J721S2 EVM, AM68 SK, AM69 boards.
> > 
> > Note, K3 AM69 SoC derives from K3 J784S4 SoC, but is included in this
> > series as it was originally missed in the K3 J784S4 EVM rproc series.
> > (https://lore.kernel.org/all/20230502231527.25879-4-hnagalla@ti.com/).
> > 
> > kpv log: https://gist.githubusercontent.com/apurvanandan1997/57fcf127c118a48bd174ce36d8840329/raw/
> > Test log: https://gist.githubusercontent.com/apurvanandan1997/556b4148651ae74b50dda993ad07f1e5/raw/
> 
> You need to rebase the series
> 
> For patches 6/9, 7/9, 8/9 and 9/9
> 
> Reviewed by: Udit Kumar <u-kumar1@ti.com>

Please provide reviewed by for the exact patches than expecting
maintainers to pick the reviewed bys.