| Message ID | 70f9a616df5b0f4268f309312d93d3a972fd9289.1695753057.git.fdmanana@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | btrfs: always print transaction aborted messages with an error level | expand |
On 2023/9/27 04:01, fdmanana@kernel.org wrote: > From: Filipe Manana <fdmanana@suse.com> > > Commit b7af0635c87f ("btrfs: print transaction aborted messages with an > error level") changed the log level of transaction aborted messages from > a debug level to an error level, so that such messages are always visible > even on production systems where the log level is normally above the debug > level (and also on some syzbot reports). > > Later, commit fccf0c842ed4 ("btrfs: move btrfs_abort_transaction to > transaction.c") changed the log level back to debug level when the error > number for a transaction abort should not have a stack trace printed. > This happened for absolutely no reason. It's always useful to print > transaction abort messages with an error level, regardless of whether > the error number should cause a stack trace or not. > > So change back the log level to error level. > > Fixes: fccf0c842ed4 ("btrfs: move btrfs_abort_transaction to transaction.c") > Signed-off-by: Filipe Manana <fdmanana@suse.com> Reviewed-by: Qu Wenruo <wqu@suse.com> Thanks, Qu > --- > fs/btrfs/transaction.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/btrfs/transaction.h b/fs/btrfs/transaction.h > index de58776de307..f5bf3489d8c5 100644 > --- a/fs/btrfs/transaction.h > +++ b/fs/btrfs/transaction.h > @@ -222,8 +222,8 @@ do { \ > (error))) { \ > /* Stack trace printed. */ \ > } else { \ > - btrfs_debug((trans)->fs_info, \ > - "Transaction aborted (error %d)", \ > + btrfs_err((trans)->fs_info, \ > + "Transaction aborted (error %d)", \ > (error)); \ > } \ > } \
On Tue, Sep 26, 2023 at 07:31:19PM +0100, fdmanana@kernel.org wrote: > From: Filipe Manana <fdmanana@suse.com> > > Commit b7af0635c87f ("btrfs: print transaction aborted messages with an > error level") changed the log level of transaction aborted messages from > a debug level to an error level, so that such messages are always visible > even on production systems where the log level is normally above the debug > level (and also on some syzbot reports). > > Later, commit fccf0c842ed4 ("btrfs: move btrfs_abort_transaction to > transaction.c") changed the log level back to debug level when the error > number for a transaction abort should not have a stack trace printed. > This happened for absolutely no reason. That was mistake on my side while rebasing the patches that moved code, thanks for noticing it. > It's always useful to print > transaction abort messages with an error level, regardless of whether > the error number should cause a stack trace or not. > > So change back the log level to error level. > > Fixes: fccf0c842ed4 ("btrfs: move btrfs_abort_transaction to transaction.c") > Signed-off-by: Filipe Manana <fdmanana@suse.com> Added to misc-next, thanks.
diff --git a/fs/btrfs/transaction.h b/fs/btrfs/transaction.h index de58776de307..f5bf3489d8c5 100644 --- a/fs/btrfs/transaction.h +++ b/fs/btrfs/transaction.h @@ -222,8 +222,8 @@ do { \ (error))) { \ /* Stack trace printed. */ \ } else { \ - btrfs_debug((trans)->fs_info, \ - "Transaction aborted (error %d)", \ + btrfs_err((trans)->fs_info, \ + "Transaction aborted (error %d)", \ (error)); \ } \ } \