| Message ID | 20230927081040.2198742-1-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | platform: Convert to platform remove callback returning void | expand |
Hello: This series was applied to chrome-platform/linux.git (for-kernelci) by Tzung-Bi Shih <tzungbi@kernel.org>: On Wed, 27 Sep 2023 10:10:13 +0200 you wrote: > Hello, > > this series converts all platform drivers below drivers/platform to use > .remove_new(). The motivation is to get rid of an integer return code > that is (mostly) ignored by the platform driver core and error prone on > the driver side. > > [...] Here is the summary with links: - [01/27] platform/chrome: cros_ec_chardev: Convert to platform remove callback returning void https://git.kernel.org/chrome-platform/c/f04410e7be65 - [02/27] platform/chrome: cros_ec_debugfs: Convert to platform remove callback returning void https://git.kernel.org/chrome-platform/c/f366fa0064ef - [03/27] platform/chrome: cros_ec_lightbar: Convert to platform remove callback returning void https://git.kernel.org/chrome-platform/c/fa45583c3133 - [04/27] platform/chrome: cros_ec_lpc: Convert to platform remove callback returning void https://git.kernel.org/chrome-platform/c/e02944e85169 - [05/27] platform/chrome: cros_ec_sysfs: Convert to platform remove callback returning void https://git.kernel.org/chrome-platform/c/6478e302409a - [06/27] platform/chrome: cros_ec_vbc: Convert to platform remove callback returning void https://git.kernel.org/chrome-platform/c/58b15196b0ef - [07/27] platform/chrome: cros_typec_switch: Convert to platform remove callback returning void https://git.kernel.org/chrome-platform/c/ea4bad2badb7 - [08/27] platform/chrome: cros_usbpd_logger: Convert to platform remove callback returning void https://git.kernel.org/chrome-platform/c/b6c1fea83550 - [09/27] platform/chrome: cros_usbpd_notify: Convert to platform remove callback returning void https://git.kernel.org/chrome-platform/c/b98362be7c92 - [10/27] platform/chrome/wilco_ec: core: Convert to platform remove callback returning void https://git.kernel.org/chrome-platform/c/48648504e488 - [11/27] platform/chrome/wilco_ec: debugfs: Convert to platform remove callback returning void https://git.kernel.org/chrome-platform/c/1fca58f347d8 - [12/27] platform/chrome/wilco_ec: telemetry: Convert to platform remove callback returning void https://git.kernel.org/chrome-platform/c/7396a5b980fd You are awesome, thank you!
On Wed, 27 Sep 2023 10:10:13 +0200, Uwe Kleine-König wrote: > this series converts all platform drivers below drivers/platform to use > .remove_new(). The motivation is to get rid of an integer return code > that is (mostly) ignored by the platform driver core and error prone on > the driver side. > > See commit 5c5a7680e67b ("platform: Provide a remove callback that > returns no value") for an extended explanation and the eventual goal. > > [...] Thank you for your contribution, it has been applied to my local review-ilpo branch. Note it will show up in the public platform-drivers-x86/review-ilpo branch only once I've pushed my local branch there, which might take a while. Once I've run some tests on the review-ilpo branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. The list of commits applied: [14/27] platform/mellanox: mlxbf-bootctl: Convert to platform remove callback returning void commit: a6cff4212984010c119263593c0a249e15ad5caf [15/27] platform/mellanox: mlxbf-tmfifo: Convert to platform remove callback returning void commit: db971cf26014948d642522dae9a01968d009751c [16/27] platform/mellanox: mlxreg-hotplug: Convert to platform remove callback returning void commit: a62507eb57124f4889b97de9917a164bf3109aa6 [17/27] platform/mellanox: mlxreg-io: Convert to platform remove callback returning void commit: e0489bb002ff581f9439de2d22b49e140e73e6b4 [18/27] platform/mellanox: mlxreg-lc: Convert to platform remove callback returning void commit: cfae9860ca990c5a642da85e01e0eb2e7dd9db35 [19/27] platform/mellanox: nvsw-sn2201: Convert to platform remove callback returning void commit: 61e2e9ee39d921756050dafeb91537284139f611 [20/27] platform/x86/intel: bytcrc_pwrsrc: Convert to platform remove callback returning void commit: 3e29812e6e172ba772761e6995753b729e8a6f77 [21/27] platform/x86: mlx-platform: Convert to platform remove callback returning void commit: 1348317db770681cde4c6ac04afd75a1b0a99098 [22/27] platform/x86: sel3350-platform: Convert to platform remove callback returning void commit: 9e6b44d43e31160bfba568244c785f439ac33d0e [23/27] platform/x86/siemens: simatic-ipc-batt: Simplify simatic_ipc_batt_remove() commit: 0580422560e2b93fe2e343d8438823824729a574 [24/27] platform/x86/siemens: simatic-ipc-batt: Convert to platform remove callback returning void commit: 2f46e417384e0412c5e239fe6a84ace7d955b33e [25/27] platform/x86/siemens: simatic-ipc-batt-apollolake: Convert to platform remove callback returning void commit: e139d97f049a8d924f91700a9a5f28c8bfe676d3 [26/27] platform/x86/siemens: simatic-ipc-batt-elkhartlake: Convert to platform remove callback returning void commit: 0d643dcd78423afad7204a280dc25dc67bcd85c0 [27/27] platform/x86/siemens: simatic-ipc-batt-f7188x: Convert to platform remove callback returning void commit: 49d371ab9d2c850867332b469fa6b3a2d5cf338c -- i.
On Wed, 27 Sep 2023, Uwe Kleine-König wrote: > Hello, > > this series converts all platform drivers below drivers/platform to use > .remove_new(). The motivation is to get rid of an integer return code > that is (mostly) ignored by the platform driver core and error prone on > the driver side. > > See commit 5c5a7680e67b ("platform: Provide a remove callback that > returns no value") for an extended explanation and the eventual goal. > > As there is no single maintainer team for drivers/platform, I suggest > the individual maintainers to pick up "their" patches. The only > inter-dependency in this series is that the patches #24 - #27 depend on > #23. Otherwise there are no inter-dependencies, so that should work > fine. As there are still quite a few drivers to convert in other areas > than drivers/platform, I'm happy about every patch that makes it in and > there is no need for further coordination. So even if there is a merge > conflict with one patch until you apply or a subject prefix is > suboptimal, please don't let you stop by negative feedback for other > patches (unless it applies to "your" patches, too, of course). > > Best regards and thanks for considering, > Uwe > > Uwe Kleine-König (27): > platform/chrome: cros_ec_chardev: Convert to platform remove callback > returning void > platform/chrome: cros_ec_debugfs: Convert to platform remove callback > returning void > platform/chrome: cros_ec_lightbar: Convert to platform remove callback > returning void > platform/chrome: cros_ec_lpc: Convert to platform remove callback > returning void > platform/chrome: cros_ec_sysfs: Convert to platform remove callback > returning void > platform/chrome: cros_ec_vbc: Convert to platform remove callback > returning void > platform/chrome: cros_typec_switch: Convert to platform remove > callback returning void > platform/chrome: cros_usbpd_logger: Convert to platform remove > callback returning void > platform/chrome: cros_usbpd_notify: Convert to platform remove > callback returning void > platform/chrome/wilco_ec: core: Convert to platform remove callback > returning void > platform/chrome/wilco_ec: debugfs: Convert to platform remove callback > returning void > platform/chrome/wilco_ec: telemetry: Convert to platform remove > callback returning void > platform/goldfish: goldfish_pipe: Convert to platform remove callback > returning void > platform/mellanox: mlxbf-bootctl: Convert to platform remove callback > returning void > platform/mellanox: mlxbf-tmfifo: Convert to platform remove callback > returning void > platform/mellanox: mlxreg-hotplug: Convert to platform remove callback > returning void > platform/mellanox: mlxreg-io: Convert to platform remove callback > returning void > platform/mellanox: mlxreg-lc: Convert to platform remove callback > returning void > platform/mellanox: nvsw-sn2201: Convert to platform remove callback > returning void > platform/x86/intel: bytcrc_pwrsrc: Convert to platform remove callback > returning void > platform/x86: mlx-platform: Convert to platform remove callback > returning void > platform/x86: sel3350-platform: Convert to platform remove callback > returning void > platform/x86/siemens: simatic-ipc-batt: Simplify > simatic_ipc_batt_remove() > platform/x86/siemens: simatic-ipc-batt: Convert to platform remove > callback returning void > platform/x86/siemens: simatic-ipc-batt-apollolake: Convert to platform > remove callback returning void > platform/x86/siemens: simatic-ipc-batt-elkhartlake: Convert to > platform remove callback returning void > platform/x86/siemens: simatic-ipc-batt-f7188x: Convert to platform > remove callback returning void Thanks for the patches. I don't know if you got the auto generated thank you email as it seemed to hit a character encoding problem while sending the email out. But in any case, I've applied patches 14-27 to my local review-ilpo branch (they will eventually appear on the public repo too and propagate to for-next).
Hello: This series was applied to chrome-platform/linux.git (for-next) by Tzung-Bi Shih <tzungbi@kernel.org>: On Wed, 27 Sep 2023 10:10:13 +0200 you wrote: > Hello, > > this series converts all platform drivers below drivers/platform to use > .remove_new(). The motivation is to get rid of an integer return code > that is (mostly) ignored by the platform driver core and error prone on > the driver side. > > [...] Here is the summary with links: - [01/27] platform/chrome: cros_ec_chardev: Convert to platform remove callback returning void https://git.kernel.org/chrome-platform/c/f04410e7be65 - [02/27] platform/chrome: cros_ec_debugfs: Convert to platform remove callback returning void https://git.kernel.org/chrome-platform/c/f366fa0064ef - [03/27] platform/chrome: cros_ec_lightbar: Convert to platform remove callback returning void https://git.kernel.org/chrome-platform/c/fa45583c3133 - [04/27] platform/chrome: cros_ec_lpc: Convert to platform remove callback returning void https://git.kernel.org/chrome-platform/c/e02944e85169 - [05/27] platform/chrome: cros_ec_sysfs: Convert to platform remove callback returning void https://git.kernel.org/chrome-platform/c/6478e302409a - [06/27] platform/chrome: cros_ec_vbc: Convert to platform remove callback returning void https://git.kernel.org/chrome-platform/c/58b15196b0ef - [07/27] platform/chrome: cros_typec_switch: Convert to platform remove callback returning void https://git.kernel.org/chrome-platform/c/ea4bad2badb7 - [08/27] platform/chrome: cros_usbpd_logger: Convert to platform remove callback returning void https://git.kernel.org/chrome-platform/c/b6c1fea83550 - [09/27] platform/chrome: cros_usbpd_notify: Convert to platform remove callback returning void https://git.kernel.org/chrome-platform/c/b98362be7c92 - [10/27] platform/chrome/wilco_ec: core: Convert to platform remove callback returning void https://git.kernel.org/chrome-platform/c/48648504e488 - [11/27] platform/chrome/wilco_ec: debugfs: Convert to platform remove callback returning void https://git.kernel.org/chrome-platform/c/1fca58f347d8 - [12/27] platform/chrome/wilco_ec: telemetry: Convert to platform remove callback returning void https://git.kernel.org/chrome-platform/c/7396a5b980fd You are awesome, thank you!
Hello, this series converts all platform drivers below drivers/platform to use .remove_new(). The motivation is to get rid of an integer return code that is (mostly) ignored by the platform driver core and error prone on the driver side. See commit 5c5a7680e67b ("platform: Provide a remove callback that returns no value") for an extended explanation and the eventual goal. As there is no single maintainer team for drivers/platform, I suggest the individual maintainers to pick up "their" patches. The only inter-dependency in this series is that the patches #24 - #27 depend on #23. Otherwise there are no inter-dependencies, so that should work fine. As there are still quite a few drivers to convert in other areas than drivers/platform, I'm happy about every patch that makes it in and there is no need for further coordination. So even if there is a merge conflict with one patch until you apply or a subject prefix is suboptimal, please don't let you stop by negative feedback for other patches (unless it applies to "your" patches, too, of course). Best regards and thanks for considering, Uwe Uwe Kleine-König (27): platform/chrome: cros_ec_chardev: Convert to platform remove callback returning void platform/chrome: cros_ec_debugfs: Convert to platform remove callback returning void platform/chrome: cros_ec_lightbar: Convert to platform remove callback returning void platform/chrome: cros_ec_lpc: Convert to platform remove callback returning void platform/chrome: cros_ec_sysfs: Convert to platform remove callback returning void platform/chrome: cros_ec_vbc: Convert to platform remove callback returning void platform/chrome: cros_typec_switch: Convert to platform remove callback returning void platform/chrome: cros_usbpd_logger: Convert to platform remove callback returning void platform/chrome: cros_usbpd_notify: Convert to platform remove callback returning void platform/chrome/wilco_ec: core: Convert to platform remove callback returning void platform/chrome/wilco_ec: debugfs: Convert to platform remove callback returning void platform/chrome/wilco_ec: telemetry: Convert to platform remove callback returning void platform/goldfish: goldfish_pipe: Convert to platform remove callback returning void platform/mellanox: mlxbf-bootctl: Convert to platform remove callback returning void platform/mellanox: mlxbf-tmfifo: Convert to platform remove callback returning void platform/mellanox: mlxreg-hotplug: Convert to platform remove callback returning void platform/mellanox: mlxreg-io: Convert to platform remove callback returning void platform/mellanox: mlxreg-lc: Convert to platform remove callback returning void platform/mellanox: nvsw-sn2201: Convert to platform remove callback returning void platform/x86/intel: bytcrc_pwrsrc: Convert to platform remove callback returning void platform/x86: mlx-platform: Convert to platform remove callback returning void platform/x86: sel3350-platform: Convert to platform remove callback returning void platform/x86/siemens: simatic-ipc-batt: Simplify simatic_ipc_batt_remove() platform/x86/siemens: simatic-ipc-batt: Convert to platform remove callback returning void platform/x86/siemens: simatic-ipc-batt-apollolake: Convert to platform remove callback returning void platform/x86/siemens: simatic-ipc-batt-elkhartlake: Convert to platform remove callback returning void platform/x86/siemens: simatic-ipc-batt-f7188x: Convert to platform remove callback returning void drivers/platform/chrome/cros_ec_chardev.c | 6 ++---- drivers/platform/chrome/cros_ec_debugfs.c | 6 ++---- drivers/platform/chrome/cros_ec_lightbar.c | 6 ++---- drivers/platform/chrome/cros_ec_lpc.c | 6 ++---- drivers/platform/chrome/cros_ec_sysfs.c | 6 ++---- drivers/platform/chrome/cros_ec_vbc.c | 6 ++---- drivers/platform/chrome/cros_typec_switch.c | 5 ++--- drivers/platform/chrome/cros_usbpd_logger.c | 6 ++---- drivers/platform/chrome/cros_usbpd_notify.c | 12 ++++-------- drivers/platform/chrome/wilco_ec/core.c | 5 ++--- drivers/platform/chrome/wilco_ec/debugfs.c | 6 ++---- drivers/platform/chrome/wilco_ec/telemetry.c | 6 ++---- drivers/platform/goldfish/goldfish_pipe.c | 5 ++--- drivers/platform/mellanox/mlxbf-bootctl.c | 6 ++---- drivers/platform/mellanox/mlxbf-tmfifo.c | 6 ++---- drivers/platform/mellanox/mlxreg-hotplug.c | 6 ++---- drivers/platform/mellanox/mlxreg-io.c | 6 ++---- drivers/platform/mellanox/mlxreg-lc.c | 8 +++----- drivers/platform/mellanox/nvsw-sn2201.c | 6 ++---- drivers/platform/x86/intel/bytcrc_pwrsrc.c | 5 ++--- drivers/platform/x86/mlx-platform.c | 5 ++--- drivers/platform/x86/sel3350-platform.c | 6 ++---- .../x86/siemens/simatic-ipc-batt-apollolake.c | 6 +++--- .../x86/siemens/simatic-ipc-batt-elkhartlake.c | 6 +++--- .../platform/x86/siemens/simatic-ipc-batt-f7188x.c | 6 +++--- drivers/platform/x86/siemens/simatic-ipc-batt.c | 9 ++++----- drivers/platform/x86/siemens/simatic-ipc-batt.h | 4 ++-- 27 files changed, 62 insertions(+), 104 deletions(-) base-commit: 18030226a48de1fbfabf4ae16aaa2695a484254f