| Message ID | 20230928110413.33032-10-jlayton@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fs: new accessor methods for atime and mtime | expand |
On Thu, Sep 28, 2023 at 07:02:20AM -0400, Jeff Layton wrote:
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
As much difficulty muti-subsystem patches are, we do need a changelog
entry please. Maybe some maintainers are nicer, but I can't ack a patch
without any text here at all, sorry.
thanks,
greg k-h
On Thu, 2023-09-28 at 14:13 +0200, Greg KH wrote: > On Thu, Sep 28, 2023 at 07:02:20AM -0400, Jeff Layton wrote: > > Signed-off-by: Jeff Layton <jlayton@kernel.org> > > As much difficulty muti-subsystem patches are, we do need a changelog > entry please. Maybe some maintainers are nicer, but I can't ack a patch > without any text here at all, sorry. > Ahh yes -- my bad. I'll add a boilerplate commit log for all of the "convert to new inode {a,m}time accessors" patches. Thanks,
diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index 8a94e5a43c6d..d13d2f2e76c7 100644 --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c @@ -818,7 +818,7 @@ static void tty_update_time(struct tty_struct *tty, bool mtime) spin_lock(&tty->files_lock); list_for_each_entry(priv, &tty->tty_files, list) { struct inode *inode = file_inode(priv->file); - struct timespec64 *time = mtime ? &inode->i_mtime : &inode->i_atime; + struct timespec64 time = mtime ? inode_get_mtime(inode) : inode_get_atime(inode); /* * We only care if the two values differ in anything other than the @@ -826,8 +826,12 @@ static void tty_update_time(struct tty_struct *tty, bool mtime) * the time of the tty device, otherwise it could be construded as a * security leak to let userspace know the exact timing of the tty. */ - if ((sec ^ time->tv_sec) & ~7) - time->tv_sec = sec; + if ((sec ^ time.tv_sec) & ~7) { + if (mtime) + inode_set_mtime(inode, sec, 0); + else + inode_set_atime(inode, sec, 0); + } } spin_unlock(&tty->files_lock); }
Signed-off-by: Jeff Layton <jlayton@kernel.org> --- drivers/tty/tty_io.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)