| Message ID | 20230928202834.47640-1-uvv.mail@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | README: Update overlayfs URL | expand |
On Thu, Sep 28, 2023 at 11:30 PM Vyacheslav Yurkov <uvv.mail@gmail.com> wrote: > > Overlayfs-tools and overlayfs-progs projects have been merged together. > Nice :) Do you also have any plans to improve the tools? > Signed-off-by: Vyacheslav Yurkov <uvv.mail@gmail.com> > --- > README | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/README b/README > index d9db9675..e558efc9 100644 > --- a/README > +++ b/README > @@ -19,7 +19,7 @@ Ubuntu or Debian > xfslibs-dev > > For OverlayFS install: While you are fixing the README: 1. Above should read 'build and install' like the rest of the sections 2. Please refrain from the use of letter case OverlayFS - it is inconsistent with the rest of fstests 3. This reads as if installing overlayfs-tools is a prerequisite for testing overlayfs, which is not true. In fact, in most likelihood, there are very few people that run fstests with fsck.overlay, so it would be more accurate to say: For fsck.overlay [optional], build and install: 4. Because fsck.overlay is not mandatory and because it is not distro specific, I think this instruction should be moved to README.overlay. Note that the instructions to install unionmount testsuite are in README.overlay and while they are also not mandatory fo testing overlayfs, they likely add much more test coverage then fsck.overlay does, so no reason to promote installing fsck.overlay more than installing unionmount Thanks, Amir. > - - see https://github.com/hisilicon/overlayfs-progs > + - see https://github.com/kmxz/overlayfs-tools > > Fedora > ------ > @@ -37,7 +37,7 @@ Fedora > xfsprogs-devel > > For OverlayFS build and install: > - - see https://github.com/hisilicon/overlayfs-progs > + - see https://github.com/kmxz/overlayfs-tools > > RHEL or CentOS > -------------- > @@ -75,7 +75,7 @@ RHEL or CentOS > - see https://github.com/markfasheh/ocfs2-tools > > For OverlayFS build and install: > - - see https://github.com/hisilicon/overlayfs-progs > + - see https://github.com/kmxz/overlayfs-tools > > SUSE Linux Enterprise or openSUSE > --------------------------------- > @@ -95,7 +95,7 @@ SUSE Linux Enterprise or openSUSE > $ sudo zypper install xfsdump xfsprogs-devel > > For OverlayFS build and install: > - - see https://github.com/hisilicon/overlayfs-progs > + - see https://github.com/kmxz/overlayfs-tools > > Build and install test, libs and utils > -------------------------------------- > -- > 2.35.1 >
On 29.09.2023 05:16, Amir Goldstein wrote: > On Thu, Sep 28, 2023 at 11:30 PM Vyacheslav Yurkov <uvv.mail@gmail.com> wrote: >> Overlayfs-tools and overlayfs-progs projects have been merged together. >> > Nice :) > > Do you also have any plans to improve the tools? Thanks for the review! I'll move the instructions completely to README.overlay in V2 then. Is there a particular reason that the file starts from an empty line? (perhaps I could remove that as well in the same patch) Right now the plan was only to maintain both projects and accept patches from others. Perhaps I will also update the build system to something up-to-date. As for further development, unfortunately I don't have a project behind ATM to improve the tools further. If something pops up (or you have something), I could try to find a capacity for that. Thanks, Vyacheslav
On Sun, Oct 1, 2023 at 3:41 AM Vyacheslav Yurkov <uvv.mail@gmail.com> wrote: > > On 29.09.2023 05:16, Amir Goldstein wrote: > > On Thu, Sep 28, 2023 at 11:30 PM Vyacheslav Yurkov <uvv.mail@gmail.com> wrote: > >> Overlayfs-tools and overlayfs-progs projects have been merged together. > >> > > Nice :) > > > > Do you also have any plans to improve the tools? > > Thanks for the review! > I'll move the instructions completely to README.overlay in V2 then. Is > there a particular reason that the file starts from an empty line? No reason. > (perhaps I could remove that as well in the same patch) > OK. > Right now the plan was only to maintain both projects and accept patches > from others. Perhaps I will also update the build system to something > up-to-date. As for further development, unfortunately I don't have a > project behind ATM to improve the tools further. If something pops up > (or you have something), I could try to find a capacity for that. Gao was asking about an offline merge tool, so I pointed him at overlayfs-tools: https://lore.kernel.org/linux-unionfs/bc9b3731-9eac-28be-e635-44a098e87d76@linux.alibaba.com/ Maybe he can explain what features in specific he was looking for. Thanks, Amir.
diff --git a/README b/README index d9db9675..e558efc9 100644 --- a/README +++ b/README @@ -19,7 +19,7 @@ Ubuntu or Debian xfslibs-dev For OverlayFS install: - - see https://github.com/hisilicon/overlayfs-progs + - see https://github.com/kmxz/overlayfs-tools Fedora ------ @@ -37,7 +37,7 @@ Fedora xfsprogs-devel For OverlayFS build and install: - - see https://github.com/hisilicon/overlayfs-progs + - see https://github.com/kmxz/overlayfs-tools RHEL or CentOS -------------- @@ -75,7 +75,7 @@ RHEL or CentOS - see https://github.com/markfasheh/ocfs2-tools For OverlayFS build and install: - - see https://github.com/hisilicon/overlayfs-progs + - see https://github.com/kmxz/overlayfs-tools SUSE Linux Enterprise or openSUSE --------------------------------- @@ -95,7 +95,7 @@ SUSE Linux Enterprise or openSUSE $ sudo zypper install xfsdump xfsprogs-devel For OverlayFS build and install: - - see https://github.com/hisilicon/overlayfs-progs + - see https://github.com/kmxz/overlayfs-tools Build and install test, libs and utils --------------------------------------
Overlayfs-tools and overlayfs-progs projects have been merged together. Signed-off-by: Vyacheslav Yurkov <uvv.mail@gmail.com> --- README | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)