| Message ID | 20230927040438.5589-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: sunxi: a83-mips-csi2: also select GENERIC_PHY | expand |
Hi Randy, Thanks for the patch. On Tue, Sep 26, 2023 at 09:04:38PM -0700, Randy Dunlap wrote: > When selecting GENERIC_PHY_MIPI_DPHY, also select GENERIC_PHY to > prevent kconfig warnings: > > WARNING: unmet direct dependencies detected for GENERIC_PHY_MIPI_DPHY > Depends on [n]: GENERIC_PHY [=n] > Selected by [y]: > - VIDEO_SUN8I_A83T_MIPI_CSI2 [=y] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && VIDEO_DEV [=y] && (ARCH_SUNXI || COMPILE_TEST [=y]) && PM [=y] && COMMON_CLK [=y] && RESET_CONTROLLER [=y] > > Fixes: 94d7fd9692b5 ("media: sunxi: Depend on GENERIC_PHY_MIPI_DPHY") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Closes: lore.kernel.org/r/ZQ/WS8HC1A3F0Qn8@rli9-mobl > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Sakari Ailus <sakari.ailus@linux.intel.com> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> > Cc: linux-media@vger.kernel.org > Cc: Chen-Yu Tsai <wens@csie.org> > Cc: Jernej Skrabec <jernej.skrabec@gmail.com> > Cc: Samuel Holland <samuel@sholland.org> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-sunxi@lists.linux.dev > --- > drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff -- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig > --- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig > +++ b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig > @@ -8,6 +8,7 @@ config VIDEO_SUN8I_A83T_MIPI_CSI2 > select VIDEO_V4L2_SUBDEV_API > select V4L2_FWNODE > select REGMAP_MMIO > + select GENERIC_PHY Could GENERIC_PHY_MIPI_DPHY select GENERIC_PHY instead of depending it? There seem to be a few other drivers that appear to have the same issue. > select GENERIC_PHY_MIPI_DPHY > help > Support for the Allwinner A83T MIPI CSI-2 controller and D-PHY.
On 9/27/23 03:48, Sakari Ailus wrote: > Hi Randy, > > Thanks for the patch. > > On Tue, Sep 26, 2023 at 09:04:38PM -0700, Randy Dunlap wrote: >> When selecting GENERIC_PHY_MIPI_DPHY, also select GENERIC_PHY to >> prevent kconfig warnings: >> >> WARNING: unmet direct dependencies detected for GENERIC_PHY_MIPI_DPHY >> Depends on [n]: GENERIC_PHY [=n] >> Selected by [y]: >> - VIDEO_SUN8I_A83T_MIPI_CSI2 [=y] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && VIDEO_DEV [=y] && (ARCH_SUNXI || COMPILE_TEST [=y]) && PM [=y] && COMMON_CLK [=y] && RESET_CONTROLLER [=y] >> >> Fixes: 94d7fd9692b5 ("media: sunxi: Depend on GENERIC_PHY_MIPI_DPHY") >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >> Reported-by: kernel test robot <lkp@intel.com> >> Closes: lore.kernel.org/r/ZQ/WS8HC1A3F0Qn8@rli9-mobl >> Cc: Arnd Bergmann <arnd@arndb.de> >> Cc: Sakari Ailus <sakari.ailus@linux.intel.com> >> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> >> Cc: linux-media@vger.kernel.org >> Cc: Chen-Yu Tsai <wens@csie.org> >> Cc: Jernej Skrabec <jernej.skrabec@gmail.com> >> Cc: Samuel Holland <samuel@sholland.org> >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-sunxi@lists.linux.dev >> --- >> drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff -- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig >> --- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig >> +++ b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig >> @@ -8,6 +8,7 @@ config VIDEO_SUN8I_A83T_MIPI_CSI2 >> select VIDEO_V4L2_SUBDEV_API >> select V4L2_FWNODE >> select REGMAP_MMIO >> + select GENERIC_PHY > > Could GENERIC_PHY_MIPI_DPHY select GENERIC_PHY instead of depending it? Yes, I don't see why not. Let's see what the PHY framework people have to say about it. Vinod, Kishon, do you see any reason that GENERIC_PHY_MIPI_DPHY could not select GENERIC_PHY instead of depending on it? > There seem to be a few other drivers that appear to have the same issue. Yes, I see 4 others that have the same issue. >> select GENERIC_PHY_MIPI_DPHY >> help >> Support for the Allwinner A83T MIPI CSI-2 controller and D-PHY. > ~Randy
diff -- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig --- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig +++ b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig @@ -8,6 +8,7 @@ config VIDEO_SUN8I_A83T_MIPI_CSI2 select VIDEO_V4L2_SUBDEV_API select V4L2_FWNODE select REGMAP_MMIO + select GENERIC_PHY select GENERIC_PHY_MIPI_DPHY help Support for the Allwinner A83T MIPI CSI-2 controller and D-PHY.
When selecting GENERIC_PHY_MIPI_DPHY, also select GENERIC_PHY to prevent kconfig warnings: WARNING: unmet direct dependencies detected for GENERIC_PHY_MIPI_DPHY Depends on [n]: GENERIC_PHY [=n] Selected by [y]: - VIDEO_SUN8I_A83T_MIPI_CSI2 [=y] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && VIDEO_DEV [=y] && (ARCH_SUNXI || COMPILE_TEST [=y]) && PM [=y] && COMMON_CLK [=y] && RESET_CONTROLLER [=y] Fixes: 94d7fd9692b5 ("media: sunxi: Depend on GENERIC_PHY_MIPI_DPHY") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: kernel test robot <lkp@intel.com> Closes: lore.kernel.org/r/ZQ/WS8HC1A3F0Qn8@rli9-mobl Cc: Arnd Bergmann <arnd@arndb.de> Cc: Sakari Ailus <sakari.ailus@linux.intel.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: linux-media@vger.kernel.org Cc: Chen-Yu Tsai <wens@csie.org> Cc: Jernej Skrabec <jernej.skrabec@gmail.com> Cc: Samuel Holland <samuel@sholland.org> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-sunxi@lists.linux.dev --- drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig | 1 + 1 file changed, 1 insertion(+)