Message ID | 20230922094044.28820-1-dinghao.liu@zju.edu.cn (mailing list archive) |
---|---|
State | Accepted |
Commit | caa0578c1d487d39e4bb947a1b4965417053b409 |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | ptp: ocp: Fix error handling in ptp_ocp_device_init | expand |
On 22/09/2023 10:40, Dinghao Liu wrote: > When device_add() fails, ptp_ocp_dev_release() will be called > after put_device(). Therefore, it seems that the > ptp_ocp_dev_release() before put_device() is redundant. > > Fixes: 773bda964921 ("ptp: ocp: Expose various resources on the timecard.") > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> Thanks! Reviewed-by: Vadim Feodrenko <vadim.fedorenko@linux.dev>
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Fri, 22 Sep 2023 17:40:44 +0800 you wrote: > When device_add() fails, ptp_ocp_dev_release() will be called > after put_device(). Therefore, it seems that the > ptp_ocp_dev_release() before put_device() is redundant. > > Fixes: 773bda964921 ("ptp: ocp: Expose various resources on the timecard.") > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> > > [...] Here is the summary with links: - ptp: ocp: Fix error handling in ptp_ocp_device_init https://git.kernel.org/netdev/net/c/caa0578c1d48 You are awesome, thank you!
diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c index 20a974ced8d6..a7a6947ab4bc 100644 --- a/drivers/ptp/ptp_ocp.c +++ b/drivers/ptp/ptp_ocp.c @@ -3998,7 +3998,6 @@ ptp_ocp_device_init(struct ptp_ocp *bp, struct pci_dev *pdev) return 0; out: - ptp_ocp_dev_release(&bp->dev); put_device(&bp->dev); return err; }
When device_add() fails, ptp_ocp_dev_release() will be called after put_device(). Therefore, it seems that the ptp_ocp_dev_release() before put_device() is redundant. Fixes: 773bda964921 ("ptp: ocp: Expose various resources on the timecard.") Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> --- drivers/ptp/ptp_ocp.c | 1 - 1 file changed, 1 deletion(-)