| Message ID | KL1PR01MB380907A7B0AD8A53727F87E2AEF7A@KL1PR01MB3809.apcprd01.prod.exchangelabs.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] media: platform: cros-ec: Add Taranza to the match table | expand |
On 14/09/2023 13:30, Ken Lin wrote: > Taranza has two HDMI ports which support CEC: > Port D is EC port 0 > Port B is EC port 1 > > Signed-off-by: Ken Lin <ken_lin5@hotmail.com> > --- > > Changes in v2: > Use a NULL-terminated conns array for the match table entry > --- > drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c > index 920aed0d1929..66e96abc9abf 100644 > --- a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c > +++ b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c > @@ -298,6 +298,7 @@ static const char *const fizz_conns[] = { "Port B", NULL }; > static const char *const dibbi_conns[] = { "Port D", "Port B", NULL }; > static const char *const constitution_conns[] = { "Port B", "Port A", NULL }; > static const char *const boxy_conns[] = { "Port D", NULL }; > +static const char *const taranza_conns[] = { "Port D", "Port B", NULL }; Just reuse dibbi_conns, just as is done with fizz_conns. Actually, what would be better is to rename these _conns arrays to something like: static const char *const port_db_conns[] = { "Port D", "Port B", NULL }; That's much cleaner IMHO. Can you post a small patch series? The first renames these conns arrays, the second adds Taranza support. Thank you! Hans > > static const struct cec_dmi_match cec_dmi_match_table[] = { > /* Google Fizz */ > @@ -322,6 +323,8 @@ static const struct cec_dmi_match cec_dmi_match_table[] = { > { "Google", "Constitution", "0000:00:02.0", constitution_conns }, > /* Google Boxy */ > { "Google", "Boxy", "0000:00:02.0", boxy_conns }, > + /* Google Taranza */ > + { "Google", "Taranza", "0000:00:02.0", taranza_conns }, > }; > > static struct device *cros_ec_cec_find_hdmi_dev(struct device *dev,
diff --git a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c index 920aed0d1929..66e96abc9abf 100644 --- a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c +++ b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c @@ -298,6 +298,7 @@ static const char *const fizz_conns[] = { "Port B", NULL }; static const char *const dibbi_conns[] = { "Port D", "Port B", NULL }; static const char *const constitution_conns[] = { "Port B", "Port A", NULL }; static const char *const boxy_conns[] = { "Port D", NULL }; +static const char *const taranza_conns[] = { "Port D", "Port B", NULL }; static const struct cec_dmi_match cec_dmi_match_table[] = { /* Google Fizz */ @@ -322,6 +323,8 @@ static const struct cec_dmi_match cec_dmi_match_table[] = { { "Google", "Constitution", "0000:00:02.0", constitution_conns }, /* Google Boxy */ { "Google", "Boxy", "0000:00:02.0", boxy_conns }, + /* Google Taranza */ + { "Google", "Taranza", "0000:00:02.0", taranza_conns }, }; static struct device *cros_ec_cec_find_hdmi_dev(struct device *dev,
Taranza has two HDMI ports which support CEC: Port D is EC port 0 Port B is EC port 1 Signed-off-by: Ken Lin <ken_lin5@hotmail.com> --- Changes in v2: Use a NULL-terminated conns array for the match table entry --- drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 3 +++ 1 file changed, 3 insertions(+)