| Message ID | 20230925095532.1984344-1-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | soc: Convert to platform remove callback returning void | expand |
On 25.09.2023 11:54, Uwe Kleine-König wrote: > Hello, > > this series converts all platform drivers below drivers/soc to use > .remove_new(). The motivation is to get rid of an integer return code > that is (mostly) ignored by the platform driver core and error prone on > the driver side. > > See commit 5c5a7680e67b ("platform: Provide a remove callback that > returns no value") for an extended explanation and the eventual goal. > Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org> # qcom Konrad
On Mon, 25 Sept 2023 at 09:55, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > > Hello, > > this series converts all platform drivers below drivers/soc to use > .remove_new(). The motivation is to get rid of an integer return code > that is (mostly) ignored by the platform driver core and error prone on > the driver side. > > See commit 5c5a7680e67b ("platform: Provide a remove callback that > returns no value") for an extended explanation and the eventual goal. > > As there is no single maintainer team for drivers/soc, I suggest the > individual maintainers to pick up "their" patches. I'd be happy if Arnd merged the lot at once. Arnd, what do you think? If that will be too messy then I understand. I have queued the aspeed ones locally and will push that out if we decide that's the best way to go. Thanks for doing this cleanup Uwe. Cheers, Joel
On Wed, Sep 27, 2023, at 04:25, Joel Stanley wrote: > On Mon, 25 Sept 2023 at 09:55, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: >> >> this series converts all platform drivers below drivers/soc to use >> .remove_new(). The motivation is to get rid of an integer return code >> that is (mostly) ignored by the platform driver core and error prone on >> the driver side. >> >> See commit 5c5a7680e67b ("platform: Provide a remove callback that >> returns no value") for an extended explanation and the eventual goal. >> >> As there is no single maintainer team for drivers/soc, I suggest the >> individual maintainers to pick up "their" patches. > > I'd be happy if Arnd merged the lot at once. Arnd, what do you think? > > If that will be too messy then I understand. I have queued the aspeed > ones locally and will push that out if we decide that's the best way > to go. The main downside of merging it all at once through the soc tree is that there may be patches that conflict with other work going on in individual drivers. What I'd suggest doing here is: - have platform maintainers pick up patches for their drivers if that is their preference for any reason - get a pull request from Uwe for the soc tree for anything that has not been picked up in one or two weeks from now Arnd
On Wed, Sep 27, 2023 at 10:43:16AM +0200, Arnd Bergmann wrote: > On Wed, Sep 27, 2023, at 04:25, Joel Stanley wrote: > > On Mon, 25 Sept 2023 at 09:55, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > >> > >> this series converts all platform drivers below drivers/soc to use > >> .remove_new(). The motivation is to get rid of an integer return code > >> that is (mostly) ignored by the platform driver core and error prone on > >> the driver side. > >> > >> See commit 5c5a7680e67b ("platform: Provide a remove callback that > >> returns no value") for an extended explanation and the eventual goal. > >> > >> As there is no single maintainer team for drivers/soc, I suggest the > >> individual maintainers to pick up "their" patches. > > > > I'd be happy if Arnd merged the lot at once. Arnd, what do you think? > > > > If that will be too messy then I understand. I have queued the aspeed > > ones locally and will push that out if we decide that's the best way > > to go. > > The main downside of merging it all at once through the soc tree > is that there may be patches that conflict with other work going on > in individual drivers. > > What I'd suggest doing here is: > > - have platform maintainers pick up patches for their drivers > if that is their preference for any reason > I'd prefer this for the qcom drivers at least, please let me know if you would like me to proceed. Regards, Bjorn > - get a pull request from Uwe for the soc tree for anything that has > not been picked up in one or two weeks from now > > Arnd
On Wed, Sep 27, 2023 at 04:01:58PM -0700, Bjorn Andersson wrote: > On Wed, Sep 27, 2023 at 10:43:16AM +0200, Arnd Bergmann wrote: > > On Wed, Sep 27, 2023, at 04:25, Joel Stanley wrote: > > > On Mon, 25 Sept 2023 at 09:55, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > > >> > > >> this series converts all platform drivers below drivers/soc to use > > >> .remove_new(). The motivation is to get rid of an integer return code > > >> that is (mostly) ignored by the platform driver core and error prone on > > >> the driver side. > > >> > > >> See commit 5c5a7680e67b ("platform: Provide a remove callback that > > >> returns no value") for an extended explanation and the eventual goal. > > >> > > >> As there is no single maintainer team for drivers/soc, I suggest the > > >> individual maintainers to pick up "their" patches. > > > > > > I'd be happy if Arnd merged the lot at once. Arnd, what do you think? > > > > > > If that will be too messy then I understand. I have queued the aspeed > > > ones locally and will push that out if we decide that's the best way > > > to go. > > > > The main downside of merging it all at once through the soc tree > > is that there may be patches that conflict with other work going on > > in individual drivers. > > > > What I'd suggest doing here is: > > > > - have platform maintainers pick up patches for their drivers > > if that is their preference for any reason > > I'd prefer this for the qcom drivers at least, please let me know if you > would like me to proceed. I can send a pull request as Arnd suggested. So iff you want the qcom drivers not be a part of that PR, just make sure they appear in next during the next week. :-) (I'm not sure if "this" in your last quoted sentence is "platform maintainers pick up" or "merging it all at once through the soc tree". I think you mean the former. Still if you don't want me to pick up the qcom patches and won't manage to make them appear in next via your tree, I ask you to tell me explicitly to skip these in my PR.) Best regards and thanks, Uwe
Hi Uwe Kleine-König, On Mon, 25 Sep 2023 11:54:51 +0200, Uwe Kleine-König wrote: > this series converts all platform drivers below drivers/soc to use > .remove_new(). The motivation is to get rid of an integer return code > that is (mostly) ignored by the platform driver core and error prone on > the driver side. > > See commit 5c5a7680e67b ("platform: Provide a remove callback that > returns no value") for an extended explanation and the eventual goal. > > [...] I have applied the following to branch ti-drivers-soc-next on [1]. Thank you! [33/40] soc/ti: k3-ringacc: Convert to platform remove callback returning void commit: f34b902c5ba67841902cd7f0e24e64bb82f69cb4 [34/40] soc/ti: knav_dma: Convert to platform remove callback returning void commit: 3af4ec7c7dd39a2c4618f6536b2e7b73a19be169 [35/40] soc/ti: knav_qmss_queue: Convert to platform remove callback returning void commit: af97160a0c5f1908c6f2830023fb93baac4451d3 [36/40] soc/ti: pm33xx: Convert to platform remove callback returning void commit: 9eb950e9fffc5337bfe1798cf89ce4d97a4f1221 [37/40] soc/ti: pruss: Convert to platform remove callback returning void commit: d183b20d340b7c098f44cb5c02f4ced01cfd0b16 [38/40] soc/ti: smartreflex: Convert to platform remove callback returning void commit: ba03aab9bfb4c9d456419da3891375d45c6bfe15 [39/40] soc/ti: wkup_m3_ipc: Convert to platform remove callback returning void commit: 82e83cb51c87b5bf3ab83f7c7b150c19400056c2 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. [1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
On Mon, 25 Sep 2023 11:54:51 +0200, Uwe Kleine-König wrote: > this series converts all platform drivers below drivers/soc to use > .remove_new(). The motivation is to get rid of an integer return code > that is (mostly) ignored by the platform driver core and error prone on > the driver side. > > See commit 5c5a7680e67b ("platform: Provide a remove callback that > returns no value") for an extended explanation and the eventual goal. > > [...] Applied, thanks! [18/40] soc/qcom: icc-bwmon: Convert to platform remove callback returning void commit: dd714c568ed4e6f79017be45077de71e9908af03 [19/40] soc/qcom: llcc-qcom: Convert to platform remove callback returning void commit: d85a9d18a58156fc8b5ab185e00e078adaaeefde [20/40] soc/qcom: ocmem: Convert to platform remove callback returning void commit: 0b742c498bcd7d215501b10fe9df72a16237735a [21/40] soc/qcom: pmic_glink: Convert to platform remove callback returning void commit: 4b3373e42dc2caa34394ac090c8c70bed49badd6 [22/40] soc/qcom: qcom_aoss: Convert to platform remove callback returning void commit: ffbe84a514f863a46a85c1e47b2b6d930b1b463e [23/40] soc/qcom: qcom_gsbi: Convert to platform remove callback returning void commit: 57b31729bd2c72b00d400106e18db91e9d95d3c3 [24/40] soc/qcom: qcom_stats: Convert to platform remove callback returning void commit: a47ff90bf2f93ce4ca99858948a74a0c10a2bc45 [25/40] soc/qcom: rmtfs_mem: Convert to platform remove callback returning void commit: 7c93da5b8b69d4e4e7270c33ba3206af43930e1d [26/40] soc/qcom: smem: Convert to platform remove callback returning void commit: 4b8dee9a34d51a61f60add996fae6a7140a20ae5 [27/40] soc/qcom: smp2p: Convert to platform remove callback returning void commit: 1cd966c2dc19654ed08c843e5c933db8c1349636 [28/40] soc/qcom: smsm: Convert to platform remove callback returning void commit: bdd7cc62cf69fe989557445d65d6c8cb2f956518 [29/40] soc/qcom: socinfo: Convert to platform remove callback returning void commit: c0989f7d1264b2b1885345a28a32fd5e1e61f9c7 Best regards,
Hello, this series converts all platform drivers below drivers/soc to use .remove_new(). The motivation is to get rid of an integer return code that is (mostly) ignored by the platform driver core and error prone on the driver side. See commit 5c5a7680e67b ("platform: Provide a remove callback that returns no value") for an extended explanation and the eventual goal. As there is no single maintainer team for drivers/soc, I suggest the individual maintainers to pick up "their" patches. There are no interdependencies between the patches, so that should work fine. As there are still quite a few drivers to convert in other areas than drivers/soc, I'm happy about every patch that makes it in and there is no need for further coordination. So even if there is a merge conflict with one patch until you apply or a subject prefix is suboptimal, please don't let you stop by negative feedback for other patches (unless it applies to "your" patches, too, of course). Best regards and thanks for considering, Uwe Uwe Kleine-König (40): soc/aspeed: aspeed-lpc-ctrl: Convert to platform remove callback returning void soc/aspeed: aspeed-lpc-snoop: Convert to platform remove callback returning void soc/aspeed: aspeed-p2a-ctrl: Convert to platform remove callback returning void soc/aspeed: aspeed-uart-routing: Convert to platform remove callback returning void soc/fsl: dpaa2-console: Convert to platform remove callback returning void soc/fsl: cpm: qmc: Convert to platform remove callback returning void soc/fsl: cpm: tsa: Convert to platform remove callback returning void soc/fujitsu: a64fx-diag: Convert to platform remove callback returning void soc/hisilicon: kunpeng_hccs: Convert to platform remove callback returning void soc/ixp4xx: ixp4xx-npe: Convert to platform remove callback returning void soc/ixp4xx: ixp4xx-qmgr: Convert to platform remove callback returning void soc/litex: litex_soc_ctrl: Convert to platform remove callback returning void soc/loongson: loongson2_guts: Convert to platform remove callback returning void soc/mediatek: mtk-devapc: Convert to platform remove callback returning void soc/mediatek: mtk-mmsys: Convert to platform remove callback returning void soc/microchip: mpfs-sys-controller: Convert to platform remove callback returning void soc/pxa: ssp: Convert to platform remove callback returning void soc/qcom: icc-bwmon: Convert to platform remove callback returning void soc/qcom: llcc-qcom: Convert to platform remove callback returning void soc/qcom: ocmem: Convert to platform remove callback returning void soc/qcom: pmic_glink: Convert to platform remove callback returning void soc/qcom: qcom_aoss: Convert to platform remove callback returning void soc/qcom: qcom_gsbi: Convert to platform remove callback returning void soc/qcom: qcom_stats: Convert to platform remove callback returning void soc/qcom: rmtfs_mem: Convert to platform remove callback returning void soc/qcom: smem: Convert to platform remove callback returning void soc/qcom: smp2p: Convert to platform remove callback returning void soc/qcom: smsm: Convert to platform remove callback returning void soc/qcom: socinfo: Convert to platform remove callback returning void soc/rockchip: io-domain: Convert to platform remove callback returning void soc/samsung: exynos-chipid: Convert to platform remove callback returning void soc/tegra: cbb: tegra194-cbb: Convert to platform remove callback returning void soc/ti: k3-ringacc: Convert to platform remove callback returning void soc/ti: knav_dma: Convert to platform remove callback returning void soc/ti: knav_qmss_queue: Convert to platform remove callback returning void soc/ti: pm33xx: Convert to platform remove callback returning void soc/ti: pruss: Convert to platform remove callback returning void soc/ti: smartreflex: Convert to platform remove callback returning void soc/ti: wkup_m3_ipc: Convert to platform remove callback returning void soc/xilinx: zynqmp_power: Convert to platform remove callback returning void drivers/soc/aspeed/aspeed-lpc-ctrl.c | 6 ++---- drivers/soc/aspeed/aspeed-lpc-snoop.c | 6 ++---- drivers/soc/aspeed/aspeed-p2a-ctrl.c | 6 ++---- drivers/soc/aspeed/aspeed-uart-routing.c | 6 ++---- drivers/soc/fsl/dpaa2-console.c | 6 ++---- drivers/soc/fsl/qe/qmc.c | 6 ++---- drivers/soc/fsl/qe/tsa.c | 5 ++--- drivers/soc/fujitsu/a64fx-diag.c | 6 ++---- drivers/soc/hisilicon/kunpeng_hccs.c | 6 ++---- drivers/soc/ixp4xx/ixp4xx-npe.c | 6 ++---- drivers/soc/ixp4xx/ixp4xx-qmgr.c | 5 ++--- drivers/soc/litex/litex_soc_ctrl.c | 5 ++--- drivers/soc/loongson/loongson2_guts.c | 6 ++---- drivers/soc/mediatek/mtk-devapc.c | 6 ++---- drivers/soc/mediatek/mtk-mmsys.c | 6 ++---- drivers/soc/microchip/mpfs-sys-controller.c | 6 ++---- drivers/soc/pxa/ssp.c | 6 ++---- drivers/soc/qcom/icc-bwmon.c | 6 ++---- drivers/soc/qcom/llcc-qcom.c | 5 ++--- drivers/soc/qcom/ocmem.c | 6 ++---- drivers/soc/qcom/pmic_glink.c | 6 ++---- drivers/soc/qcom/qcom_aoss.c | 6 ++---- drivers/soc/qcom/qcom_gsbi.c | 6 ++---- drivers/soc/qcom/qcom_stats.c | 6 ++---- drivers/soc/qcom/rmtfs_mem.c | 6 ++---- drivers/soc/qcom/smem.c | 6 ++---- drivers/soc/qcom/smp2p.c | 6 ++---- drivers/soc/qcom/smsm.c | 6 ++---- drivers/soc/qcom/socinfo.c | 6 ++---- drivers/soc/rockchip/io-domain.c | 6 ++---- drivers/soc/samsung/exynos-chipid.c | 6 ++---- drivers/soc/tegra/cbb/tegra194-cbb.c | 6 ++---- drivers/soc/ti/k3-ringacc.c | 5 ++--- drivers/soc/ti/knav_dma.c | 6 ++---- drivers/soc/ti/knav_qmss_queue.c | 5 ++--- drivers/soc/ti/pm33xx.c | 5 ++--- drivers/soc/ti/pruss.c | 6 ++---- drivers/soc/ti/smartreflex.c | 5 ++--- drivers/soc/ti/wkup_m3_ipc.c | 6 ++---- drivers/soc/xilinx/zynqmp_power.c | 6 ++---- 40 files changed, 80 insertions(+), 152 deletions(-) base-commit: 8fff9184d1b5810dca5dd1a02726d4f844af88fc