| Message ID | 20231002161350.64229-1-tmaimon77@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | usb: ChipIdea: add Nuvoton NPCM UDC support | expand |
On Mon, Oct 02, 2023 at 07:13:47PM +0300, Tomer Maimon wrote: > This patch set add USB device controller for the NPCM Baseboard > Management Controllers (BMC). > > NPCM UDC driver is a part of the USB ChipIdea driver. > > Adding CI_HDRC_FORCE_VBUS_ACTIVE_ALWAYS flag to modify the vbus_active > parameter to active in case the ChipIdea USB IP role is device-only and > there is no otgsc register. > > BMC NPCM7XX and BMC NPCM8XX has ten identical NPCM UDC modules, > > The NPCM UDC were tested on NPCM845 evaluation board. > > Addressed comments from: > - Krzysztof Kozlowski : https://www.spinics.net/lists/kernel/msg4951321.html Why is this a RESEND?
Hi Greg, Forgot to add in Acked-by: Peter Chen <peter.chen@kernel.org> in V3, Resend the patch set with the Ack. Should I do it differently? On Tue, 3 Oct 2023 at 09:51, Greg KH <gregkh@linuxfoundation.org> wrote: > > On Mon, Oct 02, 2023 at 07:13:47PM +0300, Tomer Maimon wrote: > > This patch set add USB device controller for the NPCM Baseboard > > Management Controllers (BMC). > > > > NPCM UDC driver is a part of the USB ChipIdea driver. > > > > Adding CI_HDRC_FORCE_VBUS_ACTIVE_ALWAYS flag to modify the vbus_active > > parameter to active in case the ChipIdea USB IP role is device-only and > > there is no otgsc register. > > > > BMC NPCM7XX and BMC NPCM8XX has ten identical NPCM UDC modules, > > > > The NPCM UDC were tested on NPCM845 evaluation board. > > > > Addressed comments from: > > - Krzysztof Kozlowski : https://www.spinics.net/lists/kernel/msg4951321.html > > Why is this a RESEND? > Thanks, Tomer
On Tue, Oct 03, 2023 at 09:56:47AM +0300, Tomer Maimon wrote: > Hi Greg, > > Forgot to add in Acked-by: Peter Chen <peter.chen@kernel.org> in V3, > Resend the patch set with the Ack. > > Should I do it differently? You need to tell me what the difference is, otherwise I would have no clue what to do, what would you do if you had to review all of these and try to figure out which ones to accept? Please send this as a v4. thanks, greg k-h
O.K. Thanks a lot Tomer On Tue, 3 Oct 2023 at 10:05, Greg KH <gregkh@linuxfoundation.org> wrote: > > On Tue, Oct 03, 2023 at 09:56:47AM +0300, Tomer Maimon wrote: > > Hi Greg, > > > > Forgot to add in Acked-by: Peter Chen <peter.chen@kernel.org> in V3, > > Resend the patch set with the Ack. > > > > Should I do it differently? > > You need to tell me what the difference is, otherwise I would have no > clue what to do, what would you do if you had to review all of these and > try to figure out which ones to accept? > > Please send this as a v4. > > thanks, > > greg k-h
On 03/10/2023 08:56, Tomer Maimon wrote: > Hi Greg, > > Forgot to add in Acked-by: Peter Chen <peter.chen@kernel.org> in V3, > Resend the patch set with the Ack. > > Should I do it differently? If it is RESEND after some time (min. 2 weeks), then it is fine. If you added tags or changed something, make a new version. If you resend for any other reason (assuming resend is valid), please mention shortly why do you resend (e.g. "My company email servers maybe blocked it, so resending without changes"). Best regards, Krzysztof
Hi Krzysztof, Appreciate your clarifications Thanks, Tomer On Tue, 3 Oct 2023 at 11:32, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 03/10/2023 08:56, Tomer Maimon wrote: > > Hi Greg, > > > > Forgot to add in Acked-by: Peter Chen <peter.chen@kernel.org> in V3, > > Resend the patch set with the Ack. > > > > Should I do it differently? > > If it is RESEND after some time (min. 2 weeks), then it is fine. If you > added tags or changed something, make a new version. If you resend for > any other reason (assuming resend is valid), please mention shortly why > do you resend (e.g. "My company email servers maybe blocked it, so > resending without changes"). > > Best regards, > Krzysztof >