| Message ID | 20230923134904.3627402-10-vladimir.oltean@nxp.com (mailing list archive) |
|---|---|
| State | RFC |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add C72/C73 copper backplane support for LX2160 | expand |
On Sat, Sep 23, 2023 at 04:48:58PM +0300, Vladimir Oltean wrote: > Allow driver code to print stuff like the resolved link mode to the > kernel log, by giving it access to the link_mode_names[] ethtool > internal array which already holds this info. Looks good to me. > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Thanks!
On 9/23/2023 6:48 AM, Vladimir Oltean wrote: > Allow driver code to print stuff like the resolved link mode to the > kernel log, by giving it access to the link_mode_names[] ethtool > internal array which already holds this info. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h index 62b61527bcc4..7b144f2b7dfd 100644 --- a/include/linux/ethtool.h +++ b/include/linux/ethtool.h @@ -988,6 +988,12 @@ void ethtool_params_from_link_mode(struct ethtool_link_ksettings *link_ksettings, enum ethtool_link_mode_bit_indices link_mode); +/** + * ethtool_link_mode_str - Get name of a given link mode, in string format + * @link_mode: the link mode represented in integer format + */ +const char *ethtool_link_mode_str(enum ethtool_link_mode_bit_indices link_mode); + /** * ethtool_get_phc_vclocks - Derive phc vclocks information, and caller * is responsible to free memory of vclock_index diff --git a/net/ethtool/common.c b/net/ethtool/common.c index 2b3ddea465af..9a79548adb68 100644 --- a/net/ethtool/common.c +++ b/net/ethtool/common.c @@ -691,3 +691,9 @@ ethtool_params_from_link_mode(struct ethtool_link_ksettings *link_ksettings, link_ksettings->base.duplex = link_info->duplex; } EXPORT_SYMBOL_GPL(ethtool_params_from_link_mode); + +const char *ethtool_link_mode_str(enum ethtool_link_mode_bit_indices link_mode) +{ + return link_mode_names[link_mode]; +} +EXPORT_SYMBOL(ethtool_link_mode_str);
Allow driver code to print stuff like the resolved link mode to the kernel log, by giving it access to the link_mode_names[] ethtool internal array which already holds this info. Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> --- v1->v2: patch is new include/linux/ethtool.h | 6 ++++++ net/ethtool/common.c | 6 ++++++ 2 files changed, 12 insertions(+)