| Message ID | 20231003110130.229711-3-tmaimon77@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: ChipIdea: add Nuvoton NPCM UDC support | expand |
On 03/10/2023 13:01, Tomer Maimon wrote: > Add a compatible string for Nuvoton BMC NPCM750 and Nuvoton BMC NPCM845. > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > --- > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > index 1394557517b1..a9e173432002 100644 > --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > @@ -16,6 +16,8 @@ properties: > - enum: > - chipidea,usb2 > - lsi,zevio-usb > + - nuvoton,npcm750-udc > + - nuvoton,npcm845-udc Your driver clearly suggests these are compatible. If they are not, why commit msg does no explain anything here? Best regards, Krzysztof
Hi Krzysztof, Thanks for your comment On Wed, 4 Oct 2023 at 11:03, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 03/10/2023 13:01, Tomer Maimon wrote: > > Add a compatible string for Nuvoton BMC NPCM750 and Nuvoton BMC NPCM845. > > > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > > --- > > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > > index 1394557517b1..a9e173432002 100644 > > --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > > @@ -16,6 +16,8 @@ properties: > > - enum: > > - chipidea,usb2 > > - lsi,zevio-usb > > + - nuvoton,npcm750-udc > > + - nuvoton,npcm845-udc > > Your driver clearly suggests these are compatible. If they are not, why > commit msg does no explain anything here? Do you mean to add nuvoton,npcmxxx-udc as described below to the end of the compatible property? - items: - enum: - nuvoton,npcm845-udc - const: nuvoton,npcm750-udc > > Best regards, > Krzysztof > Best regards, Tomer
On 05/10/2023 12:46, Tomer Maimon wrote: > Hi Krzysztof, > > Thanks for your comment > > On Wed, 4 Oct 2023 at 11:03, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 03/10/2023 13:01, Tomer Maimon wrote: >>> Add a compatible string for Nuvoton BMC NPCM750 and Nuvoton BMC NPCM845. >>> >>> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> >>> --- >>> Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml >>> index 1394557517b1..a9e173432002 100644 >>> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml >>> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml >>> @@ -16,6 +16,8 @@ properties: >>> - enum: >>> - chipidea,usb2 >>> - lsi,zevio-usb >>> + - nuvoton,npcm750-udc >>> + - nuvoton,npcm845-udc >> >> Your driver clearly suggests these are compatible. If they are not, why >> commit msg does no explain anything here? > Do you mean to add nuvoton,npcmxxx-udc as described below to the end > of the compatible property? > - items: > - enum: > - nuvoton,npcm845-udc > - const: nuvoton,npcm750-udc For the 845 yes. Of course you also need enum entry for 750. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml index 1394557517b1..a9e173432002 100644 --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml @@ -16,6 +16,8 @@ properties: - enum: - chipidea,usb2 - lsi,zevio-usb + - nuvoton,npcm750-udc + - nuvoton,npcm845-udc - nvidia,tegra20-ehci - nvidia,tegra20-udc - nvidia,tegra30-ehci @@ -388,6 +390,8 @@ allOf: enum: - chipidea,usb2 - lsi,zevio-usb + - nuvoton,npcm750-udc + - nuvoton,npcm845-udc - nvidia,tegra20-udc - nvidia,tegra30-udc - nvidia,tegra114-udc
Add a compatible string for Nuvoton BMC NPCM750 and Nuvoton BMC NPCM845. Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> --- Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 4 ++++ 1 file changed, 4 insertions(+)