[v4,0/2] platform/x86: Fix reference leaks

Message

Armin Wolf Sept. 25, 2023, 2:28 p.m. UTC

If a duplicate attribute is found using kset_find_obj(), a reference
to that attribute is returned which needs to be disposed accordingly
using kobject_put(). This issue likely first appeared inside the
dell-wmi-sysman driver, see
commit 7295a996fdab ("platform/x86: dell-sysman: Fix reference leak").
However, it also seems that the bug was copied from this driver into
the think-lmi and hp-bioscfg drivers. Maybe a more abstract
fw_attr_class could prevent such issues in the future by abstracting
away the kobject handling?

Armin Wolf (2):
  platform/x86: think-lmi: Fix reference leak
  platform/x86: hp-bioscfg: Fix reference leak

 drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 14 ++++++++----
 drivers/platform/x86/think-lmi.c             | 24 ++++++++++++++++----
 2 files changed, 30 insertions(+), 8 deletions(-)

--
2.39.2

Comments

Hans de Goede Oct. 4, 2023, 9:55 a.m. UTC | #1

Hi,

On 9/25/23 16:28, Armin Wolf wrote:
> If a duplicate attribute is found using kset_find_obj(), a reference
> to that attribute is returned which needs to be disposed accordingly
> using kobject_put(). This issue likely first appeared inside the
> dell-wmi-sysman driver, see
> commit 7295a996fdab ("platform/x86: dell-sysman: Fix reference leak").
> However, it also seems that the bug was copied from this driver into
> the think-lmi and hp-bioscfg drivers. Maybe a more abstract
> fw_attr_class could prevent such issues in the future by abstracting
> away the kobject handling?
> 
> Armin Wolf (2):
>   platform/x86: think-lmi: Fix reference leak
>   platform/x86: hp-bioscfg: Fix reference leak

Thank you for your patch/series, I've applied this patch
(series) to the pdx86 fixes branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes

Note it will show up in the pdx86 fixes branch once I've pushed
my local branch there, which might take a while.

I will include this patch in my next fixes pull-req to Linus
for the current kernel development cycle.

Regards,

Hans




>  drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 14 ++++++++----
>  drivers/platform/x86/think-lmi.c             | 24 ++++++++++++++++----
>  2 files changed, 30 insertions(+), 8 deletions(-)
> 
> --
> 2.39.2
>