mbox series

[0/3] drm/i915: nuke i915->gt0

Message ID cover.1696236329.git.jani.nikula@intel.com (mailing list archive)
Headers show
Series drm/i915: nuke i915->gt0 | expand

Message

Jani Nikula Oct. 2, 2023, 8:47 a.m. UTC
Chopping up [1] to more digestable pieces. Start off with nuking
i915->gt0.

[1] https://patchwork.freedesktop.org/series/124418/

Jani Nikula (3):
  drm/i915/mocs: use to_gt() instead of direct &i915->gt
  drm/i915: allocate i915->gt0 dynamically
  drm/i915/gt: remove i915->gt0 in favour of i915->gt[0]

 drivers/gpu/drm/i915/gt/intel_gt.c               | 10 +++++++---
 drivers/gpu/drm/i915/gt/intel_mocs.c             |  4 ++--
 drivers/gpu/drm/i915/i915_drv.h                  | 10 ++--------
 drivers/gpu/drm/i915/selftests/mock_gem_device.c |  1 -
 4 files changed, 11 insertions(+), 14 deletions(-)

Comments

Andi Shyti Oct. 2, 2023, 2:04 p.m. UTC | #1
Hi Jani,

adding a few folks in Cc for some extra eyes on this series.

On Mon, Oct 02, 2023 at 11:47:01AM +0300, Jani Nikula wrote:
> Chopping up [1] to more digestable pieces. Start off with nuking
> i915->gt0.
> 
> [1] https://patchwork.freedesktop.org/series/124418/
> 
> Jani Nikula (3):
>   drm/i915/mocs: use to_gt() instead of direct &i915->gt
>   drm/i915: allocate i915->gt0 dynamically
>   drm/i915/gt: remove i915->gt0 in favour of i915->gt[0]
> 
>  drivers/gpu/drm/i915/gt/intel_gt.c               | 10 +++++++---
>  drivers/gpu/drm/i915/gt/intel_mocs.c             |  4 ++--
>  drivers/gpu/drm/i915/i915_drv.h                  | 10 ++--------
>  drivers/gpu/drm/i915/selftests/mock_gem_device.c |  1 -
>  4 files changed, 11 insertions(+), 14 deletions(-)

Michal, Michal and Tomasz, can you please check here?

Thanks,
Andi
Andi Shyti Oct. 2, 2023, 2:40 p.m. UTC | #2
Hi Jani,

> adding a few folks in Cc for some extra eyes on this series.
> 
> On Mon, Oct 02, 2023 at 11:47:01AM +0300, Jani Nikula wrote:
> > Chopping up [1] to more digestable pieces. Start off with nuking
> > i915->gt0.
> > 
> > [1] https://patchwork.freedesktop.org/series/124418/
> > 
> > Jani Nikula (3):
> >   drm/i915/mocs: use to_gt() instead of direct &i915->gt
> >   drm/i915: allocate i915->gt0 dynamically
> >   drm/i915/gt: remove i915->gt0 in favour of i915->gt[0]
> > 
> >  drivers/gpu/drm/i915/gt/intel_gt.c               | 10 +++++++---
> >  drivers/gpu/drm/i915/gt/intel_mocs.c             |  4 ++--
> >  drivers/gpu/drm/i915/i915_drv.h                  | 10 ++--------
> >  drivers/gpu/drm/i915/selftests/mock_gem_device.c |  1 -
> >  4 files changed, 11 insertions(+), 14 deletions(-)
> 
> Michal, Michal and Tomasz, can you please check here?

please don't merge this patch without first receiving a feedback
by the the guys I Cc'ed.

Thanks,
Andi
Michał Winiarski Oct. 2, 2023, 5:18 p.m. UTC | #3
On Mon, Oct 02, 2023 at 04:04:51PM +0200, Andi Shyti wrote:
> Hi Jani,
> 
> adding a few folks in Cc for some extra eyes on this series.
> 
> On Mon, Oct 02, 2023 at 11:47:01AM +0300, Jani Nikula wrote:
> > Chopping up [1] to more digestable pieces. Start off with nuking
> > i915->gt0.
> > 
> > [1] https://patchwork.freedesktop.org/series/124418/
> > 
> > Jani Nikula (3):
> >   drm/i915/mocs: use to_gt() instead of direct &i915->gt
> >   drm/i915: allocate i915->gt0 dynamically
> >   drm/i915/gt: remove i915->gt0 in favour of i915->gt[0]
> > 
> >  drivers/gpu/drm/i915/gt/intel_gt.c               | 10 +++++++---
> >  drivers/gpu/drm/i915/gt/intel_mocs.c             |  4 ++--
> >  drivers/gpu/drm/i915/i915_drv.h                  | 10 ++--------
> >  drivers/gpu/drm/i915/selftests/mock_gem_device.c |  1 -
> >  4 files changed, 11 insertions(+), 14 deletions(-)
> 
> Michal, Michal and Tomasz, can you please check here?
> 
> Thanks,
> Andi

Acked-by: Michał Winiarski <michal.winiarski@intel.com>

-Michał
Jani Nikula Oct. 4, 2023, 3:33 p.m. UTC | #4
On Mon, 02 Oct 2023, Andi Shyti <andi.shyti@linux.intel.com> wrote:
> Hi Jani,
>
> adding a few folks in Cc for some extra eyes on this series.

Thanks for the reviews and acks, pushed to drm-intel-next.

drm-intel-next instead of drm-intel-gt-next because of the changes in
i915_drv.h, and it's easier to sync from din to dign than vice versa.

BR,
Jani.


>
> On Mon, Oct 02, 2023 at 11:47:01AM +0300, Jani Nikula wrote:
>> Chopping up [1] to more digestable pieces. Start off with nuking
>> i915->gt0.
>> 
>> [1] https://patchwork.freedesktop.org/series/124418/
>> 
>> Jani Nikula (3):
>>   drm/i915/mocs: use to_gt() instead of direct &i915->gt
>>   drm/i915: allocate i915->gt0 dynamically
>>   drm/i915/gt: remove i915->gt0 in favour of i915->gt[0]
>> 
>>  drivers/gpu/drm/i915/gt/intel_gt.c               | 10 +++++++---
>>  drivers/gpu/drm/i915/gt/intel_mocs.c             |  4 ++--
>>  drivers/gpu/drm/i915/i915_drv.h                  | 10 ++--------
>>  drivers/gpu/drm/i915/selftests/mock_gem_device.c |  1 -
>>  4 files changed, 11 insertions(+), 14 deletions(-)
>
> Michal, Michal and Tomasz, can you please check here?
>
> Thanks,
> Andi