Message ID | 20231010151709.4104747-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
---|---|
Headers | show |
Series | hte: Improve GPIO handling and other cleanups | expand |
On Tue, Oct 10, 2023 at 5:18 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > This is a series provides a new API to GPIO library (so far only > available in the GPIO tree), and respective update to the Tegra > HTE driver. On top a couple of other cleaups (patches 3 & 4, they > can be applied separately). > > Patch 2 inherited tags from its respective discussion thread [1], > but I believe the Tested-by needs to be confirmed again. > > Due to dependencies this either should be applied to the GPIO tree, > or to the HTE when GPIO updates land the upstream (optionally with > the first patch be applied even now to the GPIO tree independently). > > Another option is to have an immutable branch or tag, but I assume > that was discussed and rejected (?) in [1]. The series looks good to me. I'd like to take patches 1 and 2 through the GPIO tree once v2 is out. This way we could potentially remove gpiochip_find() for v6.7 already. Bart > > Link: https://lore.kernel.org/linux-gpio/20230905185309.131295-15-brgl@bgdev.pl/ [1] > Cc: Dipen Patel <dipenp@nvidia.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > > Andy Shevchenko (3): > gpiolib: provide gpio_device_find_by_fwnode() > hte: tegra194: Remove redundant dev_err() > hte: tegra194: Switch to LATE_SIMPLE_DEV_PM_OPS() > > Bartosz Golaszewski (1): > hte: tegra194: don't access struct gpio_chip > > drivers/gpio/gpiolib.c | 20 ++++++++++++++++ > drivers/hte/hte-tegra194.c | 46 +++++++++++++++++++------------------ > include/linux/gpio/driver.h | 1 + > 3 files changed, 45 insertions(+), 22 deletions(-) > > -- > 2.40.0.1.gaa8946217a0b >
On Wed, Oct 11, 2023 at 11:33:51AM +0200, Bartosz Golaszewski wrote: > On Tue, Oct 10, 2023 at 5:18 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > This is a series provides a new API to GPIO library (so far only > > available in the GPIO tree), and respective update to the Tegra > > HTE driver. On top a couple of other cleaups (patches 3 & 4, they > > can be applied separately). > > > > Patch 2 inherited tags from its respective discussion thread [1], > > but I believe the Tested-by needs to be confirmed again. > > > > Due to dependencies this either should be applied to the GPIO tree, > > or to the HTE when GPIO updates land the upstream (optionally with > > the first patch be applied even now to the GPIO tree independently). > > > > Another option is to have an immutable branch or tag, but I assume > > that was discussed and rejected (?) in [1]. > > The series looks good to me. I'd like to take patches 1 and 2 through > the GPIO tree once v2 is out. This way we could potentially remove > gpiochip_find() for v6.7 already. It would be nice to see it being removed sooner than later! I'm waiting for the test results by Dipen, I'll send the v2 ASAP if tests pass.
On Tue, Oct 10, 2023 at 5:18 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > This is a series provides a new API to GPIO library (so far only > available in the GPIO tree), and respective update to the Tegra > HTE driver. On top a couple of other cleaups (patches 3 & 4, they > can be applied separately). > > Patch 2 inherited tags from its respective discussion thread [1], > but I believe the Tested-by needs to be confirmed again. > > Due to dependencies this either should be applied to the GPIO tree, > or to the HTE when GPIO updates land the upstream (optionally with > the first patch be applied even now to the GPIO tree independently). > > Another option is to have an immutable branch or tag, but I assume > that was discussed and rejected (?) in [1]. > > Link: https://lore.kernel.org/linux-gpio/20230905185309.131295-15-brgl@bgdev.pl/ [1] > Cc: Dipen Patel <dipenp@nvidia.com> > Cc: Linus Walleij <linus.walleij@linaro.org> This is good stuff. The series: Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On 10/11/23 3:06 AM, Andy Shevchenko wrote: > On Wed, Oct 11, 2023 at 11:33:51AM +0200, Bartosz Golaszewski wrote: >> On Tue, Oct 10, 2023 at 5:18 PM Andy Shevchenko >> <andriy.shevchenko@linux.intel.com> wrote: >>> >>> This is a series provides a new API to GPIO library (so far only >>> available in the GPIO tree), and respective update to the Tegra >>> HTE driver. On top a couple of other cleaups (patches 3 & 4, they >>> can be applied separately). >>> >>> Patch 2 inherited tags from its respective discussion thread [1], >>> but I believe the Tested-by needs to be confirmed again. >>> >>> Due to dependencies this either should be applied to the GPIO tree, >>> or to the HTE when GPIO updates land the upstream (optionally with >>> the first patch be applied even now to the GPIO tree independently). >>> >>> Another option is to have an immutable branch or tag, but I assume >>> that was discussed and rejected (?) in [1]. >> >> The series looks good to me. I'd like to take patches 1 and 2 through >> the GPIO tree once v2 is out. This way we could potentially remove >> gpiochip_find() for v6.7 already. > > It would be nice to see it being removed sooner than later! > I'm waiting for the test results by Dipen, I'll send the v2 > ASAP if tests pass. > Reviewed-by: Dipen Patel <dipenp@nvidia.com> After correcting typo manually Tested-by: Dipen Patel <dipenp@nvidia.com>