| Message ID | 20230915001019.2862964-1-robert.hancock@calian.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Xilinx XADC fixes | expand |
+Conall On 9/15/23 02:10, Robert Hancock wrote: > Fixes for a couple of issues in the Xilinx XADC driver: one where > preconfigured temperature/voltage thresholds were being clobbered and > potentially breaking overtemperature shutdown, and another for inaccurate > temperature readings on UltraScale family devices. > > Changed since v2: Updated to also remove disabling XADC alarm bits. > > Robert Hancock (2): > iio: adc: xilinx-xadc: Don't clobber preset voltage/temperature > thresholds > iio: adc: xilinx-xadc: Correct temperature offset/scale for UltraScale > > drivers/iio/adc/xilinx-xadc-core.c | 39 +++++++++++------------------- > drivers/iio/adc/xilinx-xadc.h | 2 ++ > 2 files changed, 16 insertions(+), 25 deletions(-) > Conall: Please test and review. Thanks, Michal
On Fri, 15 Sep 2023 08:52:49 +0200 Michal Simek <michal.simek@amd.com> wrote: > +Conall > > On 9/15/23 02:10, Robert Hancock wrote: > > Fixes for a couple of issues in the Xilinx XADC driver: one where > > preconfigured temperature/voltage thresholds were being clobbered and > > potentially breaking overtemperature shutdown, and another for inaccurate > > temperature readings on UltraScale family devices. > > > > Changed since v2: Updated to also remove disabling XADC alarm bits. > > > > Robert Hancock (2): > > iio: adc: xilinx-xadc: Don't clobber preset voltage/temperature > > thresholds > > iio: adc: xilinx-xadc: Correct temperature offset/scale for UltraScale > > > > drivers/iio/adc/xilinx-xadc-core.c | 39 +++++++++++------------------- > > drivers/iio/adc/xilinx-xadc.h | 2 ++ > > 2 files changed, 16 insertions(+), 25 deletions(-) > > > > Conall: Please test and review. I'm sitting on this one until I hear back. No huge rush, but if you can estimate when you'll get to this I know to leave you alone until after that! Jonathan > > Thanks, > Michal
On Sun, 24 Sep 2023 17:32:10 +0100 Jonathan Cameron <jic23@kernel.org> wrote: > On Fri, 15 Sep 2023 08:52:49 +0200 > Michal Simek <michal.simek@amd.com> wrote: > > > +Conall > > > > On 9/15/23 02:10, Robert Hancock wrote: > > > Fixes for a couple of issues in the Xilinx XADC driver: one where > > > preconfigured temperature/voltage thresholds were being clobbered and > > > potentially breaking overtemperature shutdown, and another for inaccurate > > > temperature readings on UltraScale family devices. > > > > > > Changed since v2: Updated to also remove disabling XADC alarm bits. > > > > > > Robert Hancock (2): > > > iio: adc: xilinx-xadc: Don't clobber preset voltage/temperature > > > thresholds > > > iio: adc: xilinx-xadc: Correct temperature offset/scale for UltraScale > > > > > > drivers/iio/adc/xilinx-xadc-core.c | 39 +++++++++++------------------- > > > drivers/iio/adc/xilinx-xadc.h | 2 ++ > > > 2 files changed, 16 insertions(+), 25 deletions(-) > > > > > > > Conall: Please test and review. > > I'm sitting on this one until I hear back. No huge rush, but if you > can estimate when you'll get to this I know to leave you alone until after > that! I'll ask one more time, then probably just assume these are fine and apply. So Conall, have you had a chance to look at these? Thanks, Jonathan > > Jonathan > > > > > Thanks, > > Michal >
[AMD Official Use Only - General] Acked-by: O'Griofa, Conall <conall.ogriofa@amd.com> Tested-by: O'Griofa, Conall <conall.ogriofa@amd.com> Hi Jonathan, Thanks for the patches, changes look good, I have tested on board and not seen any issues from my testing. Cheers, Conall. > -----Original Message----- > From: Jonathan Cameron <jic23@kernel.org> > Sent: Tuesday, October 10, 2023 5:19 PM > To: Simek, Michal <michal.simek@amd.com> > Cc: Robert Hancock <robert.hancock@calian.com>; O'Griofa, Conall > <conall.ogriofa@amd.com>; Lars-Peter Clausen <lars@metafoo.de>; linux- > iio@vger.kernel.org; linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH v2 0/2] Xilinx XADC fixes > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On Sun, 24 Sep 2023 17:32:10 +0100 > Jonathan Cameron <jic23@kernel.org> wrote: > > > On Fri, 15 Sep 2023 08:52:49 +0200 > > Michal Simek <michal.simek@amd.com> wrote: > > > > > +Conall > > > > > > On 9/15/23 02:10, Robert Hancock wrote: > > > > Fixes for a couple of issues in the Xilinx XADC driver: one where > > > > preconfigured temperature/voltage thresholds were being clobbered > > > > and potentially breaking overtemperature shutdown, and another for > > > > inaccurate temperature readings on UltraScale family devices. > > > > > > > > Changed since v2: Updated to also remove disabling XADC alarm bits. > > > > > > > > Robert Hancock (2): > > > > iio: adc: xilinx-xadc: Don't clobber preset voltage/temperature > > > > thresholds > > > > iio: adc: xilinx-xadc: Correct temperature offset/scale for > > > > UltraScale > > > > > > > > drivers/iio/adc/xilinx-xadc-core.c | 39 +++++++++++------------------- > > > > drivers/iio/adc/xilinx-xadc.h | 2 ++ > > > > 2 files changed, 16 insertions(+), 25 deletions(-) > > > > > > > > > > Conall: Please test and review. > > > > I'm sitting on this one until I hear back. No huge rush, but if you > > can estimate when you'll get to this I know to leave you alone until > > after that! > > I'll ask one more time, then probably just assume these are fine and apply. > > So Conall, have you had a chance to look at these? > > Thanks, > > Jonathan > > > > > Jonathan > > > > > > > > Thanks, > > > Michal > >
On Thu, 12 Oct 2023 09:53:44 +0000 "O'Griofa, Conall" <conall.ogriofa@amd.com> wrote: > [AMD Official Use Only - General] > > Acked-by: O'Griofa, Conall <conall.ogriofa@amd.com> > Tested-by: O'Griofa, Conall <conall.ogriofa@amd.com> > > Hi Jonathan, > > Thanks for the patches, changes look good, I have tested on board and not seen any issues from my testing. Great. Applied to the fixes-togreg branch of iio.git. thanks, Jonathan > > Cheers, > Conall. > > -----Original Message----- > > From: Jonathan Cameron <jic23@kernel.org> > > Sent: Tuesday, October 10, 2023 5:19 PM > > To: Simek, Michal <michal.simek@amd.com> > > Cc: Robert Hancock <robert.hancock@calian.com>; O'Griofa, Conall > > <conall.ogriofa@amd.com>; Lars-Peter Clausen <lars@metafoo.de>; linux- > > iio@vger.kernel.org; linux-arm-kernel@lists.infradead.org > > Subject: Re: [PATCH v2 0/2] Xilinx XADC fixes > > > > Caution: This message originated from an External Source. Use proper caution > > when opening attachments, clicking links, or responding. > > > > > > On Sun, 24 Sep 2023 17:32:10 +0100 > > Jonathan Cameron <jic23@kernel.org> wrote: > > > > > On Fri, 15 Sep 2023 08:52:49 +0200 > > > Michal Simek <michal.simek@amd.com> wrote: > > > > > > > +Conall > > > > > > > > On 9/15/23 02:10, Robert Hancock wrote: > > > > > Fixes for a couple of issues in the Xilinx XADC driver: one where > > > > > preconfigured temperature/voltage thresholds were being clobbered > > > > > and potentially breaking overtemperature shutdown, and another for > > > > > inaccurate temperature readings on UltraScale family devices. > > > > > > > > > > Changed since v2: Updated to also remove disabling XADC alarm bits. > > > > > > > > > > Robert Hancock (2): > > > > > iio: adc: xilinx-xadc: Don't clobber preset voltage/temperature > > > > > thresholds > > > > > iio: adc: xilinx-xadc: Correct temperature offset/scale for > > > > > UltraScale > > > > > > > > > > drivers/iio/adc/xilinx-xadc-core.c | 39 +++++++++++------------------- > > > > > drivers/iio/adc/xilinx-xadc.h | 2 ++ > > > > > 2 files changed, 16 insertions(+), 25 deletions(-) > > > > > > > > > > > > > Conall: Please test and review. > > > > > > I'm sitting on this one until I hear back. No huge rush, but if you > > > can estimate when you'll get to this I know to leave you alone until > > > after that! > > > > I'll ask one more time, then probably just assume these are fine and apply. > > > > So Conall, have you had a chance to look at these? > > > > Thanks, > > > > Jonathan > > > > > > > > Jonathan > > > > > > > > > > > Thanks, > > > > Michal > > > >
Fixes for a couple of issues in the Xilinx XADC driver: one where preconfigured temperature/voltage thresholds were being clobbered and potentially breaking overtemperature shutdown, and another for inaccurate temperature readings on UltraScale family devices. Changed since v2: Updated to also remove disabling XADC alarm bits. Robert Hancock (2): iio: adc: xilinx-xadc: Don't clobber preset voltage/temperature thresholds iio: adc: xilinx-xadc: Correct temperature offset/scale for UltraScale drivers/iio/adc/xilinx-xadc-core.c | 39 +++++++++++------------------- drivers/iio/adc/xilinx-xadc.h | 2 ++ 2 files changed, 16 insertions(+), 25 deletions(-)