Message ID | 20231011092728.105904-1-xuanzhuo@linux.alibaba.com (mailing list archive) |
---|---|
Headers | show |
Series | virtio-net: support AF_XDP zero copy | expand |
On Wed, 11 Oct 2023 17:27:06 +0800 Xuan Zhuo wrote: > ## AF_XDP > > XDP socket(AF_XDP) is an excellent bypass kernel network framework. The zero > copy feature of xsk (XDP socket) needs to be supported by the driver. The > performance of zero copy is very good. mlx5 and intel ixgbe already support > this feature, This patch set allows virtio-net to support xsk's zerocopy xmit > feature. You're moving the driver and adding a major feature. This really needs to go via net or bpf. If you have dependencies in other trees please wait for after the merge window.
On Wed, 11 Oct 2023 10:00:57 -0700, Jakub Kicinski <kuba@kernel.org> wrote: > On Wed, 11 Oct 2023 17:27:06 +0800 Xuan Zhuo wrote: > > ## AF_XDP > > > > XDP socket(AF_XDP) is an excellent bypass kernel network framework. The zero > > copy feature of xsk (XDP socket) needs to be supported by the driver. The > > performance of zero copy is very good. mlx5 and intel ixgbe already support > > this feature, This patch set allows virtio-net to support xsk's zerocopy xmit > > feature. > > You're moving the driver and adding a major feature. > This really needs to go via net or bpf. > If you have dependencies in other trees please wait for > after the merge window. If so, I can remove the first two commits. Then, the sq uses the premapped mode by default. And we can use the api virtqueue_dma_map_single_attrs to replace the virtqueue_dma_map_page_attrs. And then I will fix that on the top. Hi Micheal and Jason, is that ok for you? Thanks.
On Thu, Oct 12, 2023 at 9:58 AM Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote: > > On Wed, 11 Oct 2023 10:00:57 -0700, Jakub Kicinski <kuba@kernel.org> wrote: > > On Wed, 11 Oct 2023 17:27:06 +0800 Xuan Zhuo wrote: > > > ## AF_XDP > > > > > > XDP socket(AF_XDP) is an excellent bypass kernel network framework. The zero > > > copy feature of xsk (XDP socket) needs to be supported by the driver. The > > > performance of zero copy is very good. mlx5 and intel ixgbe already support > > > this feature, This patch set allows virtio-net to support xsk's zerocopy xmit > > > feature. > > > > You're moving the driver and adding a major feature. > > This really needs to go via net or bpf. > > If you have dependencies in other trees please wait for > > after the merge window. > > > If so, I can remove the first two commits. > > Then, the sq uses the premapped mode by default. > And we can use the api virtqueue_dma_map_single_attrs to replace the > virtqueue_dma_map_page_attrs. > > And then I will fix that on the top. > > Hi Micheal and Jason, is that ok for you? I would go with what looks easy for you but I think Jakub wants the series to go with next-next (this is what we did in the past for networking specific features that is done in virtio-net). So we need to tweak the prefix to use net-next instead of vhost. Thanks > > Thanks. >
On Thu, 12 Oct 2023 15:50:13 +0800, Jason Wang <jasowang@redhat.com> wrote: > On Thu, Oct 12, 2023 at 9:58 AM Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote: > > > > On Wed, 11 Oct 2023 10:00:57 -0700, Jakub Kicinski <kuba@kernel.org> wrote: > > > On Wed, 11 Oct 2023 17:27:06 +0800 Xuan Zhuo wrote: > > > > ## AF_XDP > > > > > > > > XDP socket(AF_XDP) is an excellent bypass kernel network framework. The zero > > > > copy feature of xsk (XDP socket) needs to be supported by the driver. The > > > > performance of zero copy is very good. mlx5 and intel ixgbe already support > > > > this feature, This patch set allows virtio-net to support xsk's zerocopy xmit > > > > feature. > > > > > > You're moving the driver and adding a major feature. > > > This really needs to go via net or bpf. > > > If you have dependencies in other trees please wait for > > > after the merge window. > > > > > > If so, I can remove the first two commits. > > > > Then, the sq uses the premapped mode by default. > > And we can use the api virtqueue_dma_map_single_attrs to replace the > > virtqueue_dma_map_page_attrs. > > > > And then I will fix that on the top. > > > > Hi Micheal and Jason, is that ok for you? > > I would go with what looks easy for you but I think Jakub wants the > series to go with next-next (this is what we did in the past for > networking specific features that is done in virtio-net). So we need > to tweak the prefix to use net-next instead of vhost. OK. I will fix that in next version. Thanks. > > Thanks > > > > > > Thanks. > > >
On Thu, Oct 12, 2023 at 04:32:40PM +0800, Xuan Zhuo wrote: > On Thu, 12 Oct 2023 15:50:13 +0800, Jason Wang <jasowang@redhat.com> wrote: > > On Thu, Oct 12, 2023 at 9:58 AM Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote: > > > > > > On Wed, 11 Oct 2023 10:00:57 -0700, Jakub Kicinski <kuba@kernel.org> wrote: > > > > On Wed, 11 Oct 2023 17:27:06 +0800 Xuan Zhuo wrote: > > > > > ## AF_XDP > > > > > > > > > > XDP socket(AF_XDP) is an excellent bypass kernel network framework. The zero > > > > > copy feature of xsk (XDP socket) needs to be supported by the driver. The > > > > > performance of zero copy is very good. mlx5 and intel ixgbe already support > > > > > this feature, This patch set allows virtio-net to support xsk's zerocopy xmit > > > > > feature. > > > > > > > > You're moving the driver and adding a major feature. > > > > This really needs to go via net or bpf. > > > > If you have dependencies in other trees please wait for > > > > after the merge window. > > > > > > > > > If so, I can remove the first two commits. > > > > > > Then, the sq uses the premapped mode by default. > > > And we can use the api virtqueue_dma_map_single_attrs to replace the > > > virtqueue_dma_map_page_attrs. > > > > > > And then I will fix that on the top. > > > > > > Hi Micheal and Jason, is that ok for you? > > > > I would go with what looks easy for you but I think Jakub wants the > > series to go with next-next (this is what we did in the past for > > networking specific features that is done in virtio-net). So we need > > to tweak the prefix to use net-next instead of vhost. > > OK. > > I will fix that in next version. > > Thanks. Scaling scope back as far as possible is a good idea generally. I am not sure how this will work though. Let's see. > > > > Thanks > > > > > > > > > > Thanks. > > > > >