mbox series

[v4,0/5] Add USB Support on Qualcomm's SDX75 Platform

Message ID 1695359525-4548-1-git-send-email-quic_rohiagar@quicinc.com (mailing list archive)
Headers show
Series Add USB Support on Qualcomm's SDX75 Platform | expand

Message

Rohit Agarwal Sept. 22, 2023, 5:12 a.m. UTC 
Hi,

Changes in v4:
 - Replaced the v5 offsets with v6 offsets as per Dmitry's suggestion in patch 5/5.

Changes in v3:
 - Removed the unnecessary change introduced in v2 of patch 2/5
 - Added Fixes tag in patch 3/5
 - Rebased patch 5/5 on Dmitry's cleanup patches.
   https://lore.kernel.org/all/20230911203842.778411-1-dmitry.baryshkov@linaro.org/
   https://lore.kernel.org/linux-phy/20230824211952.1397699-1-dmitry.baryshkov@linaro.org/

Changes in v2:
 - Dropped the new dt schema introduced in v1 for sdx75 usb3 phy
   and reusing the bindings.
 - Rephrased the commit message of patch 3/5
 - Removed stray lines from the patch 5/5

This series adds support of USB3 PHY support for Qualcomm's SDX75 Platform.

Thanks,
Rohit.


Rohit Agarwal (5):
  dt-bindings: phy: qcom,snps-eusb2-phy: Add compatible for SDX75
  dt-bindings: phy: qcom,qmp-usb: Add SDX75 USB3 PHY
  dt-bindings: usb: qcom,dwc3: Fix SDX65 clocks
  dt-bindings: usb: dwc3: Add SDX75 compatible
  phy: qcom-qmp-usb: Add Qualcomm SDX75 USB3 PHY support

 .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml        |   2 +
 .../bindings/phy/qcom,snps-eusb2-phy.yaml          |   7 +-
 .../devicetree/bindings/usb/qcom,dwc3.yaml         |   4 +
 drivers/phy/qualcomm/phy-qcom-qmp-usb.c            | 173 +++++++++++++++++++++
 4 files changed, 185 insertions(+), 1 deletion(-)

Comments

Vinod Koul Oct. 13, 2023, 10:29 a.m. UTC | #1 
On 22-09-23, 10:42, Rohit Agarwal wrote:
> Hi,
> 
> Changes in v4:
>  - Replaced the v5 offsets with v6 offsets as per Dmitry's suggestion in patch 5/5.
> 
> Changes in v3:
>  - Removed the unnecessary change introduced in v2 of patch 2/5
>  - Added Fixes tag in patch 3/5
>  - Rebased patch 5/5 on Dmitry's cleanup patches.
>    https://lore.kernel.org/all/20230911203842.778411-1-dmitry.baryshkov@linaro.org/
>    https://lore.kernel.org/linux-phy/20230824211952.1397699-1-dmitry.baryshkov@linaro.org/
> 
> Changes in v2:
>  - Dropped the new dt schema introduced in v1 for sdx75 usb3 phy
>    and reusing the bindings.
>  - Rephrased the commit message of patch 3/5
>  - Removed stray lines from the patch 5/5
> 
> This series adds support of USB3 PHY support for Qualcomm's SDX75 Platform.

The phy patches fail to apply, can you please rebase the three patches
and resend
Rohit Agarwal Oct. 13, 2023, 10:38 a.m. UTC | #2 
On 10/13/2023 3:59 PM, Vinod Koul wrote:
> On 22-09-23, 10:42, Rohit Agarwal wrote:
>> Hi,
>>
>> Changes in v4:
>>   - Replaced the v5 offsets with v6 offsets as per Dmitry's suggestion in patch 5/5.
>>
>> Changes in v3:
>>   - Removed the unnecessary change introduced in v2 of patch 2/5
>>   - Added Fixes tag in patch 3/5
>>   - Rebased patch 5/5 on Dmitry's cleanup patches.
>>     https://lore.kernel.org/all/20230911203842.778411-1-dmitry.baryshkov@linaro.org/
>>     https://lore.kernel.org/linux-phy/20230824211952.1397699-1-dmitry.baryshkov@linaro.org/
>>
>> Changes in v2:
>>   - Dropped the new dt schema introduced in v1 for sdx75 usb3 phy
>>     and reusing the bindings.
>>   - Rephrased the commit message of patch 3/5
>>   - Removed stray lines from the patch 5/5
>>
>> This series adds support of USB3 PHY support for Qualcomm's SDX75 Platform.
> The phy patches fail to apply, can you please rebase the three patches
> and resend
Can you please apply these two series. This series depends on it for 
successful compilation.
[1] 
https://lore.kernel.org/all/20230911203842.778411-1-dmitry.baryshkov@linaro.org/
[2] 
https://lore.kernel.org/linux-phy/20230824211952.1397699-1-dmitry.baryshkov@linaro.org/

Thanks,
Rohit.
Vinod Koul Oct. 13, 2023, 10:45 a.m. UTC | #3 
On 13-10-23, 16:08, Rohit Agarwal wrote:
> 
> On 10/13/2023 3:59 PM, Vinod Koul wrote:
> > On 22-09-23, 10:42, Rohit Agarwal wrote:
> > > Hi,
> > > 
> > > Changes in v4:
> > >   - Replaced the v5 offsets with v6 offsets as per Dmitry's suggestion in patch 5/5.
> > > 
> > > Changes in v3:
> > >   - Removed the unnecessary change introduced in v2 of patch 2/5
> > >   - Added Fixes tag in patch 3/5
> > >   - Rebased patch 5/5 on Dmitry's cleanup patches.
> > >     https://lore.kernel.org/all/20230911203842.778411-1-dmitry.baryshkov@linaro.org/
> > >     https://lore.kernel.org/linux-phy/20230824211952.1397699-1-dmitry.baryshkov@linaro.org/
> > > 
> > > Changes in v2:
> > >   - Dropped the new dt schema introduced in v1 for sdx75 usb3 phy
> > >     and reusing the bindings.
> > >   - Rephrased the commit message of patch 3/5
> > >   - Removed stray lines from the patch 5/5
> > > 
> > > This series adds support of USB3 PHY support for Qualcomm's SDX75 Platform.
> > The phy patches fail to apply, can you please rebase the three patches
> > and resend
> Can you please apply these two series. This series depends on it for
> successful compilation.
> [1] https://lore.kernel.org/all/20230911203842.778411-1-dmitry.baryshkov@linaro.org/

This one has a pending comment bw Konrad and Dmitry..

> [2] https://lore.kernel.org/linux-phy/20230824211952.1397699-1-dmitry.baryshkov@linaro.org/

This one is already in -next

> 
> Thanks,
> Rohit.
Rohit Agarwal Oct. 13, 2023, 10:47 a.m. UTC | #4 
On 10/13/2023 4:15 PM, Vinod Koul wrote:
> On 13-10-23, 16:08, Rohit Agarwal wrote:
>> On 10/13/2023 3:59 PM, Vinod Koul wrote:
>>> On 22-09-23, 10:42, Rohit Agarwal wrote:
>>>> Hi,
>>>>
>>>> Changes in v4:
>>>>    - Replaced the v5 offsets with v6 offsets as per Dmitry's suggestion in patch 5/5.
>>>>
>>>> Changes in v3:
>>>>    - Removed the unnecessary change introduced in v2 of patch 2/5
>>>>    - Added Fixes tag in patch 3/5
>>>>    - Rebased patch 5/5 on Dmitry's cleanup patches.
>>>>      https://lore.kernel.org/all/20230911203842.778411-1-dmitry.baryshkov@linaro.org/
>>>>      https://lore.kernel.org/linux-phy/20230824211952.1397699-1-dmitry.baryshkov@linaro.org/
>>>>
>>>> Changes in v2:
>>>>    - Dropped the new dt schema introduced in v1 for sdx75 usb3 phy
>>>>      and reusing the bindings.
>>>>    - Rephrased the commit message of patch 3/5
>>>>    - Removed stray lines from the patch 5/5
>>>>
>>>> This series adds support of USB3 PHY support for Qualcomm's SDX75 Platform.
>>> The phy patches fail to apply, can you please rebase the three patches
>>> and resend
>> Can you please apply these two series. This series depends on it for
>> successful compilation.
>> [1] https://lore.kernel.org/all/20230911203842.778411-1-dmitry.baryshkov@linaro.org/
> This one has a pending comment bw Konrad and Dmitry..
Ok, Will wait for this to get resolved.

Thanks,
Rohit.
>
>> [2] https://lore.kernel.org/linux-phy/20230824211952.1397699-1-dmitry.baryshkov@linaro.org/
> This one is already in -next
>
>> Thanks,
>> Rohit.
Vinod Koul Nov. 27, 2023, 1:22 p.m. UTC | #5 
On Fri, 22 Sep 2023 10:42:00 +0530, Rohit Agarwal wrote:
> Changes in v4:
>  - Replaced the v5 offsets with v6 offsets as per Dmitry's suggestion in patch 5/5.
> 
> Changes in v3:
>  - Removed the unnecessary change introduced in v2 of patch 2/5
>  - Added Fixes tag in patch 3/5
>  - Rebased patch 5/5 on Dmitry's cleanup patches.
>    https://lore.kernel.org/all/20230911203842.778411-1-dmitry.baryshkov@linaro.org/
>    https://lore.kernel.org/linux-phy/20230824211952.1397699-1-dmitry.baryshkov@linaro.org/
> 
> [...]

Applied, thanks!

[1/5] dt-bindings: phy: qcom,snps-eusb2-phy: Add compatible for SDX75
      (no commit info)
[2/5] dt-bindings: phy: qcom,qmp-usb: Add SDX75 USB3 PHY
      (no commit info)
[5/5] phy: qcom-qmp-usb: Add Qualcomm SDX75 USB3 PHY support
      commit: 7f6f9e0def00cfaeb1d034fd13dbd84470aeccbd

Best regards,