| Message ID | 20231011121551.1205211-1-saikrishnag@marvell.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5ee0a3bd150918512f28c55073b0d782f674320c |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] octeontx2-af: Enable hardware timestamping for VFs | expand |
On Wed, Oct 11, 2023 at 05:45:51PM +0530, Sai Krishna wrote: > From: Subbaraya Sundeep <sbhatta@marvell.com> > > Currently for VFs, mailbox returns ENODEV error when hardware timestamping > enable is requested. This patch fixes this issue. Modified this patch to > return EPERM error for the PF/VFs which are not attached to CGX/RPM. > > Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com> > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com> > Signed-off-by: Sai Krishna <saikrishnag@marvell.com> Thanks for addressing my review of v1. Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 11 Oct 2023 17:45:51 +0530 you wrote: > From: Subbaraya Sundeep <sbhatta@marvell.com> > > Currently for VFs, mailbox returns ENODEV error when hardware timestamping > enable is requested. This patch fixes this issue. Modified this patch to > return EPERM error for the PF/VFs which are not attached to CGX/RPM. > > Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com> > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com> > Signed-off-by: Sai Krishna <saikrishnag@marvell.com> > > [...] Here is the summary with links: - [net-next] octeontx2-af: Enable hardware timestamping for VFs https://git.kernel.org/netdev/net-next/c/5ee0a3bd1509 You are awesome, thank you!
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c index f2b1edf1bb43..15a319684ed3 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c @@ -756,12 +756,11 @@ static int rvu_cgx_ptp_rx_cfg(struct rvu *rvu, u16 pcifunc, bool enable) if (!is_mac_feature_supported(rvu, pf, RVU_LMAC_FEAT_PTP)) return 0; - /* This msg is expected only from PFs that are mapped to CGX LMACs, + /* This msg is expected only from PF/VFs that are mapped to CGX/RPM LMACs, * if received from other PF/VF simply ACK, nothing to do. */ - if ((pcifunc & RVU_PFVF_FUNC_MASK) || - !is_pf_cgxmapped(rvu, pf)) - return -ENODEV; + if (!is_pf_cgxmapped(rvu, pf)) + return -EPERM; rvu_get_cgx_lmac_id(rvu->pf2cgxlmac_map[pf], &cgx_id, &lmac_id); cgxd = rvu_cgx_pdata(cgx_id, rvu);