| Message ID | 20231016130934.1158504-6-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 24352d170b5fcab1d7724dd20257e0b73cbdb453 |
| Headers | show |
| Series | xhci: dbc: Update driver to use modern APIs | expand |
On 10/16/23 4:09 PM, Andy Shevchenko wrote: > The usual patter is to check for errors and then continue if none. Pattern. :-) > Apply that pattern to xhci_dbc_stop() code. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> [...] MBR, Sergey
On 16.10.2023 19.55, Sergei Shtylyov wrote: > On 10/16/23 4:09 PM, Andy Shevchenko wrote: > >> The usual patter is to check for errors and then continue if none. > > Pattern. :-) > I'll fix it while applying -Mathias
diff --git a/drivers/usb/host/xhci-dbgcap.c b/drivers/usb/host/xhci-dbgcap.c index 660e3ee31dc6..6b9f4b839270 100644 --- a/drivers/usb/host/xhci-dbgcap.c +++ b/drivers/usb/host/xhci-dbgcap.c @@ -646,11 +646,11 @@ static void xhci_dbc_stop(struct xhci_dbc *dbc) spin_lock_irqsave(&dbc->lock, flags); ret = xhci_do_dbc_stop(dbc); spin_unlock_irqrestore(&dbc->lock, flags); + if (ret) + return; - if (!ret) { - xhci_dbc_mem_cleanup(dbc); - pm_runtime_put_sync(dbc->dev); /* note, was self.controller */ - } + xhci_dbc_mem_cleanup(dbc); + pm_runtime_put_sync(dbc->dev); /* note, was self.controller */ } static void
The usual patter is to check for errors and then continue if none. Apply that pattern to xhci_dbc_stop() code. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/usb/host/xhci-dbgcap.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)