mbox series

[v3,0/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

Message ID 20231002203221.17241-1-lersek@redhat.com (mailing list archive)
Headers show
Series vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously | expand

Message

Laszlo Ersek Oct. 2, 2023, 8:32 p.m. UTC
v2:

- http://mid.mail-archive.com/20230830134055.106812-1-lersek@redhat.com
- https://patchwork.ozlabs.org/project/qemu-devel/cover/20230830134055.106812-1-lersek@redhat.com/

v3 picks up tags from Phil, Eugenio and Albert, and updates the commit
message on patch#7 according to Eugenio's comments.

Retested.

Laszlo Ersek (7):
  vhost-user: strip superfluous whitespace
  vhost-user: tighten "reply_supported" scope in "set_vring_addr"
  vhost-user: factor out "vhost_user_write_sync"
  vhost-user: flatten "enforce_reply" into "vhost_user_write_sync"
  vhost-user: hoist "write_sync", "get_features", "get_u64"
  vhost-user: allow "vhost_set_vring" to wait for a reply
  vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

 hw/virtio/vhost-user.c | 216 ++++++++++----------
 1 file changed, 108 insertions(+), 108 deletions(-)


base-commit: 36e9aab3c569d4c9ad780473596e18479838d1aa

Comments

Laszlo Ersek Oct. 18, 2023, 11:26 a.m. UTC | #1
Hi Michael,

still waiting for you to pick this up, please.

In
<http://mid.mail-archive.com/20231004122927-mutt-send-email-mst@kernel.org>,
you wrote:

> OK. I'll need to do another PR soonish since a bunch of patchsets
> which I wanted in this PR had issues and I had to drop them.
> v3 will be there.

(Alt. link:
<https://lists.gnu.org/archive/html/qemu-devel/2023-10/msg01164.html>.)

That was on 04 Oct 2023 -- exactly two weeks ago :(

Stefan, can you perhaps apply this v3 series directly from the list?

Thanks,
Laszlo

On 10/2/23 22:32, Laszlo Ersek wrote:
> v2:
> 
> - http://mid.mail-archive.com/20230830134055.106812-1-lersek@redhat.com
> - https://patchwork.ozlabs.org/project/qemu-devel/cover/20230830134055.106812-1-lersek@redhat.com/
> 
> v3 picks up tags from Phil, Eugenio and Albert, and updates the commit
> message on patch#7 according to Eugenio's comments.
> 
> Retested.
> 
> Laszlo Ersek (7):
>   vhost-user: strip superfluous whitespace
>   vhost-user: tighten "reply_supported" scope in "set_vring_addr"
>   vhost-user: factor out "vhost_user_write_sync"
>   vhost-user: flatten "enforce_reply" into "vhost_user_write_sync"
>   vhost-user: hoist "write_sync", "get_features", "get_u64"
>   vhost-user: allow "vhost_set_vring" to wait for a reply
>   vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously
> 
>  hw/virtio/vhost-user.c | 216 ++++++++++----------
>  1 file changed, 108 insertions(+), 108 deletions(-)
> 
> 
> base-commit: 36e9aab3c569d4c9ad780473596e18479838d1aa
Stefan Hajnoczi Oct. 18, 2023, 11:41 a.m. UTC | #2
On Wed, 18 Oct 2023 at 07:26, Laszlo Ersek <lersek@redhat.com> wrote:
>
> Hi Michael,
>
> still waiting for you to pick this up, please.
>
> In
> <http://mid.mail-archive.com/20231004122927-mutt-send-email-mst@kernel.org>,
> you wrote:
>
> > OK. I'll need to do another PR soonish since a bunch of patchsets
> > which I wanted in this PR had issues and I had to drop them.
> > v3 will be there.
>
> (Alt. link:
> <https://lists.gnu.org/archive/html/qemu-devel/2023-10/msg01164.html>.)
>
> That was on 04 Oct 2023 -- exactly two weeks ago :(
>
> Stefan, can you perhaps apply this v3 series directly from the list?

Michael has been active over the past few days, so I think he'll
respond and send a pull request with your patches.

Stefan

>
> Thanks,
> Laszlo
>
> On 10/2/23 22:32, Laszlo Ersek wrote:
> > v2:
> >
> > - http://mid.mail-archive.com/20230830134055.106812-1-lersek@redhat.com
> > - https://patchwork.ozlabs.org/project/qemu-devel/cover/20230830134055.106812-1-lersek@redhat.com/
> >
> > v3 picks up tags from Phil, Eugenio and Albert, and updates the commit
> > message on patch#7 according to Eugenio's comments.
> >
> > Retested.
> >
> > Laszlo Ersek (7):
> >   vhost-user: strip superfluous whitespace
> >   vhost-user: tighten "reply_supported" scope in "set_vring_addr"
> >   vhost-user: factor out "vhost_user_write_sync"
> >   vhost-user: flatten "enforce_reply" into "vhost_user_write_sync"
> >   vhost-user: hoist "write_sync", "get_features", "get_u64"
> >   vhost-user: allow "vhost_set_vring" to wait for a reply
> >   vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously
> >
> >  hw/virtio/vhost-user.c | 216 ++++++++++----------
> >  1 file changed, 108 insertions(+), 108 deletions(-)
> >
> >
> > base-commit: 36e9aab3c569d4c9ad780473596e18479838d1aa
>
>
Michael S. Tsirkin Oct. 18, 2023, 11:59 a.m. UTC | #3
On Wed, Oct 18, 2023 at 01:26:30PM +0200, Laszlo Ersek wrote:
> Hi Michael,
> 
> still waiting for you to pick this up, please.
> 
> In
> <http://mid.mail-archive.com/20231004122927-mutt-send-email-mst@kernel.org>,
> you wrote:
> 
> > OK. I'll need to do another PR soonish since a bunch of patchsets
> > which I wanted in this PR had issues and I had to drop them.
> > v3 will be there.
> 
> (Alt. link:
> <https://lists.gnu.org/archive/html/qemu-devel/2023-10/msg01164.html>.)
> 
> That was on 04 Oct 2023 -- exactly two weeks ago :(

It's been a bit wild here, sorry about the delay.
I think I'm set for now and I'm testing it.

> Stefan, can you perhaps apply this v3 series directly from the list?
> 
> Thanks,
> Laszlo
> 
> On 10/2/23 22:32, Laszlo Ersek wrote:
> > v2:
> > 
> > - http://mid.mail-archive.com/20230830134055.106812-1-lersek@redhat.com
> > - https://patchwork.ozlabs.org/project/qemu-devel/cover/20230830134055.106812-1-lersek@redhat.com/
> > 
> > v3 picks up tags from Phil, Eugenio and Albert, and updates the commit
> > message on patch#7 according to Eugenio's comments.
> > 
> > Retested.
> > 
> > Laszlo Ersek (7):
> >   vhost-user: strip superfluous whitespace
> >   vhost-user: tighten "reply_supported" scope in "set_vring_addr"
> >   vhost-user: factor out "vhost_user_write_sync"
> >   vhost-user: flatten "enforce_reply" into "vhost_user_write_sync"
> >   vhost-user: hoist "write_sync", "get_features", "get_u64"
> >   vhost-user: allow "vhost_set_vring" to wait for a reply
> >   vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously
> > 
> >  hw/virtio/vhost-user.c | 216 ++++++++++----------
> >  1 file changed, 108 insertions(+), 108 deletions(-)
> > 
> > 
> > base-commit: 36e9aab3c569d4c9ad780473596e18479838d1aa