| Message ID | 20231017205119.416392-1-florian.fainelli@broadcom.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6200e00e112ce2d17b066a20dd2476d9aecbefa6 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v2] net: phy: bcm7xxx: Add missing 16nm EPHY statistics | expand |
On Tue, Oct 17, 2023 at 01:51:19PM -0700, Florian Fainelli wrote: > The .probe() function would allocate the necessary space and ensure that > the library call sizes the nunber of statistics but the callbacks > necessary to fetch the name and values were not wired up. > > Reported-by: Justin Chen <justin.chen@broadcom.com> > Fixes: f68d08c437f9 ("net: phy: bcm7xxx: Add EPHY entry for 72165") > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 17 Oct 2023 13:51:19 -0700 you wrote: > The .probe() function would allocate the necessary space and ensure that > the library call sizes the nunber of statistics but the callbacks > necessary to fetch the name and values were not wired up. > > Reported-by: Justin Chen <justin.chen@broadcom.com> > Fixes: f68d08c437f9 ("net: phy: bcm7xxx: Add EPHY entry for 72165") > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> > > [...] Here is the summary with links: - [net,v2] net: phy: bcm7xxx: Add missing 16nm EPHY statistics https://git.kernel.org/netdev/net/c/6200e00e112c You are awesome, thank you!
diff --git a/drivers/net/phy/bcm7xxx.c b/drivers/net/phy/bcm7xxx.c index 8478b081c058..97638ba7ae85 100644 --- a/drivers/net/phy/bcm7xxx.c +++ b/drivers/net/phy/bcm7xxx.c @@ -894,6 +894,9 @@ static int bcm7xxx_28nm_probe(struct phy_device *phydev) .name = _name, \ /* PHY_BASIC_FEATURES */ \ .flags = PHY_IS_INTERNAL, \ + .get_sset_count = bcm_phy_get_sset_count, \ + .get_strings = bcm_phy_get_strings, \ + .get_stats = bcm7xxx_28nm_get_phy_stats, \ .probe = bcm7xxx_28nm_probe, \ .config_init = bcm7xxx_16nm_ephy_config_init, \ .config_aneg = genphy_config_aneg, \
The .probe() function would allocate the necessary space and ensure that the library call sizes the nunber of statistics but the callbacks necessary to fetch the name and values were not wired up. Reported-by: Justin Chen <justin.chen@broadcom.com> Fixes: f68d08c437f9 ("net: phy: bcm7xxx: Add EPHY entry for 72165") Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> --- drivers/net/phy/bcm7xxx.c | 3 +++ 1 file changed, 3 insertions(+)