| Message ID | 20231018215809.3477437-3-Frank.Li@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | I3C slave mode support | expand |
On 18/10/2023 23:58, Frank Li wrote: > Add compatible string 'silvaco,i3c-slave' for slave mode. > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > .../devicetree/bindings/i3c/silvaco,i3c-master.yaml | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml > index 133855f11b4f5..63db63f00a509 100644 > --- a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml > +++ b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/i3c/silvaco,i3c-master.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Silvaco I3C master > +title: Silvaco I3C master/slave > > maintainers: > - Conor Culhane <conor.culhane@silvaco.com> > @@ -14,8 +14,10 @@ allOf: > > properties: > compatible: > - const: silvaco,i3c-master-v1 > - > + const: > + enum: > + - silvaco,i3c-master-v1 > + - silvaco,i3c-slave-v1 Missing blank line. Rather choose name from Coding style. Best regards, Krzysztof
On Wed, 18 Oct 2023 17:58:06 -0400, Frank Li wrote: > Add compatible string 'silvaco,i3c-slave' for slave mode. > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > .../devicetree/bindings/i3c/silvaco,i3c-master.yaml | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml: properties:compatible:const: {'enum': ['silvaco,i3c-master-v1', 'silvaco,i3c-slave-v1']} is not of type 'integer', 'string' from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml: properties:compatible:const: {'enum': ['silvaco,i3c-master-v1', 'silvaco,i3c-slave-v1']} is not of type 'string' from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.example.dtb: i3c-master@a0000000: compatible: {'enum': ['silvaco,i3c-master-v1', 'silvaco,i3c-slave-v1']} was expected from schema $id: http://devicetree.org/schemas/i3c/silvaco,i3c-master.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.example.dtb: i3c-master@a0000000: Unevaluated properties are not allowed ('compatible' was unexpected) from schema $id: http://devicetree.org/schemas/i3c/silvaco,i3c-master.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231018215809.3477437-3-Frank.Li@nxp.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml index 133855f11b4f5..63db63f00a509 100644 --- a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml +++ b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml @@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/i3c/silvaco,i3c-master.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Silvaco I3C master +title: Silvaco I3C master/slave maintainers: - Conor Culhane <conor.culhane@silvaco.com> @@ -14,8 +14,10 @@ allOf: properties: compatible: - const: silvaco,i3c-master-v1 - + const: + enum: + - silvaco,i3c-master-v1 + - silvaco,i3c-slave-v1 reg: maxItems: 1
Add compatible string 'silvaco,i3c-slave' for slave mode. Signed-off-by: Frank Li <Frank.Li@nxp.com> --- .../devicetree/bindings/i3c/silvaco,i3c-master.yaml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)