diff mbox series

[v4,2/2] drm/i915: remove display device info from i915 capabilities

Message ID 20231018102723.16915-3-vinod.govindapillai@intel.com (mailing list archive)
State New, archived
Headers show
Series display device info as a separate debugfs entry | expand

Commit Message

Govindapillai, Vinod Oct. 18, 2023, 10:27 a.m. UTC
Display device and display runtime info is exposed as part of
i915_display_capabilities debugfs entry. Remove this information
from i915_ capabilities as it is now reduntant.

Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
 drivers/gpu/drm/i915/i915_debugfs.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Borah, Chaitanya Kumar Oct. 19, 2023, 9:32 a.m. UTC | #1
> -----Original Message-----
> From: Govindapillai, Vinod <vinod.govindapillai@intel.com>
> Sent: Wednesday, October 18, 2023 3:57 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Govindapillai, Vinod <vinod.govindapillai@intel.com>; Sharma, Swati2
> <swati2.sharma@intel.com>; Borah, Chaitanya Kumar
> <chaitanya.kumar.borah@intel.com>
> Subject: [PATCH v4 2/2] drm/i915: remove display device info from i915
> capabilities
> 
> Display device and display runtime info is exposed as part of
> i915_display_capabilities debugfs entry. Remove this information from i915_
> capabilities as it is now reduntant.
> 
> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>

LGTM.

Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>

> ---
>  drivers/gpu/drm/i915/i915_debugfs.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
> b/drivers/gpu/drm/i915/i915_debugfs.c
> index e9b79c2c37d8..bb48feb3b12e 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -67,7 +67,6 @@ static int i915_capabilities(struct seq_file *m, void *data)
>  	seq_printf(m, "pch: %d\n", INTEL_PCH_TYPE(i915));
> 
>  	intel_device_info_print(INTEL_INFO(i915), RUNTIME_INFO(i915), &p);
> -	intel_display_device_info_print(DISPLAY_INFO(i915),
> DISPLAY_RUNTIME_INFO(i915), &p);
>  	i915_print_iommu_status(i915, &p);
>  	intel_gt_info_print(&to_gt(i915)->info, &p);
>  	intel_driver_caps_print(&i915->caps, &p);
> --
> 2.34.1
Jani Nikula Oct. 26, 2023, 1:26 p.m. UTC | #2
On Thu, 19 Oct 2023, "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com> wrote:
>> -----Original Message-----
>> From: Govindapillai, Vinod <vinod.govindapillai@intel.com>
>> Sent: Wednesday, October 18, 2023 3:57 PM
>> To: intel-gfx@lists.freedesktop.org
>> Cc: Govindapillai, Vinod <vinod.govindapillai@intel.com>; Sharma, Swati2
>> <swati2.sharma@intel.com>; Borah, Chaitanya Kumar
>> <chaitanya.kumar.borah@intel.com>
>> Subject: [PATCH v4 2/2] drm/i915: remove display device info from i915
>> capabilities
>> 
>> Display device and display runtime info is exposed as part of
>> i915_display_capabilities debugfs entry. Remove this information from i915_
>> capabilities as it is now reduntant.
>> 
>> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
>
> LGTM.
>
> Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>

Thanks for the patch and review, pushed to drm-intel-next.

BR,
Jani.

>
>> ---
>>  drivers/gpu/drm/i915/i915_debugfs.c | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
>> b/drivers/gpu/drm/i915/i915_debugfs.c
>> index e9b79c2c37d8..bb48feb3b12e 100644
>> --- a/drivers/gpu/drm/i915/i915_debugfs.c
>> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
>> @@ -67,7 +67,6 @@ static int i915_capabilities(struct seq_file *m, void *data)
>>  	seq_printf(m, "pch: %d\n", INTEL_PCH_TYPE(i915));
>> 
>>  	intel_device_info_print(INTEL_INFO(i915), RUNTIME_INFO(i915), &p);
>> -	intel_display_device_info_print(DISPLAY_INFO(i915),
>> DISPLAY_RUNTIME_INFO(i915), &p);
>>  	i915_print_iommu_status(i915, &p);
>>  	intel_gt_info_print(&to_gt(i915)->info, &p);
>>  	intel_driver_caps_print(&i915->caps, &p);
>> --
>> 2.34.1
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index e9b79c2c37d8..bb48feb3b12e 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -67,7 +67,6 @@  static int i915_capabilities(struct seq_file *m, void *data)
 	seq_printf(m, "pch: %d\n", INTEL_PCH_TYPE(i915));
 
 	intel_device_info_print(INTEL_INFO(i915), RUNTIME_INFO(i915), &p);
-	intel_display_device_info_print(DISPLAY_INFO(i915), DISPLAY_RUNTIME_INFO(i915), &p);
 	i915_print_iommu_status(i915, &p);
 	intel_gt_info_print(&to_gt(i915)->info, &p);
 	intel_driver_caps_print(&i915->caps, &p);