| Message ID | 20231019100639.4026283-1-andre.draszik@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9cffa831f0685c60c8ca743986a24b153b440fed |
| Headers | show |
| Series | [1/2] tty: serial: samsung: drop earlycon support for unsupported platforms | expand |
On 19/10/2023 12:06, André Draszik wrote: > Commit 1ea35b355722 ("ARM: s3c: remove s3c24xx specific hacks") removed > support here for several old platforms, but kept support for earlycon > for those same platforms. > > As earlycon support for otherwise unsupported platforms doesn't seem to > be useful, just drop it as well. > > Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: André Draszik <andre.draszik@linaro.org> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Thu, Oct 19, 2023 at 5:06 AM André Draszik <andre.draszik@linaro.org> wrote: > > Commit 1ea35b355722 ("ARM: s3c: remove s3c24xx specific hacks") removed > support here for several old platforms, but kept support for earlycon > for those same platforms. > > As earlycon support for otherwise unsupported platforms doesn't seem to > be useful, just drop it as well. > > Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: André Draszik <andre.draszik@linaro.org> > --- Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> > drivers/tty/serial/samsung_tty.c | 16 +--------------- > 1 file changed, 1 insertion(+), 15 deletions(-) > > diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c > index 6b8d4b4402e9..a74ecc78f4e0 100644 > --- a/drivers/tty/serial/samsung_tty.c > +++ b/drivers/tty/serial/samsung_tty.c > @@ -2735,17 +2735,7 @@ static struct samsung_early_console_data s3c2410_early_console_data = { > .rxfifo_mask = S3C2410_UFSTAT_RXFULL | S3C2410_UFSTAT_RXMASK, > }; > > -static int __init s3c2410_early_console_setup(struct earlycon_device *device, > - const char *opt) > -{ > - device->port.private_data = &s3c2410_early_console_data; > - return samsung_early_console_setup(device, opt); > -} > - > -OF_EARLYCON_DECLARE(s3c2410, "samsung,s3c2410-uart", > - s3c2410_early_console_setup); > - > -/* S3C2412, S3C2440, S3C64xx */ > +/* S3C64xx */ > static struct samsung_early_console_data s3c2440_early_console_data = { > .txfull_mask = S3C2440_UFSTAT_TXFULL, > .rxfifo_mask = S3C2440_UFSTAT_RXFULL | S3C2440_UFSTAT_RXMASK, > @@ -2758,10 +2748,6 @@ static int __init s3c2440_early_console_setup(struct earlycon_device *device, > return samsung_early_console_setup(device, opt); > } > > -OF_EARLYCON_DECLARE(s3c2412, "samsung,s3c2412-uart", > - s3c2440_early_console_setup); > -OF_EARLYCON_DECLARE(s3c2440, "samsung,s3c2440-uart", > - s3c2440_early_console_setup); > OF_EARLYCON_DECLARE(s3c6400, "samsung,s3c6400-uart", > s3c2440_early_console_setup); > > -- > 2.40.1 > >
diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 6b8d4b4402e9..a74ecc78f4e0 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -2735,17 +2735,7 @@ static struct samsung_early_console_data s3c2410_early_console_data = { .rxfifo_mask = S3C2410_UFSTAT_RXFULL | S3C2410_UFSTAT_RXMASK, }; -static int __init s3c2410_early_console_setup(struct earlycon_device *device, - const char *opt) -{ - device->port.private_data = &s3c2410_early_console_data; - return samsung_early_console_setup(device, opt); -} - -OF_EARLYCON_DECLARE(s3c2410, "samsung,s3c2410-uart", - s3c2410_early_console_setup); - -/* S3C2412, S3C2440, S3C64xx */ +/* S3C64xx */ static struct samsung_early_console_data s3c2440_early_console_data = { .txfull_mask = S3C2440_UFSTAT_TXFULL, .rxfifo_mask = S3C2440_UFSTAT_RXFULL | S3C2440_UFSTAT_RXMASK, @@ -2758,10 +2748,6 @@ static int __init s3c2440_early_console_setup(struct earlycon_device *device, return samsung_early_console_setup(device, opt); } -OF_EARLYCON_DECLARE(s3c2412, "samsung,s3c2412-uart", - s3c2440_early_console_setup); -OF_EARLYCON_DECLARE(s3c2440, "samsung,s3c2440-uart", - s3c2440_early_console_setup); OF_EARLYCON_DECLARE(s3c6400, "samsung,s3c6400-uart", s3c2440_early_console_setup);
Commit 1ea35b355722 ("ARM: s3c: remove s3c24xx specific hacks") removed support here for several old platforms, but kept support for earlycon for those same platforms. As earlycon support for otherwise unsupported platforms doesn't seem to be useful, just drop it as well. Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: André Draszik <andre.draszik@linaro.org> --- drivers/tty/serial/samsung_tty.c | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-)