| Message ID | 20231009122723.35136-1-giovanni.cabiddu@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | crypto: qat - fix double free during reset | expand |
On Mon, Oct 09, 2023 at 01:27:19PM +0100, Giovanni Cabiddu wrote: > From: Svyatoslav Pankratov <svyatoslav.pankratov@intel.com> > > There is no need to free the reset_data structure if the recovery is > unsuccessful and the reset is synchronous. The function > adf_dev_aer_schedule_reset() handles the cleanup properly. Only > asynchronous resets require such structure to be freed inside the reset > worker. > > Fixes: d8cba25d2c68 ("crypto: qat - Intel(R) QAT driver framework") > Signed-off-by: Svyatoslav Pankratov <svyatoslav.pankratov@intel.com> > Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com> > --- > drivers/crypto/intel/qat/qat_common/adf_aer.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Patch applied. Thanks.
diff --git a/drivers/crypto/intel/qat/qat_common/adf_aer.c b/drivers/crypto/intel/qat/qat_common/adf_aer.c index 04af32a2811c..a39e70bd4b21 100644 --- a/drivers/crypto/intel/qat/qat_common/adf_aer.c +++ b/drivers/crypto/intel/qat/qat_common/adf_aer.c @@ -92,7 +92,8 @@ static void adf_device_reset_worker(struct work_struct *work) if (adf_dev_restart(accel_dev)) { /* The device hanged and we can't restart it so stop here */ dev_err(&GET_DEV(accel_dev), "Restart device failed\n"); - kfree(reset_data); + if (reset_data->mode == ADF_DEV_RESET_ASYNC) + kfree(reset_data); WARN(1, "QAT: device restart failed. Device is unusable\n"); return; }