| Message ID | 20231020075521.2121571-47-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | crypto: Convert to platform remove callback returning void | expand |
On Fri, 20 Oct 2023 09:55:25 +0200 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: Hi, > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Andre Przywara <andre.przywara@arm.com> Cheers, Andre > --- > drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c > index 4a9587285c04..f14c60359d19 100644 > --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c > +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c > @@ -908,7 +908,7 @@ static int sun8i_ss_probe(struct platform_device *pdev) > return err; > } > > -static int sun8i_ss_remove(struct platform_device *pdev) > +static void sun8i_ss_remove(struct platform_device *pdev) > { > struct sun8i_ss_dev *ss = platform_get_drvdata(pdev); > > @@ -921,8 +921,6 @@ static int sun8i_ss_remove(struct platform_device *pdev) > sun8i_ss_free_flows(ss, MAXFLOW - 1); > > sun8i_ss_pm_exit(ss); > - > - return 0; > } > > static const struct of_device_id sun8i_ss_crypto_of_match_table[] = { > @@ -936,7 +934,7 @@ MODULE_DEVICE_TABLE(of, sun8i_ss_crypto_of_match_table); > > static struct platform_driver sun8i_ss_driver = { > .probe = sun8i_ss_probe, > - .remove = sun8i_ss_remove, > + .remove_new = sun8i_ss_remove, > .driver = { > .name = "sun8i-ss", > .pm = &sun8i_ss_pm_ops,
Dne petek, 20. oktober 2023 ob 09:55:25 CEST je Uwe Kleine-König napisal(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej > drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c > index 4a9587285c04..f14c60359d19 100644 > --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c > +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c > @@ -908,7 +908,7 @@ static int sun8i_ss_probe(struct platform_device *pdev) > return err; > } > > -static int sun8i_ss_remove(struct platform_device *pdev) > +static void sun8i_ss_remove(struct platform_device *pdev) > { > struct sun8i_ss_dev *ss = platform_get_drvdata(pdev); > > @@ -921,8 +921,6 @@ static int sun8i_ss_remove(struct platform_device *pdev) > sun8i_ss_free_flows(ss, MAXFLOW - 1); > > sun8i_ss_pm_exit(ss); > - > - return 0; > } > > static const struct of_device_id sun8i_ss_crypto_of_match_table[] = { > @@ -936,7 +934,7 @@ MODULE_DEVICE_TABLE(of, sun8i_ss_crypto_of_match_table); > > static struct platform_driver sun8i_ss_driver = { > .probe = sun8i_ss_probe, > - .remove = sun8i_ss_remove, > + .remove_new = sun8i_ss_remove, > .driver = { > .name = "sun8i-ss", > .pm = &sun8i_ss_pm_ops, >
Le Fri, Oct 20, 2023 at 09:55:25AM +0200, Uwe Kleine-König a écrit : > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c > index 4a9587285c04..f14c60359d19 100644 > --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c > +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c > @@ -908,7 +908,7 @@ static int sun8i_ss_probe(struct platform_device *pdev) > return err; > } > > -static int sun8i_ss_remove(struct platform_device *pdev) > +static void sun8i_ss_remove(struct platform_device *pdev) > { > struct sun8i_ss_dev *ss = platform_get_drvdata(pdev); > > @@ -921,8 +921,6 @@ static int sun8i_ss_remove(struct platform_device *pdev) > sun8i_ss_free_flows(ss, MAXFLOW - 1); > > sun8i_ss_pm_exit(ss); > - > - return 0; > } > > static const struct of_device_id sun8i_ss_crypto_of_match_table[] = { > @@ -936,7 +934,7 @@ MODULE_DEVICE_TABLE(of, sun8i_ss_crypto_of_match_table); > > static struct platform_driver sun8i_ss_driver = { > .probe = sun8i_ss_probe, > - .remove = sun8i_ss_remove, > + .remove_new = sun8i_ss_remove, > .driver = { > .name = "sun8i-ss", > .pm = &sun8i_ss_pm_ops, > -- > 2.42.0 > Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com> Thanks
diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c index 4a9587285c04..f14c60359d19 100644 --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c @@ -908,7 +908,7 @@ static int sun8i_ss_probe(struct platform_device *pdev) return err; } -static int sun8i_ss_remove(struct platform_device *pdev) +static void sun8i_ss_remove(struct platform_device *pdev) { struct sun8i_ss_dev *ss = platform_get_drvdata(pdev); @@ -921,8 +921,6 @@ static int sun8i_ss_remove(struct platform_device *pdev) sun8i_ss_free_flows(ss, MAXFLOW - 1); sun8i_ss_pm_exit(ss); - - return 0; } static const struct of_device_id sun8i_ss_crypto_of_match_table[] = { @@ -936,7 +934,7 @@ MODULE_DEVICE_TABLE(of, sun8i_ss_crypto_of_match_table); static struct platform_driver sun8i_ss_driver = { .probe = sun8i_ss_probe, - .remove = sun8i_ss_remove, + .remove_new = sun8i_ss_remove, .driver = { .name = "sun8i-ss", .pm = &sun8i_ss_pm_ops,
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)