| Message ID | 20231003192456.4038590-1-prestwoj@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | build: install iwd-decrypt-profile | expand |
Hi James, > If profile encryption is enabled its not out of the question that > somebody might need to decrypt it. This isn't a problem building > from source but IWD as a package likely won't include the decrypt > tool unless its specifically copied out. Add iwd-decrypt-profile > to the list of installed programs like iwctl, iwmon, etc > > This also fixes a minor bug in Makefile.am which was building both > iwd-profile-decrypt and probe-req if DAEMON was true. This should > be TOOLS. > --- > Makefile.am | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Makefile.am b/Makefile.am > index 2e962153..ebabcf1c 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -378,8 +378,9 @@ man_MANS += wired/ead.8 > endif > endif > > -if DAEMON > -noinst_PROGRAMS += tools/probe-req tools/iwd-decrypt-profile > +if TOOLS > +noinst_PROGRAMS += tools/probe-req > +bin_PROGRAMS += tools/iwd-decrypt-profile > > tools_probe_req_SOURCES = tools/probe-req.c src/mpdu.h src/mpdu.c \ > src/ie.h src/ie.c \ I really prefer not installing that tool. If someone shoots themselves in the foot and need to recover, they can install it from the source. In addition, I do not want distributions cluster packages with random tools. That is going to get messy. If we ever think such a recover is needed, then it be better suited to be included in iwctl. I moved both tools in DAEMON since once you disable iwd binary, none of them should be build either. Regards Marcel
Resending in case this got missed. On 10/3/23 12:24 PM, James Prestwood wrote: > If profile encryption is enabled its not out of the question that > somebody might need to decrypt it. This isn't a problem building > from source but IWD as a package likely won't include the decrypt > tool unless its specifically copied out. Add iwd-decrypt-profile > to the list of installed programs like iwctl, iwmon, etc > > This also fixes a minor bug in Makefile.am which was building both > iwd-profile-decrypt and probe-req if DAEMON was true. This should > be TOOLS. > --- > Makefile.am | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Makefile.am b/Makefile.am > index 2e962153..ebabcf1c 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -378,8 +378,9 @@ man_MANS += wired/ead.8 > endif > endif > > -if DAEMON > -noinst_PROGRAMS += tools/probe-req tools/iwd-decrypt-profile > +if TOOLS > +noinst_PROGRAMS += tools/probe-req > +bin_PROGRAMS += tools/iwd-decrypt-profile > > tools_probe_req_SOURCES = tools/probe-req.c src/mpdu.h src/mpdu.c \ > src/ie.h src/ie.c \
Hi James, On 10/20/23 07:52, James Prestwood wrote: > Resending in case this got missed. > Didn't Marcel reply to this: https://lore.kernel.org/iwd/F6D1FD48-E7AC-404B-936A-E4D5E3519FA2@holtmann.org/ Regards, -Denis
On 10/20/23 8:19 AM, Denis Kenzior wrote: > Hi James, > > On 10/20/23 07:52, James Prestwood wrote: >> Resending in case this got missed. >> > > Didn't Marcel reply to this: > https://lore.kernel.org/iwd/F6D1FD48-E7AC-404B-936A-E4D5E3519FA2@holtmann.org/ Sure enough... it must have got filtered to spam. Thanks. > > Regards, > -Denis
Hi Marcel, On 10/4/23 6:07 AM, Marcel Holtmann wrote: > Hi James, > >> If profile encryption is enabled its not out of the question that >> somebody might need to decrypt it. This isn't a problem building >> from source but IWD as a package likely won't include the decrypt >> tool unless its specifically copied out. Add iwd-decrypt-profile >> to the list of installed programs like iwctl, iwmon, etc >> >> This also fixes a minor bug in Makefile.am which was building both >> iwd-profile-decrypt and probe-req if DAEMON was true. This should >> be TOOLS. >> --- >> Makefile.am | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/Makefile.am b/Makefile.am >> index 2e962153..ebabcf1c 100644 >> --- a/Makefile.am >> +++ b/Makefile.am >> @@ -378,8 +378,9 @@ man_MANS += wired/ead.8 >> endif >> endif >> >> -if DAEMON >> -noinst_PROGRAMS += tools/probe-req tools/iwd-decrypt-profile >> +if TOOLS >> +noinst_PROGRAMS += tools/probe-req >> +bin_PROGRAMS += tools/iwd-decrypt-profile >> >> tools_probe_req_SOURCES = tools/probe-req.c src/mpdu.h src/mpdu.c \ >> src/ie.h src/ie.c \ > > I really prefer not installing that tool. If someone shoots themselves in the foot and need to recover, they can install it from the source. In addition, I do not want distributions cluster packages with random tools. That is going to get messy. If we ever think such a recover is needed, then it be better suited to be included in iwctl. > > I moved both tools in DAEMON since once you disable iwd binary, none of them should be build either. This is fine, but it means --enable-tools has no function, just FYI. If adding to iwctl is acceptable then I can go that route. This is a tool we need as far as debugging and potential recovery goes so I'd like it to be installed. I could also just keep this patch applied but I'd prefer upstreaming what I can. I just wonder about the semantics using iwctl in this way. It doesn't seem like it would fit very well. Thanks, James > > Regards > > Marcel >
diff --git a/Makefile.am b/Makefile.am index 2e962153..ebabcf1c 100644 --- a/Makefile.am +++ b/Makefile.am @@ -378,8 +378,9 @@ man_MANS += wired/ead.8 endif endif -if DAEMON -noinst_PROGRAMS += tools/probe-req tools/iwd-decrypt-profile +if TOOLS +noinst_PROGRAMS += tools/probe-req +bin_PROGRAMS += tools/iwd-decrypt-profile tools_probe_req_SOURCES = tools/probe-req.c src/mpdu.h src/mpdu.c \ src/ie.h src/ie.c \