| Message ID | 20231023112245.6112-1-wuqiang.matt@bytedance.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4758560fa268cecfa1144f015aa9f2525d164b7e |
| Headers | show |
| Series | [v1] kprobes: unused header files removed | expand |
On Mon, 23 Oct 2023 19:22:45 +0800 "wuqiang.matt" <wuqiang.matt@bytedance.com> wrote: > As kernel test robot reported, lib/test_objpool.c (trace:probes/for-next) > has linux/version.h included, but version.h is not used at all. Then more > unused headers are found in test_objpool.c and rethook.c, and all of them > should be removed. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202310191512.vvypKU5Z-lkp@intel.com/ Looks good to me. Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org> Thanks, > > Signed-off-by: wuqiang.matt <wuqiang.matt@bytedance.com> > --- > kernel/trace/rethook.c | 2 -- > lib/test_objpool.c | 6 ------ > 2 files changed, 8 deletions(-) > > diff --git a/kernel/trace/rethook.c b/kernel/trace/rethook.c > index 13c8e6773892..6fd7d4ecbbc6 100644 > --- a/kernel/trace/rethook.c > +++ b/kernel/trace/rethook.c > @@ -8,8 +8,6 @@ > #include <linux/preempt.h> > #include <linux/rethook.h> > #include <linux/slab.h> > -#include <linux/sort.h> > -#include <linux/smp.h> > > /* Return hook list (shadow stack by list) */ > > diff --git a/lib/test_objpool.c b/lib/test_objpool.c > index 98b5b37b6eea..a94078402138 100644 > --- a/lib/test_objpool.c > +++ b/lib/test_objpool.c > @@ -6,21 +6,15 @@ > * Copyright: wuqiang.matt@bytedance.com > */ > > -#include <linux/version.h> > #include <linux/errno.h> > #include <linux/module.h> > #include <linux/moduleparam.h> > -#include <linux/sched.h> > -#include <linux/cpumask.h> > #include <linux/completion.h> > #include <linux/kthread.h> > -#include <linux/cpu.h> > -#include <linux/cpuset.h> > #include <linux/slab.h> > #include <linux/vmalloc.h> > #include <linux/delay.h> > #include <linux/hrtimer.h> > -#include <linux/interrupt.h> > #include <linux/objpool.h> > > #define OT_NR_MAX_BULK (16) > -- > 2.40.1 >
diff --git a/kernel/trace/rethook.c b/kernel/trace/rethook.c index 13c8e6773892..6fd7d4ecbbc6 100644 --- a/kernel/trace/rethook.c +++ b/kernel/trace/rethook.c @@ -8,8 +8,6 @@ #include <linux/preempt.h> #include <linux/rethook.h> #include <linux/slab.h> -#include <linux/sort.h> -#include <linux/smp.h> /* Return hook list (shadow stack by list) */ diff --git a/lib/test_objpool.c b/lib/test_objpool.c index 98b5b37b6eea..a94078402138 100644 --- a/lib/test_objpool.c +++ b/lib/test_objpool.c @@ -6,21 +6,15 @@ * Copyright: wuqiang.matt@bytedance.com */ -#include <linux/version.h> #include <linux/errno.h> #include <linux/module.h> #include <linux/moduleparam.h> -#include <linux/sched.h> -#include <linux/cpumask.h> #include <linux/completion.h> #include <linux/kthread.h> -#include <linux/cpu.h> -#include <linux/cpuset.h> #include <linux/slab.h> #include <linux/vmalloc.h> #include <linux/delay.h> #include <linux/hrtimer.h> -#include <linux/interrupt.h> #include <linux/objpool.h> #define OT_NR_MAX_BULK (16)
As kernel test robot reported, lib/test_objpool.c (trace:probes/for-next) has linux/version.h included, but version.h is not used at all. Then more unused headers are found in test_objpool.c and rethook.c, and all of them should be removed. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202310191512.vvypKU5Z-lkp@intel.com/ Signed-off-by: wuqiang.matt <wuqiang.matt@bytedance.com> --- kernel/trace/rethook.c | 2 -- lib/test_objpool.c | 6 ------ 2 files changed, 8 deletions(-)