| Message ID | 20231024194010.99995-1-alexhenrie24@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [resend,1/4] net: ipv6/addrconf: clamp preferred_lft to the maximum allowed | expand |
On Tue, 24 Oct 2023 13:40:01 -0600 Alex Henrie wrote: > Without this patch, there is nothing to stop the preferred lifetime of a > temporary address from being greater than its valid lifetime. If that > was the case, the valid lifetime was effectively ignored. Please: - add cover letter, with the changes from v2 - PATCH net-next v2 in the subject prefix - do not post in-reply-to, instead put a lore link: https://lore.kernel.org/all/20230829054623.104293-1-alexhenrie24@gmail.com/ to the v2 in the cover letter.
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 0b6ee962c84e..e51c30d1daff 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -1397,6 +1397,7 @@ static int ipv6_create_tempaddr(struct inet6_ifaddr *ifp, bool block) idev->cnf.temp_valid_lft + age); cfg.preferred_lft = cnf_temp_preferred_lft + age - idev->desync_factor; cfg.preferred_lft = min_t(__u32, ifp->prefered_lft, cfg.preferred_lft); + cfg.preferred_lft = min_t(__u32, cfg.valid_lft, cfg.preferred_lft); cfg.plen = ifp->prefix_len; tmp_tstamp = ifp->tstamp;
Without this patch, there is nothing to stop the preferred lifetime of a temporary address from being greater than its valid lifetime. If that was the case, the valid lifetime was effectively ignored. Signed-off-by: Alex Henrie <alexhenrie24@gmail.com> --- net/ipv6/addrconf.c | 1 + 1 file changed, 1 insertion(+)