| Message ID | 20231024-vfs-super-freeze-v2-10-599c19f4faac@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Implement freeze and thaw as holder operations | expand |
On Tue, Oct 24, 2023 at 03:01:16PM +0200, Christian Brauner wrote: > Add a comment to @fs_holder_ops that @holder must point to a superblock. > > Signed-off-by: Christian Brauner <brauner@kernel.org> Looks good! Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > --- > include/linux/blkdev.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 1bc776335ff8..abf71cce785c 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -1480,6 +1480,11 @@ struct blk_holder_ops { > int (*thaw)(struct block_device *bdev); > }; > > +/* > + * For filesystems using @fs_holder_ops, the @holder argument passed to > + * helpers used to open and claim block devices via > + * bd_prepare_to_claim() must point to a superblock. > + */ > extern const struct blk_holder_ops fs_holder_ops; > > /* > > -- > 2.34.1 >
On Tue 24-10-23 15:01:16, Christian Brauner wrote: > Add a comment to @fs_holder_ops that @holder must point to a superblock. > > Signed-off-by: Christian Brauner <brauner@kernel.org> Looks good. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > include/linux/blkdev.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 1bc776335ff8..abf71cce785c 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -1480,6 +1480,11 @@ struct blk_holder_ops { > int (*thaw)(struct block_device *bdev); > }; > > +/* > + * For filesystems using @fs_holder_ops, the @holder argument passed to > + * helpers used to open and claim block devices via > + * bd_prepare_to_claim() must point to a superblock. > + */ > extern const struct blk_holder_ops fs_holder_ops; > > /* > > -- > 2.34.1 >
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 1bc776335ff8..abf71cce785c 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -1480,6 +1480,11 @@ struct blk_holder_ops { int (*thaw)(struct block_device *bdev); }; +/* + * For filesystems using @fs_holder_ops, the @holder argument passed to + * helpers used to open and claim block devices via + * bd_prepare_to_claim() must point to a superblock. + */ extern const struct blk_holder_ops fs_holder_ops; /*
Add a comment to @fs_holder_ops that @holder must point to a superblock. Signed-off-by: Christian Brauner <brauner@kernel.org> --- include/linux/blkdev.h | 5 +++++ 1 file changed, 5 insertions(+)