| Message ID | 20231018161848.346947-5-macroalpha82@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | rockchip: Add Powkiddy RK2023 | expand |
On 18/10/2023 18:18, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > The Powkiddy RK2023 is a handheld gaming device made by Powkiddy and > powered by the Rockchip RK3566 SoC. > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > --- > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index a349bf4da6bc..a6612185a7ff 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -674,6 +674,11 @@ properties: > - const: powkiddy,rgb30 > - const: rockchip,rk3566 > > + - description: Powkiddy RK2023 > + items: > + - const: powkiddy,rk2023 This cuold be just enum in previous entry :/ but I remember we talked about this once with Heiko. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > + - const: rockchip,rk3566 Best regards, Krzysztof
Am Donnerstag, 19. Oktober 2023, 11:21:47 CEST schrieb Krzysztof Kozlowski: > On 18/10/2023 18:18, Chris Morgan wrote: > > From: Chris Morgan <macromorgan@hotmail.com> > > > > The Powkiddy RK2023 is a handheld gaming device made by Powkiddy and > > powered by the Rockchip RK3566 SoC. > > > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > > --- > > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > > index a349bf4da6bc..a6612185a7ff 100644 > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > > @@ -674,6 +674,11 @@ properties: > > - const: powkiddy,rgb30 > > - const: rockchip,rk3566 > > > > + - description: Powkiddy RK2023 > > + items: > > + - const: powkiddy,rk2023 > > This cuold be just enum in previous entry :/ but I remember we talked > about this once with Heiko. Keeping similar devices together is perfectly fine. Like we do for example with the Rock PI 4A/4A+/B/B+/C family directly below. The powkiddy,rk2023 really looks like very similar to the rgb30, so could do something similar. The variant I don't like is having one big enum for _all_ boards using the same soc. Heiko > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > + - const: rockchip,rk3566 > > > > Best regards, > Krzysztof > >
On Thu, Oct 19, 2023 at 11:21:47AM +0200, Krzysztof Kozlowski wrote: > On 18/10/2023 18:18, Chris Morgan wrote: > > From: Chris Morgan <macromorgan@hotmail.com> > > > > The Powkiddy RK2023 is a handheld gaming device made by Powkiddy and > > powered by the Rockchip RK3566 SoC. > > > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > > --- > > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > > index a349bf4da6bc..a6612185a7ff 100644 > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > > @@ -674,6 +674,11 @@ properties: > > - const: powkiddy,rgb30 > > - const: rockchip,rk3566 > > > > + - description: Powkiddy RK2023 > > + items: > > + - const: powkiddy,rk2023 > > This cuold be just enum in previous entry :/ but I remember we talked > about this once with Heiko. For hardware that requires a different device tree, is that possible? While most of the devices I've worked on for the RK3566 series are very similar for the moment only 1 is identical (the RG353P and the RG353M) and can use the same device tree. Also I have one more Powkiddy device to send probably in the next week or two, then I'll be breaking for a while from new devices. :-) Thank you, Chris > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > + - const: rockchip,rk3566 > > > > Best regards, > Krzysztof >
Hey Chris, Am Donnerstag, 19. Oktober 2023, 16:43:56 CEST schrieb Chris Morgan: > On Thu, Oct 19, 2023 at 11:21:47AM +0200, Krzysztof Kozlowski wrote: > > On 18/10/2023 18:18, Chris Morgan wrote: > > > From: Chris Morgan <macromorgan@hotmail.com> > > > > > > The Powkiddy RK2023 is a handheld gaming device made by Powkiddy and > > > powered by the Rockchip RK3566 SoC. > > > > > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > > > --- > > > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > > > index a349bf4da6bc..a6612185a7ff 100644 > > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > > > @@ -674,6 +674,11 @@ properties: > > > - const: powkiddy,rgb30 > > > - const: rockchip,rk3566 > > > > > > + - description: Powkiddy RK2023 > > > + items: > > > + - const: powkiddy,rk2023 > > > > This cuold be just enum in previous entry :/ but I remember we talked > > about this once with Heiko. > > For hardware that requires a different device tree, is that possible? > While most of the devices I've worked on for the RK3566 series are very > similar for the moment only 1 is identical (the RG353P and the RG353M) > and can use the same device tree. In my reply I pointed to the Rock PI 4A/4A+/B/B+/C family, which also has different devicetrees but is part of the same family of device designs. So similar Powkiddy RK3568 based gaming handhelds also sound like a nice family name in the description ;-) . Heiko
On Thu, Oct 19, 2023 at 07:45:17PM +0200, Heiko Stübner wrote: > Hey Chris, > > Am Donnerstag, 19. Oktober 2023, 16:43:56 CEST schrieb Chris Morgan: > > On Thu, Oct 19, 2023 at 11:21:47AM +0200, Krzysztof Kozlowski wrote: > > > On 18/10/2023 18:18, Chris Morgan wrote: > > > > From: Chris Morgan <macromorgan@hotmail.com> > > > > > > > > The Powkiddy RK2023 is a handheld gaming device made by Powkiddy and > > > > powered by the Rockchip RK3566 SoC. > > > > > > > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > > > > --- > > > > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > > > > index a349bf4da6bc..a6612185a7ff 100644 > > > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > > > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > > > > @@ -674,6 +674,11 @@ properties: > > > > - const: powkiddy,rgb30 > > > > - const: rockchip,rk3566 > > > > > > > > + - description: Powkiddy RK2023 > > > > + items: > > > > + - const: powkiddy,rk2023 > > > > > > This cuold be just enum in previous entry :/ but I remember we talked > > > about this once with Heiko. > > > > For hardware that requires a different device tree, is that possible? > > While most of the devices I've worked on for the RK3566 series are very > > similar for the moment only 1 is identical (the RG353P and the RG353M) > > and can use the same device tree. > > In my reply I pointed to the Rock PI 4A/4A+/B/B+/C family, which also has > different devicetrees but is part of the same family of device designs. > > So similar Powkiddy RK3568 based gaming handhelds also sound like > a nice family name in the description ;-) . Gotcha, I can do that. Would you like for me to go back and do the same for the Anbernic devices as well? I can do it as part of a seperate patch series. Thank you. > > > Heiko > >
Hi Chris, Am Freitag, 20. Oktober 2023, 17:03:08 CEST schrieb Chris Morgan: > On Thu, Oct 19, 2023 at 07:45:17PM +0200, Heiko Stübner wrote: > > Hey Chris, > > > > Am Donnerstag, 19. Oktober 2023, 16:43:56 CEST schrieb Chris Morgan: > > > On Thu, Oct 19, 2023 at 11:21:47AM +0200, Krzysztof Kozlowski wrote: > > > > On 18/10/2023 18:18, Chris Morgan wrote: > > > > > From: Chris Morgan <macromorgan@hotmail.com> > > > > > > > > > > The Powkiddy RK2023 is a handheld gaming device made by Powkiddy and > > > > > powered by the Rockchip RK3566 SoC. > > > > > > > > > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > > > > > --- > > > > > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > > > > > 1 file changed, 5 insertions(+) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > > > > > index a349bf4da6bc..a6612185a7ff 100644 > > > > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > > > > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > > > > > @@ -674,6 +674,11 @@ properties: > > > > > - const: powkiddy,rgb30 > > > > > - const: rockchip,rk3566 > > > > > > > > > > + - description: Powkiddy RK2023 > > > > > + items: > > > > > + - const: powkiddy,rk2023 > > > > > > > > This cuold be just enum in previous entry :/ but I remember we talked > > > > about this once with Heiko. > > > > > > For hardware that requires a different device tree, is that possible? > > > While most of the devices I've worked on for the RK3566 series are very > > > similar for the moment only 1 is identical (the RG353P and the RG353M) > > > and can use the same device tree. > > > > In my reply I pointed to the Rock PI 4A/4A+/B/B+/C family, which also has > > different devicetrees but is part of the same family of device designs. > > > > So similar Powkiddy RK3568 based gaming handhelds also sound like > > a nice family name in the description ;-) . > > Gotcha, I can do that. Would you like for me to go back and do the same > for the Anbernic devices as well? I can do it as part of a seperate > patch series. that doing that for the Anberic devices would be really nice too, so yes please :-) . Thanks Heiko
On Tue, Oct 24, 2023 at 05:47:37PM +0200, Heiko Stübner wrote: > Hi Chris, > > Am Freitag, 20. Oktober 2023, 17:03:08 CEST schrieb Chris Morgan: > > On Thu, Oct 19, 2023 at 07:45:17PM +0200, Heiko Stübner wrote: > > > Hey Chris, > > > > > > Am Donnerstag, 19. Oktober 2023, 16:43:56 CEST schrieb Chris Morgan: > > > > On Thu, Oct 19, 2023 at 11:21:47AM +0200, Krzysztof Kozlowski wrote: > > > > > On 18/10/2023 18:18, Chris Morgan wrote: > > > > > > From: Chris Morgan <macromorgan@hotmail.com> > > > > > > > > > > > > The Powkiddy RK2023 is a handheld gaming device made by Powkiddy and > > > > > > powered by the Rockchip RK3566 SoC. > > > > > > > > > > > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > > > > > > --- > > > > > > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > > > > > > 1 file changed, 5 insertions(+) > > > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > > > > > > index a349bf4da6bc..a6612185a7ff 100644 > > > > > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > > > > > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > > > > > > @@ -674,6 +674,11 @@ properties: > > > > > > - const: powkiddy,rgb30 > > > > > > - const: rockchip,rk3566 > > > > > > > > > > > > + - description: Powkiddy RK2023 > > > > > > + items: > > > > > > + - const: powkiddy,rk2023 > > > > > > > > > > This cuold be just enum in previous entry :/ but I remember we talked > > > > > about this once with Heiko. > > > > > > > > For hardware that requires a different device tree, is that possible? > > > > While most of the devices I've worked on for the RK3566 series are very > > > > similar for the moment only 1 is identical (the RG353P and the RG353M) > > > > and can use the same device tree. > > > > > > In my reply I pointed to the Rock PI 4A/4A+/B/B+/C family, which also has > > > different devicetrees but is part of the same family of device designs. > > > > > > So similar Powkiddy RK3568 based gaming handhelds also sound like > > > a nice family name in the description ;-) . > > > > Gotcha, I can do that. Would you like for me to go back and do the same > > for the Anbernic devices as well? I can do it as part of a seperate > > patch series. > > that doing that for the Anberic devices would be really nice too, so > yes please :-) . > > Thanks > Heiko > > Did you want me to resubmit the series or just push the changes on top of this one? I'll get them both queued up. Thank you.
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml index a349bf4da6bc..a6612185a7ff 100644 --- a/Documentation/devicetree/bindings/arm/rockchip.yaml +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml @@ -674,6 +674,11 @@ properties: - const: powkiddy,rgb30 - const: rockchip,rk3566 + - description: Powkiddy RK2023 + items: + - const: powkiddy,rk2023 + - const: rockchip,rk3566 + - description: Radxa Compute Module 3(CM3) items: - enum: