mbox series

[v1,0/3] gpio: mmio: Make driver agnostic

Message ID 20231025184259.250588-1-andriy.shevchenko@linux.intel.com (mailing list archive)
Headers show
Series gpio: mmio: Make driver agnostic | expand

Message

Andy Shevchenko Oct. 25, 2023, 6:42 p.m. UTC 
Driver uses so far some OF APIs when generic fwnode ones can be used.
Replace these APIs accordingly. Note, this will help to clean up OF
headers even more.

Andy Shevchenko (3):
  device property: Implement device_is_big_endian()
  gpio: mmio: Make use of device properties
  gpio: mmio: Clean up headers

 drivers/gpio/gpio-mmio.c | 53 +++++++++++++++-------------------------
 include/linux/property.h | 26 ++++++++++++++++++++
 2 files changed, 46 insertions(+), 33 deletions(-)

Comments

Linus Walleij Oct. 25, 2023, 7:55 p.m. UTC | #1 
On Wed, Oct 25, 2023 at 8:50 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

> Driver uses so far some OF APIs when generic fwnode ones can be used.
> Replace these APIs accordingly. Note, this will help to clean up OF
> headers even more.

Clean, elegant and does exactly what we want.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Bartosz Golaszewski Dec. 18, 2023, 12:43 p.m. UTC | #2 
On Wed, Oct 25, 2023 at 8:50 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Driver uses so far some OF APIs when generic fwnode ones can be used.
> Replace these APIs accordingly. Note, this will help to clean up OF
> headers even more.
>
> Andy Shevchenko (3):
>   device property: Implement device_is_big_endian()
>   gpio: mmio: Make use of device properties
>   gpio: mmio: Clean up headers
>
>  drivers/gpio/gpio-mmio.c | 53 +++++++++++++++-------------------------
>  include/linux/property.h | 26 ++++++++++++++++++++
>  2 files changed, 46 insertions(+), 33 deletions(-)
>
> --
> 2.40.0.1.gaa8946217a0b
>

Applied patches 2 and 3.

Bart
Andy Shevchenko Dec. 18, 2023, 1:36 p.m. UTC | #3 
On Mon, Dec 18, 2023 at 03:35:28PM +0200, Andy Shevchenko wrote:
> On Mon, Dec 18, 2023 at 01:43:40PM +0100, Bartosz Golaszewski wrote:

...

> Thank you! I guess you forgot to add --sign-off to the `git merge ...`

Sorry, it's --signoff.
Bartosz Golaszewski Dec. 18, 2023, 1:37 p.m. UTC | #4 
On Mon, Dec 18, 2023 at 2:36 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Mon, Dec 18, 2023 at 03:35:28PM +0200, Andy Shevchenko wrote:
> > On Mon, Dec 18, 2023 at 01:43:40PM +0100, Bartosz Golaszewski wrote:
>
> ...
>
> > Thank you! I guess you forgot to add --sign-off to the `git merge ...`
>
> Sorry, it's --signoff.
>

I never sign-off on merges though, is it mandatory? Probably not as
there are no warnings from next like for regular commits about missing
sign-offs.

Bart

> --
> With Best Regards,
> Andy Shevchenko
>
>
Andy Shevchenko Dec. 18, 2023, 3:02 p.m. UTC | #5 
On Mon, Dec 18, 2023 at 02:37:48PM +0100, Bartosz Golaszewski wrote:
> On Mon, Dec 18, 2023 at 2:36 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Mon, Dec 18, 2023 at 03:35:28PM +0200, Andy Shevchenko wrote:
> > > On Mon, Dec 18, 2023 at 01:43:40PM +0100, Bartosz Golaszewski wrote:

...

> > > Thank you! I guess you forgot to add --sign-off to the `git merge ...`
> >
> > Sorry, it's --signoff.
> 
> I never sign-off on merges though, is it mandatory? Probably not as
> there are no warnings from next like for regular commits about missing
> sign-offs.

No idea. I do it as it is harmless, and makes commit more robust.

For me it's fine, but I leave for me to exclaim later "Yay, had told ya!" :-)