Message ID | 20231025183213.874283-1-jacob.e.keller@intel.com (mailing list archive) |
---|---|
State | Accepted |
Commit | 53798666648af3aa0dd512c2380576627237a800 |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | [net] iavf: in iavf_down, disable queues when removing the driver | expand |
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 25 Oct 2023 11:32:13 -0700 you wrote: > From: Michal Schmidt <mschmidt@redhat.com> > > In iavf_down, we're skipping the scheduling of certain operations if > the driver is being removed. However, the IAVF_FLAG_AQ_DISABLE_QUEUES > request must not be skipped in this case, because iavf_close waits > for the transition to the __IAVF_DOWN state, which happens in > iavf_virtchnl_completion after the queues are released. > > [...] Here is the summary with links: - [net] iavf: in iavf_down, disable queues when removing the driver https://git.kernel.org/netdev/net/c/53798666648a You are awesome, thank you!
diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c index 5b5c0525aa13..b3434dbc90d6 100644 --- a/drivers/net/ethernet/intel/iavf/iavf_main.c +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c @@ -1437,9 +1437,9 @@ void iavf_down(struct iavf_adapter *adapter) adapter->aq_required |= IAVF_FLAG_AQ_DEL_FDIR_FILTER; if (!list_empty(&adapter->adv_rss_list_head)) adapter->aq_required |= IAVF_FLAG_AQ_DEL_ADV_RSS_CFG; - adapter->aq_required |= IAVF_FLAG_AQ_DISABLE_QUEUES; } + adapter->aq_required |= IAVF_FLAG_AQ_DISABLE_QUEUES; mod_delayed_work(adapter->wq, &adapter->watchdog_task, 0); }