| Message ID | 20231024124109.384973-1-jouni.hogander@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Framework for display parameters | expand |
On Tue, 2023-10-24 at 15:40 +0300, Jouni Högander wrote: > Currently all module parameters are handled by i915_param.c/h. This > is a problem for display parameters when Xe driver is used. > > This patch set adds a mechanism to add parameters specific to the > display. This is mainly copied from existing i915 parameters > implementation with some naming changes and taking into account > varying driver name. > > Also all display specific module parameters are moved under display > and the > module parameter are all converted as non-writable. This should be ok > as we have writable device parameters under debugfs. > > v4: > - Change verbose_state_checks device parameter permissions to 0400 > > v3: > - Change enable_ip as boolean > - Fix enable_psr2_sel_fetch description > - Add default value into psr_safest_params description > - Drop unused predefinition (dentry) from > intel_display_debugfs_params.h > v2: > - Drop fastboot parameter > - Include display parameters into i915_capabilities debugfs > interface Thank you Luca, Jani and Tvrtko for checking my patches. These are all now merged. BR, Jouni Högander > > Cc: Jani Nikula <jani.nikula@intel.com> > Cc: Uma Shankar <uma.shankar@intel.com> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Luca Coelho <luca@coelho.fi> > > Jouni Högander (23): > drm/i915/display: Add framework to add parameters specific to > display > drm/i915/display: Dump also display parameters > drm/i915/display: Move enable_fbc module parameter under display > drm/i915/display: Move psr related module parameters under display > drm/i915/display: Move vbt_firmware module parameter under display > drm/i915/display: Move lvds_channel_mode module parameter under > display > drm/i915/display: Move panel_use_ssc module parameter under display > drm/i915/display: Move vbt_sdvo_panel_type module parameter under > display > drm/i915/display: Move enable_dc module parameter under display > drm/i915/display: Move enable_dpt module parameter under display > drm/i915/display: Move enable_sagv module parameter under display > drm/i915/display: Move disable_power_well module parameter under > display > drm/i915/display: Move enable_ips module parameter under display > drm/i915/display: Move invert_brightness module parameter under > display > drm/i915/display: Move edp_vswing module parameter under display > drm/i915/display: Move enable_dpcd_backlight module parameter under > display > drm/i915/display: Move load_detect_test parameter under display > drm/i915/display: Move force_reset_modeset_test parameter under > display > drm/i915/display: Move disable_display parameter under display > drm/i915/display: Use device parameters instead of module in > I915_STATE_WARN > drm/i915/display: Move verbose_state_checks under display > drm/i915/display: Move nuclear_pageflip under display > drm/i915/display: Move enable_dp_mst under display > > drivers/gpu/drm/i915/Makefile | 2 + > drivers/gpu/drm/i915/display/hsw_ips.c | 4 +- > drivers/gpu/drm/i915/display/i9xx_wm.c | 2 +- > .../gpu/drm/i915/display/intel_backlight.c | 9 +- > drivers/gpu/drm/i915/display/intel_bios.c | 6 +- > drivers/gpu/drm/i915/display/intel_crt.c | 4 +- > drivers/gpu/drm/i915/display/intel_display.h | 2 +- > .../gpu/drm/i915/display/intel_display_core.h | 2 + > .../drm/i915/display/intel_display_debugfs.c | 2 + > .../display/intel_display_debugfs_params.c | 176 ++++++++++++++ > .../display/intel_display_debugfs_params.h | 13 ++ > .../drm/i915/display/intel_display_device.c | 13 +- > .../drm/i915/display/intel_display_device.h | 1 + > .../drm/i915/display/intel_display_params.c | 217 > ++++++++++++++++++ > .../drm/i915/display/intel_display_params.h | 61 +++++ > .../drm/i915/display/intel_display_power.c | 14 +- > .../drm/i915/display/intel_display_reset.c | 2 +- > drivers/gpu/drm/i915/display/intel_dp.c | 6 +- > .../drm/i915/display/intel_dp_aux_backlight.c | 4 +- > drivers/gpu/drm/i915/display/intel_dpt.c | 6 +- > drivers/gpu/drm/i915/display/intel_fb.c | 2 +- > drivers/gpu/drm/i915/display/intel_fbc.c | 10 +- > drivers/gpu/drm/i915/display/intel_lvds.c | 4 +- > drivers/gpu/drm/i915/display/intel_opregion.c | 2 +- > drivers/gpu/drm/i915/display/intel_panel.c | 4 +- > drivers/gpu/drm/i915/display/intel_psr.c | 14 +- > .../drm/i915/display/skl_universal_plane.c | 2 +- > drivers/gpu/drm/i915/display/skl_watermark.c | 5 +- > drivers/gpu/drm/i915/i915_debugfs.c | 3 + > drivers/gpu/drm/i915/i915_driver.c | 2 + > drivers/gpu/drm/i915/i915_gpu_error.c | 3 + > drivers/gpu/drm/i915/i915_gpu_error.h | 2 + > drivers/gpu/drm/i915/i915_params.c | 89 ------- > drivers/gpu/drm/i915/i915_params.h | 22 -- > 34 files changed, 548 insertions(+), 162 deletions(-) > create mode 100644 > drivers/gpu/drm/i915/display/intel_display_debugfs_params.c > create mode 100644 > drivers/gpu/drm/i915/display/intel_display_debugfs_params.h > create mode 100644 > drivers/gpu/drm/i915/display/intel_display_params.c > create mode 100644 > drivers/gpu/drm/i915/display/intel_display_params.h >
Currently all module parameters are handled by i915_param.c/h. This is a problem for display parameters when Xe driver is used. This patch set adds a mechanism to add parameters specific to the display. This is mainly copied from existing i915 parameters implementation with some naming changes and taking into account varying driver name. Also all display specific module parameters are moved under display and the module parameter are all converted as non-writable. This should be ok as we have writable device parameters under debugfs. v4: - Change verbose_state_checks device parameter permissions to 0400 v3: - Change enable_ip as boolean - Fix enable_psr2_sel_fetch description - Add default value into psr_safest_params description - Drop unused predefinition (dentry) from intel_display_debugfs_params.h v2: - Drop fastboot parameter - Include display parameters into i915_capabilities debugfs interface Cc: Jani Nikula <jani.nikula@intel.com> Cc: Uma Shankar <uma.shankar@intel.com> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Luca Coelho <luca@coelho.fi> Jouni Högander (23): drm/i915/display: Add framework to add parameters specific to display drm/i915/display: Dump also display parameters drm/i915/display: Move enable_fbc module parameter under display drm/i915/display: Move psr related module parameters under display drm/i915/display: Move vbt_firmware module parameter under display drm/i915/display: Move lvds_channel_mode module parameter under display drm/i915/display: Move panel_use_ssc module parameter under display drm/i915/display: Move vbt_sdvo_panel_type module parameter under display drm/i915/display: Move enable_dc module parameter under display drm/i915/display: Move enable_dpt module parameter under display drm/i915/display: Move enable_sagv module parameter under display drm/i915/display: Move disable_power_well module parameter under display drm/i915/display: Move enable_ips module parameter under display drm/i915/display: Move invert_brightness module parameter under display drm/i915/display: Move edp_vswing module parameter under display drm/i915/display: Move enable_dpcd_backlight module parameter under display drm/i915/display: Move load_detect_test parameter under display drm/i915/display: Move force_reset_modeset_test parameter under display drm/i915/display: Move disable_display parameter under display drm/i915/display: Use device parameters instead of module in I915_STATE_WARN drm/i915/display: Move verbose_state_checks under display drm/i915/display: Move nuclear_pageflip under display drm/i915/display: Move enable_dp_mst under display drivers/gpu/drm/i915/Makefile | 2 + drivers/gpu/drm/i915/display/hsw_ips.c | 4 +- drivers/gpu/drm/i915/display/i9xx_wm.c | 2 +- .../gpu/drm/i915/display/intel_backlight.c | 9 +- drivers/gpu/drm/i915/display/intel_bios.c | 6 +- drivers/gpu/drm/i915/display/intel_crt.c | 4 +- drivers/gpu/drm/i915/display/intel_display.h | 2 +- .../gpu/drm/i915/display/intel_display_core.h | 2 + .../drm/i915/display/intel_display_debugfs.c | 2 + .../display/intel_display_debugfs_params.c | 176 ++++++++++++++ .../display/intel_display_debugfs_params.h | 13 ++ .../drm/i915/display/intel_display_device.c | 13 +- .../drm/i915/display/intel_display_device.h | 1 + .../drm/i915/display/intel_display_params.c | 217 ++++++++++++++++++ .../drm/i915/display/intel_display_params.h | 61 +++++ .../drm/i915/display/intel_display_power.c | 14 +- .../drm/i915/display/intel_display_reset.c | 2 +- drivers/gpu/drm/i915/display/intel_dp.c | 6 +- .../drm/i915/display/intel_dp_aux_backlight.c | 4 +- drivers/gpu/drm/i915/display/intel_dpt.c | 6 +- drivers/gpu/drm/i915/display/intel_fb.c | 2 +- drivers/gpu/drm/i915/display/intel_fbc.c | 10 +- drivers/gpu/drm/i915/display/intel_lvds.c | 4 +- drivers/gpu/drm/i915/display/intel_opregion.c | 2 +- drivers/gpu/drm/i915/display/intel_panel.c | 4 +- drivers/gpu/drm/i915/display/intel_psr.c | 14 +- .../drm/i915/display/skl_universal_plane.c | 2 +- drivers/gpu/drm/i915/display/skl_watermark.c | 5 +- drivers/gpu/drm/i915/i915_debugfs.c | 3 + drivers/gpu/drm/i915/i915_driver.c | 2 + drivers/gpu/drm/i915/i915_gpu_error.c | 3 + drivers/gpu/drm/i915/i915_gpu_error.h | 2 + drivers/gpu/drm/i915/i915_params.c | 89 ------- drivers/gpu/drm/i915/i915_params.h | 22 -- 34 files changed, 548 insertions(+), 162 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_display_debugfs_params.c create mode 100644 drivers/gpu/drm/i915/display/intel_display_debugfs_params.h create mode 100644 drivers/gpu/drm/i915/display/intel_display_params.c create mode 100644 drivers/gpu/drm/i915/display/intel_display_params.h